Branch: refs/heads/bootstrap-master
Home: https://github.com/openSUSE/open-build-service
Commit: 15273c4123b8c5bfc1e01ba04abdcd51be7f9120
https://github.com/openSUSE/open-build-service/commit/15273c4123b8c5bfc1e01b...
Author: Moises Deniz Aleman
Date: 2018-09-20 (Thu, 20 Sep 2018)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
R src/api/app/controllers/webui2/request_controller.rb
M src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml
M src/api/app/views/webui2/webui/package/show.html.haml
M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml
M src/api/spec/bootstrap/features/webui/packages_spec.rb
Log Message:
-----------
Refactor render_dialog for change_devel_request_dialog
Instead of performing an Ajax call that answers with a Javascript code
that updates the view to create and show the modal we now render the
modal if needed and show it via Javascript locally.
This is better because we only need one SQL query more and we save a XHR
request.
Co-authored-by: David Kang
Commit: b90d6f6ae801da558bff9aa1e07d4041a51cd5c9
https://github.com/openSUSE/open-build-service/commit/b90d6f6ae801da558bff9a...
Author: Moises Deniz Aleman
Date: 2018-09-20 (Thu, 20 Sep 2018)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml
M src/api/spec/features/webui/packages_spec.rb
Log Message:
-----------
Refactor change_devel_request_modal view
This modal had some "if" not needed anymore so we simplified the code a
lot.
Also we marked the request controller action to be deleted in the
migration to Boostrap.
Co-authored-by: David Kang
Commit: 810495694589784c7042618a9199458bc0503378
https://github.com/openSUSE/open-build-service/commit/810495694589784c704261...
Author: Moisés Déniz Alemán
Date: 2018-09-21 (Fri, 21 Sep 2018)
Changed paths:
M src/api/app/controllers/webui/request_controller.rb
R src/api/app/controllers/webui2/request_controller.rb
M src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml
M src/api/app/views/webui2/webui/package/show.html.haml
M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml
M src/api/spec/bootstrap/features/webui/packages_spec.rb
M src/api/spec/features/webui/packages_spec.rb
Log Message:
-----------
Merge pull request #5876 from mdeniz/bootstrap/refactor_render_dialog
Refactor render_dialog call in request controller for webui2
Compare: https://github.com/openSUSE/open-build-service/compare/3c28941a6e11...810495...
**NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
