![](https://seccdn.libravatar.org/avatar/9181eb84f9c35729a3bad740fb7f9d93.jpg?s=120&d=mm&r=g)
Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: f44d5b4121e9db836bd9e8aecc1c8146125d4012 https://github.com/openSUSE/open-build-service/commit/f44d5b4121e9db836bd9e8... Author: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.4 Commit: 4cfae4c02b9b88a9d10a3a45ddf97958c70c819e https://github.com/openSUSE/open-build-service/commit/4cfae4c02b9b88a9d10a3a... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update sanitize to version 6.0.0 Commit: 75d09df2f3b1d5ceae04b488226b540d99c4da3d https://github.com/openSUSE/open-build-service/commit/75d09df2f3b1d5ceae04b4... Author: Dany Marcoux <dmarcoux@posteo.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Fix broken specs in Kiwi::Image model Two specs were failing when checking if the subject didn't have errors: ``` Failure/Error: it { expect(subject.errors).to be_empty } expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:226:in `block (5 levels) in <top (required)>' Failure/Error: expect(subject.errors).to be_empty expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:279:in `block (4 levels) in <top (required)>' ``` Those errors weren't reported before nokogiri _1.13.0_, as noted in the changelog upstream:
XML::DocumentFragment#errors now correctly contains any parsing errors encountered. Previously this was always empty. (Note that HTML::DocumentFragment#errors already did this.)
Relying on XML::DocumentFragment was wrong since the XML generated by the Kiwi::Image's to_xml and kiwi_body methods is not a document fragment, but a document. They contain a XML declaration (`<?xml ...?>`), so changing the class solves the issue. Commit: 173849c522f6d9f720f67941f62065d7544fcef1 https://github.com/openSUSE/open-build-service/commit/173849c522f6d9f720f679... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Merge pull request #12432 from openSUSE/depfu/update/srcapi-2.10/nokogiri-1.13.4 🚨 [security] [src/api - 2.10] Update nokogiri: 1.11.7 → 1.13.4 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/0218ebd4231e...173849...