On Fri, Apr 26, 2013 at 6:28 PM, Takashi Iwai <tiwai@suse.de> wrote:
Just took a quick glance at the patch (not tried yet), I see that the amount of changes isn't that big, less than I was afraid. But, it's intrusive changes and doesn't look like keeping compatible with the old code (e.g. the buffer is always allocated doubly after the patch). And it's pretty hard to read such a "big merged patch" without any comment about the changes it does.
Really appreciate your help, tiwai! I just used the 3.0+ patch, actually it's a "patch series", 2.6 patches are here: http://blog.chinaunix.net/uid-436750-id-2123586.html And his coding style is really...well, maybe he didn't mean to upstream it since so many years passed. As he said: This patch was done in 2006, with kernel 2.6.17, and used on my "self-designed" distribution "Olive"
In general, for openSUSE kernel, we want to avoid wild patches as much as possible. So, for any new patches, "upstream first" rule wins. IIRC, there have been multiple attempts for UTF8 wide-char support on fbcon, but they all failed in the upstream.
Agreed with our policy. It's the first patch with such functions I found, so I'm un-experienced with that.
Hence, I guess it's a quite long way to go in this case, too. Let's see...
Maybe I should ask him for code comments and efforts to upstream it from his side. Because I know nothing about coding, if I do that, I think Linus will certainly rant at me in public... Marguerite -- To unsubscribe, e-mail: opensuse-m17n+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-m17n+owner@opensuse.org