On Thu, 2022-09-15 at 08:54 +0200, Michael Vetter wrote:

On Wed, 14 Sep 2022 15:21:14 -0700 Shawn W Dunn wrote:

...

Just so I make sure it gets posted up here to the ML.

https://github.com/sfalken/lxqt-branding-openSUSE

That's the beginning of a lxqt-branding package for LXQt-openSUSE.

It includes Michaels themes that he developed a few years back, but never added into the repositories.  

They are all in the repos :-)

https://build.opensuse.org/package/show/X11:LXQt/lxqt-theme-openSUSE-light https://github.com/jubalh/lxqt-theme-openSUSE-leaper -> https://build.opensuse.org/package/show/X11:LXQt/lxqt-theme-openSUSE-leaper https://github.com/jubalh/lxqt-theme-openSUSE-default -> https://build.opensuse.org/package/show/X11:LXQt/lxqt-theme-openSUSE-default

So I would actually propose to depend on them rather to hardcopy them into the repo, no?

I tagged all the of the themes, for example: https://github.com/jubalh/lxqt-theme-openSUSE-light/releases/tag/0.1 So that we can have proper changelogs and versions for them :)

So they are all availble in official repos. Just not installed/set by default.

If I see it right then the branding package should require those packages and then set it in the config file to one of them but not copy the theme in-tree into the branding package.

Cheers

6 of one, Half-dozen of another. Some desktops ship individual theme packages, some ship consolidated "theme packages" and some include them in the -branding. The overall size of the -branding package isn't impacted by the inclusion of the themes, and they aren't *required*, but I don't personally really see the benefit in shipping them as seperate RPMS, when they're really intended to provide "branding". It isn't something that I feel so strongly about that I'm going to plant a flag over it. If we'd rather ship a -branding and individual - theme rpms, that's fine.