[kubic-bugs] [Bug 1105992] New: Transactional-Update broken in snapshot 20180824
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 Bug ID: 1105992 Summary: Transactional-Update broken in snapshot 20180824 Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Major Priority: P5 - None Component: Kubic Assignee: iforster@suse.com Reporter: rbrown@suse.com QA Contact: qa-bugs@suse.de CC: kubic-bugs@opensuse.org Found By: --- Blocker: --- 0824 introduced transactional-update 2.6 https://build.opensuse.org/package/rdiff/openSUSE:Factory/transactional-update?linkrev=base&rev=32 It's failing all tests and appears to be displaying incorrect behaviour https://openqa.opensuse.org/tests/742638#step/transactional_update/57 Compared to 0822 I'm noticing the following differences: https://openqa.opensuse.org/tests/741289#step/transactional_update/57 (note: the code for the test does not appear to have changed: https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests... ) Update test #2 is meant to be a no-op, because it should be updating when there is nothing to do In 0822 the pointless `cleanup up` test produced the following logs:
# Result: Checking for newer version. transactional-update 2.6 started Options: cleanup up Separate /var detected. Adding cleanup algorithm to snapshot #6 Adding "important=yes" to snapshot #6 zypper: nothing to update transactional-update finished trup-0-
In 0824 the exact same test produces the following logs:
# Result: Checking for newer version. transactional-update 2.6 started Options: cleanup up Separate /var detected. Adding cleanup algorithm to snapshot #6 Adding "important=yes" to snapshot #6 /usr/sbin/transactional-update: line 760: [: too many arguments Creating read-only snapshot of current system state (#8) Copying /etc state into snapshot /.snapshots/9/snapshot Copying /etc state into snapshot /.snapshots/10/snapshot Calling zypper up Loading repository data... Reading installed packages...
Nothing to do. Trying to rebuild kdump initrd Please reboot your machine to activate the changes and avoid data loss. transactional-update finished trup-0-
I find the following lines in 0824 suspicious, leading me to the questions below:
/usr/sbin/transactional-update: line 760: [: too many arguments
Why does txl-upd now complain about too many arguments?
Creating read-only snapshot of current system state (#8) Copying /etc state into snapshot /.snapshots/9/snapshot Copying /etc state into snapshot /.snapshots/10/snapshot
Why does txl-upd make 3 snapshots (8, 9, 10) even when there is nothing to do? Why does txl-upd make 2 snapshots for /etc? (This is less suspicious, I'm just curious) Bug marked as Major because it makes all of Kubics tests red ;) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 http://bugzilla.opensuse.org/show_bug.cgi?id=1105992#c1 Ignaz Forster <iforster@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #1 from Ignaz Forster <iforster@suse.com> --- Zypper added a new field to its output which wasn't parsed correctly in transactional-update. This has been fixed in https://build.opensuse.org/request/show/631727. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 http://bugzilla.opensuse.org/show_bug.cgi?id=1105992#c7 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suse-beta@cboltz.de --- Comment #7 from Christian Boltz <suse-beta@cboltz.de> --- (In reply to Ignaz Forster from comment #1)
Zypper added a new field to its output which wasn't parsed correctly in transactional-update.
Just curious - do you parse the _text_ output of zypper? Using zypper --xmlout might be a better / more robust solution ;-) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 http://bugzilla.opensuse.org/show_bug.cgi?id=1105992#c9 --- Comment #9 from Ignaz Forster <iforster@suse.com> --- Yes, we are using the XML output of zypper - but are parsing that output via sed :-P We haven't been using any proper XML parser in the past to keep the dependencies minimal. This will hopefully change when integrating transactional-updates into zypper properly. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 http://bugzilla.opensuse.org/show_bug.cgi?id=1105992#c18 --- Comment #18 from Ignaz Forster <iforster@suse.com> --- (In reply to Thorsten Kukuk from comment #4)
The fix is not really correct (see https://trello.com/c/WPmWWpIx/60-transactional-update-parse-new-zypper- values).
If the attribute "packages-to-change" exist, we should use that to find out, if there are pending updates. If this attribute does not exist, we should fall back to the current attributes (which means best guess, which could go wrong).
Added support for the "packages-to-change" attribute. If this attribute does not exist in zypper's XML output then the old attributes will be used for backwards compatibility. Fixed since transactional-update 2.10 (https://github.com/openSUSE/transactional-update/commit/3aa0ae202da94c0bd125...). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1105992 http://bugzilla.opensuse.org/show_bug.cgi?id=1105992#c19 Ignaz Forster <iforster@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #19 from Ignaz Forster <iforster@suse.com> --- Available since Tumbleweed snapshot 20181120; also released as an update for Leap 15. The patch was also backported and released for CaaSP. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com