Re: [opensuse-kernel] Could CONFIG_DRM_AMDGPU_CIK be enabled in the TW builds?
(adding back opensuse-kernel. Or did you intentionally only send the reply to me?) On 2016-08-22 14:46, Jeff Mahoney wrote:
On 8/22/16 6:37 AM, Michal Marek wrote:
On 2016-08-21 16:42, Jeff Mahoney wrote:
BTW, AFAIK this is the first pull from the github repo. The github repo is actually a clone of our internal repository so we can't use github pull requests directly, but since github is just git behind the scenes, it was super easy to just pull directly from your branch.
Did you actually get a github notification about the pull request? I noticed a notification in my mailbox this morning and wanted to forward it to you. I guess you had learned from Jason's email meanwhile.
Yeah, I only saw Jason's email. If we have something automated, it'd be nice to get the URL to pull from directly. Ideally that would be a URL for the pull request that I can plug right into git. In this case, Jason had only made the one change so it was easy to pull from his master branch.
I was thinking about making it simple and stupid and sending any pull requests to this list. However, I do not want to create a mailbomb and send all new kernel-source _commits_ here. Does anybody know how to fine-tune this? The interface for adding the Email service is rather simple (see attachment).
Right, but notifications need to be handled somehow.
In which direction? It's easy enough to add each of us to the kernel-source github project.
This would also be an option.
I don't know if github notices that a commit has landed in the repo that matches an outstanding pull request and closes it automatically with the subsequent notification to the submitter.
It does close it. I do not know whether it sends a notification to the author. Jason? Thanks, Michal
On Mon, Aug 22, 2016, at 09:33 AM, Michal Marek wrote:
It does close it. I do not know whether it sends a notification to the author. Jason?
Yes, I did receive an email notification when Michal merged the commit into openSUSE/kernel-source. (And thanks for doing so!) In addition to getting inundated with emails, you probably don't want to add the list address itself to the github notifications as the bottom of the email seems to contain some links with an auth token appended to unsubscribe and such. I'm guessing if any individual on the mailing list did so, they would adjust the notifications for the entire list. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 2016-08-22 15:54, Jason DeRose wrote:
On Mon, Aug 22, 2016, at 09:33 AM, Michal Marek wrote:
It does close it. I do not know whether it sends a notification to the author. Jason?
Yes, I did receive an email notification when Michal merged the commit into openSUSE/kernel-source. (And thanks for doing so!)
Jeff did. But the a script is mirroring from our internal repository to github and uses my credentials. If github has a karma system, I think I'm scoring quite well by now...
In addition to getting inundated with emails, you probably don't want to add the list address itself to the github notifications as the bottom of the email seems to contain some links with an auth token appended to unsubscribe and such. I'm guessing if any individual on the mailing list did so, they would adjust the notifications for the entire list.
That's the personal notifications one gets to their email adress. I hope that the Email Service generates "anonymized" notifications which can be shared. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 8/22/16 10:02 AM, Michal Marek wrote:
On 2016-08-22 15:54, Jason DeRose wrote:
On Mon, Aug 22, 2016, at 09:33 AM, Michal Marek wrote:
It does close it. I do not know whether it sends a notification to the author. Jason?
Yes, I did receive an email notification when Michal merged the commit into openSUSE/kernel-source. (And thanks for doing so!)
Jeff did. But the a script is mirroring from our internal repository to github and uses my credentials. If github has a karma system, I think I'm scoring quite well by now...
Damn, now I want to create a jeffm@suse.com account to get some of those points. :) -Jeff
In addition to getting inundated with emails, you probably don't want to add the list address itself to the github notifications as the bottom of the email seems to contain some links with an auth token appended to unsubscribe and such. I'm guessing if any individual on the mailing list did so, they would adjust the notifications for the entire list.
That's the personal notifications one gets to their email adress. I hope that the Email Service generates "anonymized" notifications which can be shared.
Michal
-- Jeff Mahoney SUSE Labs
participants (3)
-
Jason DeRose -
Jeff Mahoney -
Michal Marek