[opensuse-kernel] [PATCH 0/6] Backport RS485 support for BeagleBoneBlack to Leap 42.2
From: "Matwey V. Kornilov"
From: "Matwey V. Kornilov"
From: "Matwey V. Kornilov"
From: "Matwey V. Kornilov"
From: "Matwey V. Kornilov"
From: "Matwey V. Kornilov"
From: Yegor Yefremov
On Thu, 02 Jun 2016 14:57:51 +0200, matwey@sai.msu.ru wrote:
From: "Matwey V. Kornilov"
Hello,
Please, consider applying this series to openSUSE-42.2 branch. The following patch series is to enable RS485 support for BeagleBone Black (armv7l architecture).
When we moved from deprecated BeagleBone Black serial driver (ttyOx) to new one (ttySx) in master branch, TIOCSRS485 ioctl support in user-space disappeared due to this migration. The support has been brought back in 4.6 using new implementation. The following patches are taken from 4.6 linux kernel release:
Well, I really would like to avoid openSUSE-42.2 specific kernel patches. One of the important point in Leap is the sharing of the code base with SLE. And for 42.2, the kernel code is shared with SLE12-SP2. The difference is only the config. The code is very much same. 42.1 was an individual kernel because of the timing, but 42.2 is a different story. That said, these should go through SLE12-SP2, if they are really mandatory. It's not only about this patchset, but any patches to 42.2 kernel in general. Though, I'm not entirely sure which path would work most effectively. For any bugs, usually Bugzilla would be the best place. Furthermore, it sounds like that it's a kernel regression that dropped the support. If so, they should be merged through stable 4.4.x branch as well. thanks, Takashi
Matwey V. Kornilov (5): tty: Move serial8250_stop_rx() in front of serial8250_start_tx() tty: Add software emulated RS485 support for 8250 tty: 8250_omap: Use software emulated RS485 direction control tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() tty: serial: 8250: Cleanup p->em485 in serial8250_unregister_port
Yegor Yefremov (1): tty/serial/8250: fix RS485 half-duplex RX
drivers/tty/serial/8250/8250.h | 2 + drivers/tty/serial/8250/8250_core.c | 9 ++ drivers/tty/serial/8250/8250_omap.c | 31 +++++ drivers/tty/serial/8250/8250_port.c | 252 ++++++++++++++++++++++++++++++++++-- include/linux/serial_8250.h | 8 ++ 5 files changed, 288 insertions(+), 14 deletions(-)
-- 2.1.4
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, Jun 2, 2016 at 9:30 AM, Takashi Iwai
Furthermore, it sounds like that it's a kernel regression that dropped the support. If so, they should be merged through stable 4.4.x branch as well.
As noted by Richard Brown recently, the 4.4.x LTS kernel is getting a huge amount of changes: === https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.1 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.2 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.3 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.4 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.5 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.6 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.7 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.8 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.9 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.10 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.11 That is over FOURTY THOUSAND lines of changelog entries alone. Not code. _changelog_ === So there does seem to any political reason to not ask to have the fix backported via the official upstream kernel. Greg -- Greg Freemyer www.IntelligentAvatar.net -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 02 Jun 2016 18:19:31 +0200, Greg Freemyer wrote:
On Thu, Jun 2, 2016 at 9:30 AM, Takashi Iwai
wrote: Furthermore, it sounds like that it's a kernel regression that dropped the support. If so, they should be merged through stable 4.4.x branch as well.
As noted by Richard Brown recently, the 4.4.x LTS kernel is getting a huge amount of changes:
=== https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.1 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.2 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.3 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.4 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.5 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.6 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.7 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.8 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.9 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.10 https://www.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.4.11
That is over FOURTY THOUSAND lines of changelog entries alone. Not code. _changelog_ ===
So there does seem to any political reason to not ask to have the fix backported via the official upstream kernel.
It makes little sense to count lines, really. 99% of such cases are just because of lack of Cc to stable in the commit log. Usually the patch author is supposed to put Cc to stable when the patch is for fixing a regression. But people often forget it, and maintainers don't pay extra attention always to that, either. If the patches are confirmed indeed for fixing real bugs, especially regressions at a later stage, and if they are backportable, they can go to stable kernels at any time later, too. You just need to test the patches, and send/inform to stable maintainers which commits to be backported to which kernel. This can be done by anyone, including you :) Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 02 Jun 2016 15:30:42 +0200, Takashi Iwai wrote:
On Thu, 02 Jun 2016 14:57:51 +0200, matwey@sai.msu.ru wrote:
From: "Matwey V. Kornilov"
Hello,
Please, consider applying this series to openSUSE-42.2 branch. The following patch series is to enable RS485 support for BeagleBone Black (armv7l architecture).
When we moved from deprecated BeagleBone Black serial driver (ttyOx) to new one (ttySx) in master branch, TIOCSRS485 ioctl support in user-space disappeared due to this migration. The support has been brought back in 4.6 using new implementation. The following patches are taken from 4.6 linux kernel release:
Well, I really would like to avoid openSUSE-42.2 specific kernel patches. One of the important point in Leap is the sharing of the code base with SLE. And for 42.2, the kernel code is shared with SLE12-SP2. The difference is only the config. The code is very much same.
42.1 was an individual kernel because of the timing, but 42.2 is a different story.
That said, these should go through SLE12-SP2, if they are really mandatory. It's not only about this patchset, but any patches to 42.2 kernel in general.
Though, I'm not entirely sure which path would work most effectively. For any bugs, usually Bugzilla would be the best place.
Matwey, could you open a Bugzilla entry for tracking the bug and your patches? Then we can evaluate there and merge to SLE12-SP2 and openSUSE-42.2 branch. Also we can try to push to stable 4.4.x tree if appropriate. thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
2016-06-03 16:46 GMT+03:00 Takashi Iwai
On Thu, 02 Jun 2016 15:30:42 +0200, Takashi Iwai wrote:
On Thu, 02 Jun 2016 14:57:51 +0200, matwey@sai.msu.ru wrote:
From: "Matwey V. Kornilov"
Hello,
Please, consider applying this series to openSUSE-42.2 branch. The following patch series is to enable RS485 support for BeagleBone Black (armv7l architecture).
When we moved from deprecated BeagleBone Black serial driver (ttyOx) to new one (ttySx) in master branch, TIOCSRS485 ioctl support in user-space disappeared due to this migration. The support has been brought back in 4.6 using new implementation. The following patches are taken from 4.6 linux kernel release:
Well, I really would like to avoid openSUSE-42.2 specific kernel patches. One of the important point in Leap is the sharing of the code base with SLE. And for 42.2, the kernel code is shared with SLE12-SP2. The difference is only the config. The code is very much same.
42.1 was an individual kernel because of the timing, but 42.2 is a different story.
That said, these should go through SLE12-SP2, if they are really mandatory. It's not only about this patchset, but any patches to 42.2 kernel in general.
Though, I'm not entirely sure which path would work most effectively. For any bugs, usually Bugzilla would be the best place.
Matwey, could you open a Bugzilla entry for tracking the bug and your patches? Then we can evaluate there and merge to SLE12-SP2 and openSUSE-42.2 branch. Also we can try to push to stable 4.4.x tree if appropriate.
Hello, Sorry for the delay with answer. I'll create the bugreport. Should I attach the patches as files or may just put link here? I think that this series does not fulfill kernel stable rules. From the formal point of view, it adds new feature. Issue in openSUSE that we have two mutual kernel modules for the same hardware (the modules can not been compiled or run together) and each module implements its own set of features, so I am trying to add the most required missed feature. I've started this series development in Nov 2015 based on 4.3, so this definitely worked on 4.3, not only on 4.6. -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia 119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Fri, 03 Jun 2016 18:28:50 +0200, Matwey V. Kornilov wrote:
2016-06-03 16:46 GMT+03:00 Takashi Iwai
: On Thu, 02 Jun 2016 15:30:42 +0200, Takashi Iwai wrote:
On Thu, 02 Jun 2016 14:57:51 +0200, matwey@sai.msu.ru wrote:
From: "Matwey V. Kornilov"
Hello,
Please, consider applying this series to openSUSE-42.2 branch. The following patch series is to enable RS485 support for BeagleBone Black (armv7l architecture).
When we moved from deprecated BeagleBone Black serial driver (ttyOx) to new one (ttySx) in master branch, TIOCSRS485 ioctl support in user-space disappeared due to this migration. The support has been brought back in 4.6 using new implementation. The following patches are taken from 4.6 linux kernel release:
Well, I really would like to avoid openSUSE-42.2 specific kernel patches. One of the important point in Leap is the sharing of the code base with SLE. And for 42.2, the kernel code is shared with SLE12-SP2. The difference is only the config. The code is very much same.
42.1 was an individual kernel because of the timing, but 42.2 is a different story.
That said, these should go through SLE12-SP2, if they are really mandatory. It's not only about this patchset, but any patches to 42.2 kernel in general.
Though, I'm not entirely sure which path would work most effectively. For any bugs, usually Bugzilla would be the best place.
Matwey, could you open a Bugzilla entry for tracking the bug and your patches? Then we can evaluate there and merge to SLE12-SP2 and openSUSE-42.2 branch. Also we can try to push to stable 4.4.x tree if appropriate.
Hello,
Sorry for the delay with answer. I'll create the bugreport. Should I attach the patches as files or may just put link here?
At best, attach files.
I think that this series does not fulfill kernel stable rules. From the formal point of view, it adds new feature. Issue in openSUSE that we have two mutual kernel modules for the same hardware (the modules can not been compiled or run together) and each module implements its own set of features, so I am trying to add the most required missed feature. I've started this series development in Nov 2015 based on 4.3, so this definitely worked on 4.3, not only on 4.6.
Hrm, but if something worked and it doesn't work in the later version, it's called a regression. And we should fix the regression. If these patches do actually fix the regression, it's still worth to put as stable kernels. In anyway, let's continue discussion on bugzilla. thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Fri, 03 Jun 2016 18:28:50 +0200, Matwey V. Kornilov wrote:
2016-06-03 16:46 GMT+03:00 Takashi Iwai
: On Thu, 02 Jun 2016 15:30:42 +0200, Takashi Iwai wrote:
On Thu, 02 Jun 2016 14:57:51 +0200, matwey@sai.msu.ru wrote:
From: "Matwey V. Kornilov"
Hello,
Please, consider applying this series to openSUSE-42.2 branch. The following patch series is to enable RS485 support for BeagleBone Black (armv7l architecture).
When we moved from deprecated BeagleBone Black serial driver (ttyOx) to new one (ttySx) in master branch, TIOCSRS485 ioctl support in user-space disappeared due to this migration. The support has been brought back in 4.6 using new implementation. The following patches are taken from 4.6 linux kernel release:
Well, I really would like to avoid openSUSE-42.2 specific kernel patches. One of the important point in Leap is the sharing of the code base with SLE. And for 42.2, the kernel code is shared with SLE12-SP2. The difference is only the config. The code is very much same.
42.1 was an individual kernel because of the timing, but 42.2 is a different story.
That said, these should go through SLE12-SP2, if they are really mandatory. It's not only about this patchset, but any patches to 42.2 kernel in general.
Though, I'm not entirely sure which path would work most effectively. For any bugs, usually Bugzilla would be the best place.
Matwey, could you open a Bugzilla entry for tracking the bug and your patches? Then we can evaluate there and merge to SLE12-SP2 and openSUSE-42.2 branch. Also we can try to push to stable 4.4.x tree if appropriate.
Hello,
Sorry for the delay with answer. I'll create the bugreport. Should I attach the patches as files or may just put link here? I think that this series does not fulfill kernel stable rules. From the formal point of view, it adds new feature.
Right. But if the patches serve to filling the gap for user-space with the previously working setup, it can be seen as a "fix", too. At least, it's worth to give it a try. The patches aren't intrusive and small enough, so I guess you have some good chance to get them merged to stable tree. Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (4)
-
Greg Freemyer
-
Matwey V. Kornilov
-
matwey@sai.msu.ru
-
Takashi Iwai