[opensuse-kernel] [RFC/PATCH] eliminate trace flavor
![](https://seccdn.libravatar.org/avatar/bcd65ca98f9d97839f15c54575c7edec.jpg?s=120&d=mm&r=g)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all - Over the past several years, the tracing infrastructure has improved to the point that it incurs very little runtime overhead. The attached patchset migrates the useful options from the -trace configs to all of the other configs and ultimately removes the trace flavor entirely. This saves space for the kernel RPMs as well as conserves build resources. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJTRti5AAoJEB57S2MheeWyt9cP/RHfAI2x42edTaBRW9XjAp3A xwhfai/7NwKUpU4ptdC03cOudxBUQVC7v1G1JEMREU1BmCb3KStMPXiFgQGWjLnR 8H7cFXfDhqxn06AHml/7lh3K2vSsCe+/qxw+6WOsDQjCE1PhMV13Q40Sq3L/+iE6 ZtuWP17qV0d/pF4UFrgcP3wEYDUiwU7Nb67H0ZU1Pv3ybvLM60dUQvkrsEVhND1s bvJUAeZTk9yByrmBnrwz/XLA8+gq5DtRZDqqIZgvegvb6KXAS0Zmi/+W5tmgijMJ KO3y/omw/t7WPwHmxbCXaPYY1AIPniWv3jt1WmR76rcRk6zz9hl1O5HvceO5k0+v 6DK6YEpYVhNExR5qBJD+tGOLC8BVDXcFCNrNa86Vc0PQ9NhWzCB+J4PXSvQYPAbB zGuJcZjaJPWj+BU3q8vVi0ndRn5SM9K2seRlq4Qgrz8Hg/b0ndDO0muid3BN3jlx C9SNHsyLuUSREvlN/d30/vZdomQ/dYDs/w+trob8ngVqiJqnP1HUYwdrwc+XEWcA AlyAHwzYMTuSCaMqr/33Hz3mp5k/DHBYVpR6R3cSajiUVd+yBNgoB03tawh15D5Y 6PBlYeRXha0UwSLM85gqez5GSkOtYD+oZH8qspFVqdc2YkJNlFq0bd/sZjaECq/B F2jKTSiQ4hXe8MOPBbQP =mE5y -----END PGP SIGNATURE-----
![](https://seccdn.libravatar.org/avatar/aebdf31d465b04113cd13a6bffde8527.jpg?s=120&d=mm&r=g)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/10/2014 07:45 PM, Jeff Mahoney wrote:
Hi all -
Over the past several years, the tracing infrastructure has improved to the point that it incurs very little runtime overhead. The attached patchset migrates the useful options from the -trace configs to all of the other configs and ultimately removes the trace flavor entirely. This saves space for the kernel RPMs as well as conserves build resources.
Hi, on the other hand, I just wanted to point out, that DYN_FTRACE generates 22 bytes of nops on s390 (in comparison to 5 bytes on x86_64) in every function which actually can impact performance. But we don't care about s390 in openSUSE much, right? (We are to measure this on SLE yet.) thanks, - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIbBAEBAgAGBQJTS9oAAAoJEL0lsQQGtHBJY68P+KfYZgh3NN9Eir+PCUGaFbMH /7kczrWxSvTHrsemSvyaetlLZp0thy82Ws8ZLdoyQORttAQlUYavq102HNFAuYBr 95UtwPKHbtYKXxX5WYLlGzsmeIlce4rYbdqLIe17049rnWJnPynUUYPZ9KBX39R2 XwGkBz9p2ltp+YAT/8KhcPlB7mP1XNG+o8PV+FI+2ZUejFL7LC4aVNJx489evXSq n3RYGnpYHwejO9/vl+CoqL6f12tnxr4yo7KvMvaKJpeOxVXu9syx6GtMr5zSsn1g HeJav5Fb8uZmgn9YK+b+Z5gF9MGfwk0GW7ZM1JLgjatoJXMIaMv1LxSiDwFcsTC5 YO4/ecrwguSMC6U9vVXHv16RWkyEbsRzdxenlY6NzB8B5TSC7jqGbwnU+uDDahPG QHDJY1PFPsuQu9BJSky1MD7b96BxDJZKfI5WTUYX/XTrwwVdQVXrKUN66a+MRLN8 vNG2iliJgAsUOR+8f2jH96olAs2mD7QJ5vQJhlZkb0+yLigAJCeUQI/H6p/aFB2o JGrX49NoCxAoB7DY8IJIlGkxddmhwFHSKFr/ow26TXkmdJ+yHVJy22mSAMp+9ftE qG4azJ1vOPzP3wFfa900LHAgXuloNE8o28J9BLaCDXfTQpBbvG3VpaX0Zw3JpyL0 jhcCSMQBWMwwdkR7/Ok= =xvzW -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/b6a77479a0d29007bf9252b8b59fb010.jpg?s=120&d=mm&r=g)
On Mon, 14 Apr 2014 14:52:16 +0200 Jiri Slaby <jslaby@suse.cz> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/10/2014 07:45 PM, Jeff Mahoney wrote:
Hi all -
Over the past several years, the tracing infrastructure has improved to the point that it incurs very little runtime overhead. The attached patchset migrates the useful options from the -trace configs to all of the other configs and ultimately removes the trace flavor entirely. This saves space for the kernel RPMs as well as conserves build resources.
Hi,
on the other hand, I just wanted to point out, that DYN_FTRACE generates 22 bytes of nops on s390 (in comparison to 5 bytes on x86_64) in every function which actually can impact performance. But we don't care about s390 in openSUSE much, right? (We are to measure this on SLE yet.)
Is there an s390(x) port of openSUSE? I mean, the OBS build farm certainly does not include any z/Series hosts... Since the internal Factory builds are not public (AFAIK), someone else would have to re-compile the openSUSE sources. I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all. Petr T
![](https://seccdn.libravatar.org/avatar/aebdf31d465b04113cd13a6bffde8527.jpg?s=120&d=mm&r=g)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/14/2014 02:59 PM, Petr Tesarik wrote:
Is there an s390(x) port of openSUSE? I mean, the OBS build farm certainly does not include any z/Series hosts... Since the internal Factory builds are not public (AFAIK), someone else would have to re-compile the openSUSE sources.
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
It well might be the case. But what is the reason to have s390 configs in the master branch? - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTS9wAAAoJEL0lsQQGtHBJdMYP/1YSq04NllpNQZ+M22VuUG2g g1TXVP5mlE9XDJQ5/EU2HmmkiL3skmTdwtn1VQnxHnFXGXnnvavlM5jUb3iw8RBz 9Nkihi/hpwUzJTpqpicLX6C1kuHel8pRxRh6zZ9AcKQKxjuq9az1X8aaZbsinjsP Ct+AHrIBkt2+BBuFCrE3cJBRUZuwMDpJOS3nivgFQf7RsTCPghNZk/H839wHflMt O1BdG6RCe1cj8lfmAEfqNMh99B5PVoFNhj8IGlPzzHpB/Lh/1z0HX+GkkgwgenIW sjcommlgrWjkr5URieI3p3xq6FcbZ+J/bORNYaTu2nxICO+58JLC0eefdLp+A3At M9HQ41XB0eJPwWwKiSuCnM3/fLfyrNxtsk8dVhywn0qZOFg++y3qT9I64Kbcp2fR j/IJX78nm4L9E0ujyo2hSqpyKRD1N/orZAwVBDQFB5yMPdKkbM2lkbvw/nYG+pu/ cbQ0/NgRddo2Q9JuvznOwHwNzwylRlCjeQEFhhTkmnebyWiV3hGjYK2MTAufxVU7 a/DFWeOFs5LjpeoBUy8MFpXqyRLanncQd7Bf5YRnXzACvuIApEFf9EcAn2lKJLWJ LlrE8ygWvE5GmJ351Jq45WVraAqJNUPJKqBXxJYQ9XO/xLaOU2XYbQ3yi2VxEpqs KLUgl6/tvbWOY7Hp1fUo =F/Jv -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/fff0f38e92656c8a636916213eb952c4.jpg?s=120&d=mm&r=g)
Hi, On Mon, 14 Apr 2014, Jiri Slaby wrote:
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
It well might be the case. But what is the reason to have s390 configs in the master branch?
To have it build internally in Factory:Head so that s390x lurkers in the company can take a look? Ciao, Michael. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/aebdf31d465b04113cd13a6bffde8527.jpg?s=120&d=mm&r=g)
On 04/14/2014 03:05 PM, Michael Matz wrote:
Hi,
On Mon, 14 Apr 2014, Jiri Slaby wrote:
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
It well might be the case. But what is the reason to have s390 configs in the master branch?
To have it build internally in Factory:Head so that s390x lurkers in the company can take a look?
But who and what's the reason? Does it boot at all? And if not, who cares? IOW what's the use case? -- js suse labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/fff0f38e92656c8a636916213eb952c4.jpg?s=120&d=mm&r=g)
Hi, On Mon, 14 Apr 2014, Jiri Slaby wrote:
It well might be the case. But what is the reason to have s390 configs in the master branch?
To have it build internally in Factory:Head so that s390x lurkers in the company can take a look?
But who and what's the reason? Does it boot at all? And if not, who cares? IOW what's the use case?
I don't know. Ask the s390 and the autobuild guys if they actively do something with Factory:Head for s390x. But in any case, in the future it will be necessary to have a built kernel to build anything at all for an architecture (as it will be used in the build VM, so that would be one use case), and we certainly do not want to disable s390x for Factory:Head internally altogether. Ciao, Michael. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/fff0f38e92656c8a636916213eb952c4.jpg?s=120&d=mm&r=g)
Hi, On Mon, 14 Apr 2014, Michael Matz wrote:
But who and what's the reason? Does it boot at all? And if not, who cares? IOW what's the use case?
I don't know. Ask the s390 and the autobuild guys if they actively do something with Factory:Head for s390x. But in any case, in the future it will be necessary to have a built kernel to build anything at all for
Minor correction: it's necessary already right now, I forgot that factory is exclusively built with kvm since some time already. Ciao, Michael. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/5b19e9d0e834ea10ef75803718ad564b.jpg?s=120&d=mm&r=g)
At Mon, 14 Apr 2014 15:24:03 +0200, Jiri Slaby wrote:
On 04/14/2014 03:05 PM, Michael Matz wrote:
Hi,
On Mon, 14 Apr 2014, Jiri Slaby wrote:
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
It well might be the case. But what is the reason to have s390 configs in the master branch?
To have it build internally in Factory:Head so that s390x lurkers in the company can take a look?
But who and what's the reason? Does it boot at all? And if not, who cares? IOW what's the use case?
We've been checking the build errors, at least, no? Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/b6a77479a0d29007bf9252b8b59fb010.jpg?s=120&d=mm&r=g)
V Mon, 14 Apr 2014 15:34:48 +0200 Takashi Iwai <tiwai@suse.de> napsáno:
At Mon, 14 Apr 2014 15:24:03 +0200, Jiri Slaby wrote:
On 04/14/2014 03:05 PM, Michael Matz wrote:
Hi,
On Mon, 14 Apr 2014, Jiri Slaby wrote:
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
It well might be the case. But what is the reason to have s390 configs in the master branch?
To have it build internally in Factory:Head so that s390x lurkers in the company can take a look?
But who and what's the reason? Does it boot at all? And if not, who cares? IOW what's the use case?
We've been checking the build errors, at least, no?
OK, so then _we_ are the openSUSE z/Series community, and the decision is fully in our hands, I guess. ;-) Petr T -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
![](https://seccdn.libravatar.org/avatar/dcaea5e8a6fad867936a40a9c21e8ff3.jpg?s=120&d=mm&r=g)
Le Monday 14 April 2014 à 14:59 +0200, Petr Tesarik a écrit :
On Mon, 14 Apr 2014 14:52:16 +0200 Jiri Slaby <jslaby@suse.cz> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/10/2014 07:45 PM, Jeff Mahoney wrote:
Hi all -
Over the past several years, the tracing infrastructure has improved to the point that it incurs very little runtime overhead. The attached patchset migrates the useful options from the -trace configs to all of the other configs and ultimately removes the trace flavor entirely. This saves space for the kernel RPMs as well as conserves build resources.
Hi,
on the other hand, I just wanted to point out, that DYN_FTRACE generates 22 bytes of nops on s390 (in comparison to 5 bytes on x86_64) in every function which actually can impact performance. But we don't care about s390 in openSUSE much, right? (We are to measure this on SLE yet.)
That shouldn't prevent us from removing the trace flavor on other architectures. I'm all for it - fewer flavors has many benefits.
Is there an s390(x) port of openSUSE? I mean, the OBS build farm certainly does not include any z/Series hosts... Since the internal Factory builds are not public (AFAIK), someone else would have to re-compile the openSUSE sources.
I'm not aware of anyone actually doing that. If that's the case, then the openSUSE community does not care about mainframe at all.
Correct. To be honest I don't quite understand why we keep such configuration files in the master kernel branch to start with. They are pointless for openSUSE, and when we start a new SLE product, there's still a lot of work left because these files are half-maintained and all the changes done in the previous SLE's service packs has to take precedence. Having a single ancestor would make things less error-prone IMHO. Even for architectures which are shared between openSUSE and SLE, the kernel configuration files start diverging by quite a bit, as the target hardware set and use cases aren't the same. So maybe it would be time to admit that the openSUSE kernel flavors and SLE kernel flavors are separate entities and should be handled separately. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (6)
-
Jean Delvare
-
Jeff Mahoney
-
Jiri Slaby
-
Michael Matz
-
Petr Tesarik
-
Takashi Iwai