[opensuse-kernel] notify_change
Hi. When I try to compile: error = notify_change(dentry, &attr); under openSUSE kernel, it aborts with: error: too few arguments to function ‘notify_change' (it compiles fine with vanilla or ubuntu kernels). Can you help me to get this line succesfully compiled in openSUSE kernel too? Thanks. Miquel. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Friday 07 September 2007 10:25, Miquel A. Noguera wrote:
Hi.
When I try to compile:
error = notify_change(dentry, &attr);
under openSUSE kernel, it aborts with:
error: too few arguments to function ‘notify_change'
Well, that's because of the AppArmor patches; AppArmor requires an additional struct vfsmnt parameter.
(it compiles fine with vanilla or ubuntu kernels).
Can you help me to get this line succesfully compiled in openSUSE kernel too?
I'm afraid that just getting the line to compile may not be enough. The appropriate fix depends on what your code is trying to do. I suggest that you check for similar uses of notify_change to get an idea what may be appropriate, and then maybe ask again including more information such as pointers to the code, a proposed patch, etc. Andreas -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Sep 7 2007 10:40, Andreas Gruenbacher wrote:
On Friday 07 September 2007 10:25, Miquel A. Noguera wrote:
Hi.
When I try to compile:
error = notify_change(dentry, &attr);
under openSUSE kernel, it aborts with:
error: too few arguments to function ‘notify_change'
Well, that's because of the AppArmor patches; AppArmor requires an additional struct vfsmnt parameter.
Have a look at http://freshmeat.net/p/multiadm/ how I worked around this. (Though I am not sure apparmor likes taking a NULL vfsmnt arg........if not, it really SHOULD.) Jan -- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Friday 07 September 2007 14:12, Jan Engelhardt wrote:
On Sep 7 2007 10:40, Andreas Gruenbacher wrote:
On Friday 07 September 2007 10:25, Miquel A. Noguera wrote:
Hi.
When I try to compile:
error = notify_change(dentry, &attr);
under openSUSE kernel, it aborts with:
error: too few arguments to function ‘notify_change'
Well, that's because of the AppArmor patches; AppArmor requires an additional struct vfsmnt parameter.
Have a look at http://freshmeat.net/p/multiadm/ how I worked around this. (Though I am not sure apparmor likes taking a NULL vfsmnt arg........if not, it really SHOULD.)
AppArmor cannot compute the pathnames of files without a proper vfsmnt parameter, so passing NULL effectively disables AppArmor for this specific notify_change() call. Without knowing which file is changed, what triggers the change, and why, it is somewhat hard to tell whether passing NULL is okay. Andreas -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Sep 7 2007 14:28, Andreas Gruenbacher wrote:
Well, that's because of the AppArmor patches; AppArmor requires an additional struct vfsmnt parameter.
Have a look at http://freshmeat.net/p/multiadm/ how I worked around this. (Though I am not sure apparmor likes taking a NULL vfsmnt arg........if not, it really SHOULD.)
AppArmor cannot compute the pathnames of files without a proper vfsmnt parameter, so passing NULL effectively disables AppArmor for this specific notify_change() call. Without knowing which file is changed, what triggers the change, and why, it is somewhat hard to tell whether passing NULL is okay.
I mean: at least it should not oops when passed NULL. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
participants (3)
-
Andreas Gruenbacher -
Jan Engelhardt -
Miquel A. Noguera