[opensuse-kernel] [PATCH] config arm: disable CONFIG_LEDS_BCM6328, CONFIG_LEDS_BCM6358
Broadcom 63xx is MIPS only, unfortunately KConfig does not know Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- config/armv6hl/default | 4 ++-- config/armv6hl/vanilla | 4 ++-- config/armv7hl/default | 4 ++-- config/armv7hl/lpae | 4 ++-- config/armv7hl/vanilla | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/config/armv6hl/default b/config/armv6hl/default index b59c1c1..57d9209 100644 --- a/config/armv6hl/default +++ b/config/armv6hl/default @@ -4639,8 +4639,8 @@ CONFIG_LEDS_CLASS=y # LED drivers # CONFIG_LEDS_88PM860X=m -CONFIG_LEDS_BCM6328=m -CONFIG_LEDS_BCM6358=m +# CONFIG_LEDS_BCM6328 is not set +# CONFIG_LEDS_BCM6358 is not set CONFIG_LEDS_LM3530=m CONFIG_LEDS_LM3642=m CONFIG_LEDS_PCA9532=m diff --git a/config/armv6hl/vanilla b/config/armv6hl/vanilla index e81a5cc..0f84345 100644 --- a/config/armv6hl/vanilla +++ b/config/armv6hl/vanilla @@ -4634,8 +4634,8 @@ CONFIG_LEDS_CLASS=y # LED drivers # CONFIG_LEDS_88PM860X=m -CONFIG_LEDS_BCM6328=m -CONFIG_LEDS_BCM6358=m +# CONFIG_LEDS_BCM6328 is not set +# CONFIG_LEDS_BCM6358 is not set CONFIG_LEDS_LM3530=m CONFIG_LEDS_LM3642=m CONFIG_LEDS_PCA9532=m diff --git a/config/armv7hl/default b/config/armv7hl/default index 698e4e0..b3edcf4 100644 --- a/config/armv7hl/default +++ b/config/armv7hl/default @@ -6340,8 +6340,8 @@ CONFIG_LEDS_CLASS_FLASH=m # CONFIG_LEDS_88PM860X=m CONFIG_LEDS_AAT1290=m -CONFIG_LEDS_BCM6328=m -CONFIG_LEDS_BCM6358=m +# CONFIG_LEDS_BCM6328 is not set +# CONFIG_LEDS_BCM6358 is not set CONFIG_LEDS_LM3530=m CONFIG_LEDS_LM3533=m CONFIG_LEDS_LM3642=m diff --git a/config/armv7hl/lpae b/config/armv7hl/lpae index f584780..812e2cf 100644 --- a/config/armv7hl/lpae +++ b/config/armv7hl/lpae @@ -6023,8 +6023,8 @@ CONFIG_LEDS_CLASS_FLASH=m # CONFIG_LEDS_88PM860X=m CONFIG_LEDS_AAT1290=m -CONFIG_LEDS_BCM6328=m -CONFIG_LEDS_BCM6358=m +# CONFIG_LEDS_BCM6328 is not set +# CONFIG_LEDS_BCM6358 is not set CONFIG_LEDS_LM3530=m CONFIG_LEDS_LM3533=m CONFIG_LEDS_LM3642=m diff --git a/config/armv7hl/vanilla b/config/armv7hl/vanilla index 7549df4..3e26251 100644 --- a/config/armv7hl/vanilla +++ b/config/armv7hl/vanilla @@ -6334,8 +6334,8 @@ CONFIG_LEDS_CLASS_FLASH=m # CONFIG_LEDS_88PM860X=m CONFIG_LEDS_AAT1290=m -CONFIG_LEDS_BCM6328=m -CONFIG_LEDS_BCM6358=m +# CONFIG_LEDS_BCM6328 is not set +# CONFIG_LEDS_BCM6358 is not set CONFIG_LEDS_LM3530=m CONFIG_LEDS_LM3533=m CONFIG_LEDS_LM3642=m -- 2.1.4 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi, Am 24.10.2015 um 21:00 schrieb Stefan Brüns:
Broadcom 63xx is MIPS only, unfortunately KConfig does not know
Someone on opensuse-arm list disputed that, saying these drivers are specifically both for MIPS and ARM (just like there's some drivers with SH or PPC in the name historically that are valid and used for ARM). Note that for example Exynos4 drivers are reused for Exynos5, so we need to consider transitive relations as well, not just 63xx. So, what do you base the above on? Did you verify that no OF compatible string from those drivers is used in arch/arm/boot/dts/*? If you did, please propose a paragraph to add to the commit message as explanation.
Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- config/armv6hl/default | 4 ++-- config/armv6hl/vanilla | 4 ++--
I assume this part is good, as most users will run a Raspberry Pi with bcm2835.
config/armv7hl/default | 4 ++-- config/armv7hl/lpae | 4 ++-- config/armv7hl/vanilla | 4 ++--
For these I'm less certain. There's a bcm63138.dtsi file, for instance, which is referenced from bcm963*.dts. Haven't found time to investigate how all these families are connected.
5 files changed, 10 insertions(+), 10 deletions(-)
Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wednesday 28 October 2015 01:08:21 you wrote:
Hi,
Am 24.10.2015 um 21:00 schrieb Stefan Brüns:
Broadcom 63xx is MIPS only, unfortunately KConfig does not know
Someone on opensuse-arm list disputed that, saying these drivers are specifically both for MIPS and ARM (just like there's some drivers with SH or PPC in the name historically that are valid and used for ARM). Note that for example Exynos4 drivers are reused for Exynos5, so we need to consider transitive relations as well, not just 63xx.
So, what do you base the above on? Did you verify that no OF compatible string from those drivers is used in arch/arm/boot/dts/*? If you did, please propose a paragraph to add to the commit message as explanation.
Rechecked the DTS, currently the drivers are only used by some MIPS SoCs. There is a slight chance someone finds the ARM BCM63138 has compatible hardware to either BCM6328 or BCM6358, so it is added later to the DTS. On the other hand, BCM6328 and BCM6358 are same generation/age MIPS devices and are not compatible, so I would expect a new driver for the BCM63138. In case the change is accepted, I will create a new patch against HEAD, with a clarified commit message. Kind regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Andreas Färber
-
Stefan Bruens
-
Stefan Brüns