[opensuse-kernel] [PATCH] ARM: disable Xen for now since it is currently broken
Hi, please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config. Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Ping. Guillaume Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi, please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails). * Changes in V3: - rebased on latest master (3.14-rc7) * Changes in V2: - Add missing exynos config update * V1: - Disable Xen on ARM configs since it is broken and compilation fails. Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume Le 17/03/2014 14:25, Guillaume Gardet a écrit :
Ping.
Guillaume
Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Ping again... Guillaume Le 21/03/2014 16:56, Guillaume Gardet a écrit :
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails).
* Changes in V3: - rebased on latest master (3.14-rc7) * Changes in V2: - Add missing exynos config update * V1: - Disable Xen on ARM configs since it is broken and compilation fails.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 17/03/2014 14:25, Guillaume Gardet a écrit :
Ping.
Guillaume
Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails).
Is it broken upstream or is it broken due to our xen patches? In case of the former, do the Xen folks know? If it's the latter, could we just not apply the xen patches for the arm build? Alex
* Changes in V3: - rebased on latest master (3.14-rc7) * Changes in V2: - Add missing exynos config update * V1: - Disable Xen on ARM configs since it is broken and compilation fails.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 17/03/2014 14:25, Guillaume Gardet a écrit :
Ping.
Guillaume
Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
<0001-Disable-Xen-on-ARM-configs-for-now-since-Xen-is-curr.patch>
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi, Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails). Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
In case of the former, do the Xen folks know?
If it's the latter, could we just not apply the xen patches for the arm build?
Not sure if it is possible, since xen patches are not arch specific. In case it is possible, is it a good idea to have Xen patches applied for some architectures and not for other? I think our SUSE/openSUSE Xen guys should have a look at it and fix the problem. But I am not sure how concerned they are about ARM. :( The fact is that armv7 and aarch64 kernels are broken since too long in Factory and should build again ASAP if we want people to use/debug factory for ARM. Guillaume
Alex
* Changes in V3: - rebased on latest master (3.14-rc7) * Changes in V2: - Add missing exynos config update * V1: - Disable Xen on ARM configs since it is broken and compilation fails.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 17/03/2014 14:25, Guillaume Gardet a écrit :
Ping.
Guillaume
Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume <0001-Disable-Xen-on-ARM-configs-for-now-since-Xen-is-curr.patch>
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Fri, 28 Mar 2014, Guillaume Gardet wrote:
Hi,
Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails). Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
In case of the former, do the Xen folks know?
If it's the latter, could we just not apply the xen patches for the arm build?
Not sure if it is possible, since xen patches are not arch specific. In case it is possible, is it a good idea to have Xen patches applied for some architectures and not for other?
I think our SUSE/openSUSE Xen guys should have a look at it and fix the problem. But I am not sure how concerned they are about ARM. :(
I am pretty sure that the patches in question are only needed on x86. Jan, are you able to confirm it? I am certainly not an expert on spec files, but it seems to me it should be possible to only apply those patches to the x86 build?
The fact is that armv7 and aarch64 kernels are broken since too long in Factory and should build again ASAP if we want people to use/debug factory for ARM.
Guillaume
Alex
* Changes in V3: - rebased on latest master (3.14-rc7) * Changes in V2: - Add missing exynos config update * V1: - Disable Xen on ARM configs since it is broken and compilation fails.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 17/03/2014 14:25, Guillaume Gardet a écrit :
Ping.
Guillaume
Le 13/03/2014 12:10, Guillaume Gardet a écrit :
Sorry, I forgot to include exynos config in previous patch. In attachment, a new patch including exynos config.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
Le 13/03/2014 11:57, Guillaume Gardet a écrit :
Hi,
please find in attachment a patch to disable Xen on ARM since it is currently broken. See my previous e-mail for details: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume <0001-Disable-Xen-on-ARM-configs-for-now-since-Xen-is-curr.patch>
On 28.03.14 at 12:24, <stefano.stabellini@eu.citrix.com> wrote: On Fri, 28 Mar 2014, Guillaume Gardet wrote: Hi,
Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen
on ARM since it is currently broken (compilation fails).
Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
In case of the former, do the Xen folks know?
If it's the latter, could we just not apply the xen patches for the arm
build?
Not sure if it is possible, since xen patches are not arch specific. In case it is possible, is it a good idea to have Xen patches applied for some architectures and not for other?
I think our SUSE/openSUSE Xen guys should have a look at it and fix the problem. But I am not sure how concerned they are about ARM. :(
I am pretty sure that the patches in question are only needed on x86. Jan, are you able to confirm it?
I am certainly not an expert on spec files, but it seems to me it should be possible to only apply those patches to the x86 build?
Possible yes, but not necessarily desirable. And it worked without disabling them before, so the preference should be to make it work again this way. Jan -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 28.03.14 at 11:54, <guillaume.gardet@free.fr> wrote: Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails). Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Now see - in that mail you point to an upstream patch as the presumed cause, plus XEN_HAVE_PV_GUEST_ENTRY is _intended_ to be undefined for ARM, which made me ignore it. Would it have been made clear that it's in our patches (with a more explicit description as to what the problem really is), I would have gone and tried to fix this there. Looking at this in closer detail it's not even clear how to fix this though, since without a struct start_info instance there's nowhere to check for SIF_INITDOMAIN. Will need to consult xen-devel first... And disabling a feature rather than fixing the build is almost always wrong imo anyway, so the request overall looked bogus to me in the first place. Jan -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Fri, 28 Mar 2014, Jan Beulich wrote:
On 28.03.14 at 11:54, <guillaume.gardet@free.fr> wrote: Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen on ARM since it is currently broken (compilation fails). Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Now see - in that mail you point to an upstream patch as the presumed cause, plus XEN_HAVE_PV_GUEST_ENTRY is _intended_ to be undefined for ARM, which made me ignore it. Would it have been made clear that it's in our patches (with a more explicit description as to what the problem really is), I would have gone and tried to fix this there.
Looking at this in closer detail it's not even clear how to fix this though, since without a struct start_info instance there's nowhere to check for SIF_INITDOMAIN. Will need to consult xen-devel first...
ARM doesn't have a start_info. Linux manually populates a dummy start_info struct in arch/arm/xen/enlighten.c:xen_guest_init. SIF_INITDOMAIN and SIF_PRIVILEGED are set if xen_feature(XENFEAT_dom0).
On 28.03.14 at 12:29, <stefano.stabellini@eu.citrix.com> wrote: On Fri, 28 Mar 2014, Jan Beulich wrote:
On 28.03.14 at 11:54, <guillaume.gardet@free.fr> wrote: Le 28/03/2014 11:41, Alexander Graf a écrit :
Am 21.03.2014 um 23:56 schrieb Guillaume Gardet <guillaume.gardet@free.fr>:
Hi,
please find in attachment an update for the pending patch which disable Xen
on ARM since it is currently broken (compilation fails).
Is it broken upstream or is it broken due to our xen patches?
openSUSE Xen patches brake it, as mentionned here: http://lists.opensuse.org/opensuse-kernel/2014-03/msg00023.html
Now see - in that mail you point to an upstream patch as the presumed cause, plus XEN_HAVE_PV_GUEST_ENTRY is _intended_ to be undefined for ARM, which made me ignore it. Would it have been made clear that it's in our patches (with a more explicit description as to what the problem really is), I would have gone and tried to fix this there.
Looking at this in closer detail it's not even clear how to fix this though, since without a struct start_info instance there's nowhere to check for SIF_INITDOMAIN. Will need to consult xen-devel first...
ARM doesn't have a start_info. Linux manually populates a dummy start_info struct in arch/arm/xen/enlighten.c:xen_guest_init. SIF_INITDOMAIN and SIF_PRIVILEGED are set if xen_feature(XENFEAT_dom0).
But you realize that more than just that code (namely your fake start_info instance) wouldn't build anymore with the definition of struct start_info not visible. Anyway, until upstream is going to sync their headers and get this fixed, I'll have to re-expose the structure to ARM. I wish the hiding would have been done _after_ having switched upstream Linux away from using it... Jan -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (4)
-
Alexander Graf -
Guillaume Gardet -
Jan Beulich -
Stefano Stabellini