[opensuse-kernel] [PATCH] atl1c: Fix misuse of netdev_alloc_skb in refilling rx ring
From: Eric Dumazet
On Mon, 2013-07-29 at 13:09 +0100, Luis Henriques wrote:
I confirm that I can't reproduce the issue using this patch.
Thanks, I'll send a polished patch, as this one had an error if build_skb() returns NULL (in case sk_buff allocation fails)
Please try the following patch : It should use 2K frags instead of 4K
for normal 1500 mtu
Thanks !
[PATCH] atl1c: use custom skb allocator
We had reports ( https://bugzilla.kernel.org/show_bug.cgi?id=54021 )
that using high order pages for skb allocations is problematic for atl1c
We do not know exactly what the problem is, but we suspect that crossing
4K pages is not well supported by this hardware.
Use a custom allocator, using page allocator and 2K fragments for
optimal stack behavior. We might make this allocator generic
in future kernels.
Signed-off-by: Eric Dumazet
On 2013/07/31 12:11, David Chang wrote:
From: Eric Dumazet
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git Git-commit: 7b70176421993866e616f1cbc4d0dd4054f1bf78 Patch-mainline: Queued in subsystem maintainer repo References: bnc#812116
[...]
[PATCH] atl1c: use custom skb allocator
Good job in identifying this patch and upstream bugzilla. Seems like it is exactly the same issue. I would've liked to clarify the root cause of the issue if possible. Do you have access to a similar controller where we could reproduce the issue? I had a look and there are none in Orthos. This is not surprising, according to a quick search, the AR8152 is used in netbooks/laptops (asus eee pc R11XC, Toshiba Satellite L755-S5216, Acer AO521, Dell Inspiron N4010, ...). Since you deal with a few systems like that at the Taipei office I thought that perhaps we could be lucky and you would have one? -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, Aug 01, 2013 at 09:59:42AM -0400, Benjamin Poirier wrote:
On 2013/07/31 12:11, David Chang wrote:
From: Eric Dumazet
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git Git-commit: 7b70176421993866e616f1cbc4d0dd4054f1bf78 Patch-mainline: Queued in subsystem maintainer repo References: bnc#812116
[...]
[PATCH] atl1c: use custom skb allocator
Thank you for your commnet and review!
Good job in identifying this patch and upstream bugzilla. Seems like it is exactly the same issue. I would've liked to clarify the root cause of the issue if possible. Do you have access to a similar controller where we could reproduce the issue? I had a look and there are none in Orthos. This is not surprising, according to a quick search, the AR8152 is used in netbooks/laptops (asus eee pc R11XC, Toshiba Satellite L755-S5216, Acer AO521, Dell Inspiron N4010, ...). Since you deal with a few systems like that at the Taipei office I thought that perhaps we could be lucky and you would have one?
Unfortunately we don't have any athros ethernet handy. Best Regrads, David
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (2)
-
Benjamin Poirier
-
David Chang