On Tue, 3 Sep 2019 07:40:14 +0000 Guillaume Gardet wrote:

Hi Michal,

With your commit "rpm/mkspec: Make building DTBs optional." https://kernel.opensuse.org/cgit/kernel-source/commit/?h=stable&id=7c057c840fe6de4e7a6445c48c92b0cf60e8a42b latest Tumbleweed is broken because we have no more DTBs built.

Could you re-enable DTB build for ARM (aarch64, armv7, armv6), please?

Thanks, Guillaume

It is enabled on master. Where else are these DTBs used? Thanks Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

-----Original Message----- From: Andreas Schwab Sent: 03 September 2019 11:17 To: Michal Suchánek Cc: Guillaume Gardet ; opensuse- kernel@opensuse.org; Andreas Färber Subject: Re: [opensuse-kernel] Commit "rpm/mkspec: Make building DTBs optional." breaks Tumbleweed for arm

On Sep 03 2019, Michal Suchánek wrote:

...

It is enabled on master. Where else are these DTBs used?

The comment says it should be enabled on stable, but isn't.

Indeed, in stable as used in Tumbleweed. Thanks, Guillaume

Andreas.

-- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-----Original Message----- From: Michal Suchánek Sent: 03 September 2019 11:41 To: Andreas Schwab Cc: Guillaume Gardet ; opensuse- kernel@opensuse.org; Andreas Färber Subject: Re: [opensuse-kernel] Commit "rpm/mkspec: Make building DTBs optional." breaks Tumbleweed for arm

On Tue, 03 Sep 2019 11:16:52 +0200 Andreas Schwab wrote:

...

On Sep 03 2019, Michal Suchánek wrote:

...

It is enabled on master. Where else are these DTBs used?

The comment says it should be enabled on stable, but isn't.

Right, somebody merged packaging but not the commit that enables DTBs on master. I will cherry-pick it.

Thanks! Guillaume

Thanks

Michal

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. N�����r��y隊Z)z{.���w���칻�&ޢ��������'��-���w�zf���^�ˬzG���~� ޮ�^�ˬz��

On Thu, 5 Sep 2019 10:05:23 +0200 Jiri Slaby wrote:

On 03. 09. 19, 11:41, Michal Suchánek wrote:

...

On Tue, 03 Sep 2019 11:16:52 +0200 Andreas Schwab wrote:

...

On Sep 03 2019, Michal Suchánek wrote:

...

It is enabled on master. Where else are these DTBs used?

The comment says it should be enabled on stable, but isn't.

Right, somebody merged packaging but not the commit that enables DTBs on master. I will cherry-pick it.

Michal, perhaps. And I did the same for stable. If you do changes like these, it would be nice to notify maintainers. Or better: merge packaging to all branches where that should be enabled and also enable it.

I merged it into master to fix an issue with SLE15 SP2. The changes were not needed in stable so I left it for the next master merge to get them in. Thanks Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

On Thursday, 5 September 2019 10:10 Michal Suchánek wrote:

On Thu, 5 Sep 2019 10:05:23 +0200

Jiri Slaby wrote:

...

On 03. 09. 19, 11:41, Michal Suchánek wrote:

...

On Tue, 03 Sep 2019 11:16:52 +0200

Andreas Schwab wrote:

...

On Sep 03 2019, Michal Suchánek wrote:

...

It is enabled on master. Where else are these DTBs used?

The comment says it should be enabled on stable, but isn't.

Right, somebody merged packaging but not the commit that enables DTBs on master. I will cherry-pick it.

Michal, perhaps. And I did the same for stable. If you do changes like these, it would be nice to notify maintainers. Or better: merge packaging to all branches where that should be enabled and also enable it. I merged it into master to fix an issue with SLE15 SP2. The changes were not needed in stable so I left it for the next master merge to get them in.

This is certainly unfortunate that every branch merging packaging will need an update of rpm/config.sh to keep building the DTBs. If the default is "do not build", maintainers of all potentially affected branches should be warned. But I have to admit I'm not completely sure which branches are supposed to merge packaging and which are not. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

On Thu, 5 Sep 2019 10:11:56 +0200 Jiri Slaby wrote:

On 05. 09. 19, 10:10, Michal Suchánek wrote:

...

I merged it into master to fix an issue with SLE15 SP2. The changes were not needed in stable so I left it for the next master merge to get them in.

OK, but I merge packaging more often, not only with master -> stable merge.

ok, then more packaging cherry-picks from master are needed as well. Will try to keep that in mind. Thanks Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org