[opensuse-kernel] [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

matwey.kornilov＠gmail.com

6 Jun 2017 6 Jun '17

17:24

From: Jon Hunter Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider(). Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov --- Hello, this patch is required to fix kernel build for armv7l. The build is currently broken due to the following SUSE patch: rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk: /* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent; - args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0; if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue; - if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); } return 0; -- 2.12.0 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Show replies by date

Andreas Färber

6 Jun 6 Jun

17:48

New subject: [opensuse-kernel] Re: [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

Hi Matwey, Am 06.06.2017 um 19:24 schrieb matwey.kornilov@gmail.com:

...

From: Jon Hunter

Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider().

Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov ---

Hello, this patch is required to fix kernel build for armv7l.

The build is currently broken due to the following SUSE patch:

rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch

Please make it clear what branch this is about. For master branch I have reported other exynos build failures upstream, and it appears the fix is already in linux-next.git but not yet in linux.git. So I am assuming this is once again about 42.3, so you could use [PATCH openSUSE-42.3] for instance. (--subject-prefix="PATCH ...") Ultimately a patch against kernel-source.git rather than kernel.git is needed. @Matthias/Yousaf/Michal, how do you intend to handle this ARMv7 case: Should such fixes go to openSUSE-42.3 only, or do you want them on SLE12-SP3 to facilitate merging? Regards, Andreas

...

arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk:

/* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent;

- args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0;

if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue;

- if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); }

return 0;

-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Matwey V. Kornilov

17:53

New subject: [opensuse-kernel] Re: [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

2017-06-06 20:48 GMT+03:00 Andreas Färber :

...

Hi Matwey,

Am 06.06.2017 um 19:24 schrieb matwey.kornilov@gmail.com:

...
From: Jon Hunter

Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider().

Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov ---

Hello, this patch is required to fix kernel build for armv7l.

The build is currently broken due to the following SUSE patch:

rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch

Please make it clear what branch this is about.

For master branch I have reported other exynos build failures upstream, and it appears the fix is already in linux-next.git but not yet in linux.git.

So I am assuming this is once again about 42.3, so you could use [PATCH openSUSE-42.3] for instance. (--subject-prefix="PATCH ...")

Sorry, it is for 42.3. I will use proper prefix. rk3399-* breaks tons of things

...

Ultimately a patch against kernel-source.git rather than kernel.git is needed.

Hm. As far as I remember I was told just to send plain patches to maintainer.

...

@Matthias/Yousaf/Michal, how do you intend to handle this ARMv7 case: Should such fixes go to openSUSE-42.3 only, or do you want them on SLE12-SP3 to facilitate merging?

Regards, Andreas

...
arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk:

/* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent;

- args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0;

if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue;

- if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); }

return 0;

-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

-- With best regards, Matwey V. Kornilov http://blog.matwey.name xmpp://0x2207@jabber.ru -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Takashi Iwai

18:02

New subject: [opensuse-kernel] Re: [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

On Tue, 06 Jun 2017 19:48:41 +0200, Andreas Färber wrote:

...

Hi Matwey,

Am 06.06.2017 um 19:24 schrieb matwey.kornilov@gmail.com:

...
From: Jon Hunter

Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider().

Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov ---

Hello, this patch is required to fix kernel build for armv7l.

The build is currently broken due to the following SUSE patch:

rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch

Please make it clear what branch this is about.

For master branch I have reported other exynos build failures upstream, and it appears the fix is already in linux-next.git but not yet in linux.git.

So I am assuming this is once again about 42.3, so you could use [PATCH openSUSE-42.3] for instance. (--subject-prefix="PATCH ...")

Ultimately a patch against kernel-source.git rather than kernel.git is needed.

@Matthias/Yousaf/Michal, how do you intend to handle this ARMv7 case: Should such fixes go to openSUSE-42.3 only, or do you want them on SLE12-SP3 to facilitate merging?

It should go to SLE12-SP3. It's specific to exynos, so safe to apply to SP3, after all. In anyway, please open a bugzilla entry to track it, and put relevant people to Cc. It's mandatory for merging a patch. thanks, Takashi

...

Regards, Andreas

...
arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk:

/* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent;

- args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0;

if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue;

- if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); }

return 0;

-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Matwey V. Kornilov

18:06

New subject: [opensuse-kernel] Re: [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

2017-06-06 21:02 GMT+03:00 Takashi Iwai :

...

On Tue, 06 Jun 2017 19:48:41 +0200, Andreas Färber wrote:

...
Hi Matwey,

Am 06.06.2017 um 19:24 schrieb matwey.kornilov@gmail.com:

...
From: Jon Hunter

Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider().

Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov ---

Hello, this patch is required to fix kernel build for armv7l.

The build is currently broken due to the following SUSE patch:

rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch

Please make it clear what branch this is about.

For master branch I have reported other exynos build failures upstream, and it appears the fix is already in linux-next.git but not yet in linux.git.

So I am assuming this is once again about 42.3, so you could use [PATCH openSUSE-42.3] for instance. (--subject-prefix="PATCH ...")

Ultimately a patch against kernel-source.git rather than kernel.git is needed.

@Matthias/Yousaf/Michal, how do you intend to handle this ARMv7 case: Should such fixes go to openSUSE-42.3 only, or do you want them on SLE12-SP3 to facilitate merging?

It should go to SLE12-SP3. It's specific to exynos, so safe to apply to SP3, after all.

In anyway, please open a bugzilla entry to track it, and put relevant people to Cc. It's mandatory for merging a patch.

May I open single one issue for all patches? There are lots coming. Unfortunately to many API changes has been backported and many armv7l drivers are affected.

...

thanks,

Takashi

...
Regards, Andreas

...
arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk:

/* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent;

- args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0;

if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue;

- if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); }

return 0;

-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

Takashi Iwai

18:13

New subject: [opensuse-kernel] Re: [PATCH] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider()

On Tue, 06 Jun 2017 20:06:10 +0200, Matwey V. Kornilov wrote:

...

2017-06-06 21:02 GMT+03:00 Takashi Iwai :

...
On Tue, 06 Jun 2017 19:48:41 +0200, Andreas Färber wrote:

...
Hi Matwey,

Am 06.06.2017 um 19:24 schrieb matwey.kornilov@gmail.com:

...
From: Jon Hunter

Update the EXYNOS PM domain code to use the of_genpd_add_subdomain() and remove any calls to of_genpd_get_from_provider().

Signed-off-by: Jon Hunter Reviewed-by: Krzysztof Kozlowski Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Git-commit: 8d68c3713aa6dcf4f65f7fa8f0b6f692ace18d07 Patch-mainline: v4.9-rc1 Signed-off-by: Matwey V. Kornilov ---

Hello, this patch is required to fix kernel build for armv7l.

The build is currently broken due to the following SUSE patch:

rk3399-0072-PM-Domains-Don-t-expose-generic_pm_domain-structure-.patch

Please make it clear what branch this is about.

For master branch I have reported other exynos build failures upstream, and it appears the fix is already in linux-next.git but not yet in linux.git.

So I am assuming this is once again about 42.3, so you could use [PATCH openSUSE-42.3] for instance. (--subject-prefix="PATCH ...")

Ultimately a patch against kernel-source.git rather than kernel.git is needed.

@Matthias/Yousaf/Michal, how do you intend to handle this ARMv7 case: Should such fixes go to openSUSE-42.3 only, or do you want them on SLE12-SP3 to facilitate merging?

It should go to SLE12-SP3. It's specific to exynos, so safe to apply to SP3, after all.

In anyway, please open a bugzilla entry to track it, and put relevant people to Cc. It's mandatory for merging a patch.

May I open single one issue for all patches? There are lots coming.

Either way works. It's all up to you.

...

Unfortunately to many API changes has been backported and many armv7l drivers are affected.

Oh good to know. Takashi

...

...
thanks,

Takashi

...
Regards, Andreas

...
arch/arm/mach-exynos/pm_domains.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 875a2bab64f6..a540b3933d15 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -193,29 +193,22 @@ no_clk:

/* Assign the child power domains to their parents */ for_each_compatible_node(np, NULL, "samsung,exynos4210-pd") { - struct generic_pm_domain *child_domain, *parent_domain; - struct of_phandle_args args; + struct of_phandle_args child, parent;

- args.np = np; - args.args_count = 0; - child_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(child_domain)) - continue; + child.np = np; + child.args_count = 0;

if (of_parse_phandle_with_args(np, "power-domains", - "#power-domain-cells", 0, &args) != 0) - continue; - - parent_domain = of_genpd_get_from_provider(&args); - if (IS_ERR(parent_domain)) + "#power-domain-cells", 0, + &parent) != 0) continue;

- if (pm_genpd_add_subdomain(parent_domain, child_domain)) + if (of_genpd_add_subdomain(&parent, &child)) pr_warn("%s failed to add subdomain: %s\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); else pr_info("%s has as child subdomain: %s.\n", - parent_domain->name, child_domain->name); + parent.np->name, child.np->name); }

return 0;

-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

-- With best regards, Matwey V. Kornilov http://blog.matwey.name xmpp://0x2207@jabber.ru

-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

2525

Age (days ago)

2525

Last active (days ago)

List overview

Download

5 comments

4 participants

participants (4)

Andreas Färber
Matwey V. Kornilov
matwey.kornilov＠gmail.com
Takashi Iwai