[opensuse-kernel] [PATCH] master armv7 exynos config update
Hi, please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support This patch is against master branch. Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume
Hi Guillaume, Le Tuesday 11 February 2014 à 15:05 +0100, Guillaume Gardet a écrit :
Hi,
please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support (...) +CONFIG_I2C_COMPAT=y
Why? And why is it set in armv7hl/default?
(...) # CONFIG_I2C_HELPER_AUTO is not set
Why can't arm configs have CONFIG_I2C_HELPER_AUTO set as other architectures?
(...) +CONFIG_I2C_MUX=m (...) +CONFIG_I2C_ARB_GPIO_CHALLENGE=m +CONFIG_I2C_MUX_GPIO=m +CONFIG_I2C_MUX_PCA9541=m +CONFIG_I2C_MUX_PCA954x=m +CONFIG_I2C_MUX_PINCTRL=m (...) -# CONFIG_I2C_SMBUS is not set +CONFIG_I2C_SMBUS=m (...) -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set +CONFIG_I2C_ALGOPCF=m +CONFIG_I2C_ALGOPCA=m
Do you actually need all of these? -- Jean Delvare Suse L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jean, Le 12/02/2014 16:04, Jean Delvare a écrit :
Hi Guillaume,
Le Tuesday 11 February 2014 à 15:05 +0100, Guillaume Gardet a écrit :
Hi,
please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support (...) +CONFIG_I2C_COMPAT=y Why? And why is it set in armv7hl/default?
It can be used by some userspace tools.
(...) # CONFIG_I2C_HELPER_AUTO is not set Why can't arm configs have CONFIG_I2C_HELPER_AUTO set as other architectures?
I think it could. I could send another patch which set it for all ARM configs.
(...) +CONFIG_I2C_MUX=m (...) +CONFIG_I2C_ARB_GPIO_CHALLENGE=m +CONFIG_I2C_MUX_GPIO=m +CONFIG_I2C_MUX_PCA9541=m +CONFIG_I2C_MUX_PCA954x=m +CONFIG_I2C_MUX_PINCTRL=m (...) -# CONFIG_I2C_SMBUS is not set +CONFIG_I2C_SMBUS=m (...) -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set +CONFIG_I2C_ALGOPCF=m +CONFIG_I2C_ALGOPCA=m Do you actually need all of these?
Maybe not all of those especially if we enable CONFIG_I2C_HELPER_AUTO but ARM boards are design with expansion connectors where people can add more devices on multi-fonction pins. So, I want to be open with those tiny modules. But if you prefer to not enabling them for now, I can unset them as I do not need them directly for now. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le Wednesday 12 February 2014 à 16:37 +0100, Guillaume Gardet a écrit :
Hi Jean,
Le 12/02/2014 16:04, Jean Delvare a écrit :
Hi Guillaume,
Le Tuesday 11 February 2014 à 15:05 +0100, Guillaume Gardet a écrit :
Hi,
please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support (...) +CONFIG_I2C_COMPAT=y Why? And why is it set in armv7hl/default?
It can be used by some userspace tools.
I know what the option does, I wrote it ;-) My question is specifically, which user-space tools are you using which still require this? This is disabled on all other architectures for several years now. The configuration option itself is over 4 years old now (added in September 2009) so really nobody should need it any longer.
(...) # CONFIG_I2C_HELPER_AUTO is not set Why can't arm configs have CONFIG_I2C_HELPER_AUTO set as other architectures?
I think it could. I could send another patch which set it for all ARM configs.
(...) +CONFIG_I2C_MUX=m (...) +CONFIG_I2C_ARB_GPIO_CHALLENGE=m +CONFIG_I2C_MUX_GPIO=m +CONFIG_I2C_MUX_PCA9541=m +CONFIG_I2C_MUX_PCA954x=m +CONFIG_I2C_MUX_PINCTRL=m (...) -# CONFIG_I2C_SMBUS is not set +CONFIG_I2C_SMBUS=m (...) -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set +CONFIG_I2C_ALGOPCF=m +CONFIG_I2C_ALGOPCA=m Do you actually need all of these?
Maybe not all of those especially if we enable CONFIG_I2C_HELPER_AUTO but ARM boards are design with expansion connectors where people can add more devices on multi-fonction pins. So, I want to be open with those tiny modules. But if you prefer to not enabling them for now, I can unset them as I do not need them directly for now.
OK, then just enable CONFIG_I2C_HELPER_AUTO and you should be fine. -- Jean Delvare Suse L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le 12/02/2014 18:05, Jean Delvare a écrit :
Le Wednesday 12 February 2014 à 16:37 +0100, Guillaume Gardet a écrit :
Hi Jean,
Le 12/02/2014 16:04, Jean Delvare a écrit :
Hi Guillaume,
Le Tuesday 11 February 2014 à 15:05 +0100, Guillaume Gardet a écrit :
Hi,
please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support (...) +CONFIG_I2C_COMPAT=y Why? And why is it set in armv7hl/default? It can be used by some userspace tools. I know what the option does, I wrote it ;-)
My question is specifically, which user-space tools are you using which still require this? This is disabled on all other architectures for several years now. The configuration option itself is over 4 years old now (added in September 2009) so really nobody should need it any longer.
None, personally. It is fine to me to unset it then.
(...) # CONFIG_I2C_HELPER_AUTO is not set Why can't arm configs have CONFIG_I2C_HELPER_AUTO set as other architectures? I think it could. I could send another patch which set it for all ARM configs.
(...) +CONFIG_I2C_MUX=m (...) +CONFIG_I2C_ARB_GPIO_CHALLENGE=m +CONFIG_I2C_MUX_GPIO=m +CONFIG_I2C_MUX_PCA9541=m +CONFIG_I2C_MUX_PCA954x=m +CONFIG_I2C_MUX_PINCTRL=m (...) -# CONFIG_I2C_SMBUS is not set +CONFIG_I2C_SMBUS=m (...) -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set +CONFIG_I2C_ALGOPCF=m +CONFIG_I2C_ALGOPCA=m Do you actually need all of these?
Maybe not all of those especially if we enable CONFIG_I2C_HELPER_AUTO but ARM boards are design with expansion connectors where people can add more devices on multi-fonction pins. So, I want to be open with those tiny modules. But if you prefer to not enabling them for now, I can unset them as I do not need them directly for now. OK, then just enable CONFIG_I2C_HELPER_AUTO and you should be fine.
Ok. Will submit an updated patch. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi, Here is new version of my patch based on Jean comments. * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support This patch is against master branch. Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume
Hi, a little ping for this patch. Guillaume Le 14/02/2014 11:31, Guillaume Gardet a écrit :
Hi,
Here is new version of my patch based on Jean comments.
* changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 2/14/14, 5:31 AM, Guillaume Gardet wrote:
Hi,
Here is new version of my patch based on Jean comments.
* changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
This should be refreshed against the current master (3.14-rc3). Apologies for the lack of response. I was on vacation followed by two weeks of work travel w/ very little free time and very slow internet connectivity. -Jeff -- Jeff Mahoney SUSE Labs
Hi, Here is a new version of my patch based on Jean comments and refreshed against latest master as requested by Jeff. * changes in v3: - refreshed against 3.14-rc4 * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support This patch is against master branch. Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org> Regards, Guillaume
Is there anything wrong with this patch? Guillaume ----- Guillaume Gardet <guillaume.gardet@free.fr> a écrit :
Hi,
Here is a new version of my patch based on Jean comments and refreshed against latest master as requested by Jeff.
* changes in v3: - refreshed against 3.14-rc4 * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 3/9/14, 9:41 AM, guillaume.gardet@free.fr wrote:
Is there anything wrong with this patch?
Nope, I've just been more or less unavailable for most of the last month. I've applied it just now. Thanks for the reminder, -Jeff
----- Guillaume Gardet <guillaume.gardet@free.fr> a écrit :
Hi,
Here is a new version of my patch based on Jean comments and refreshed against latest master as requested by Jeff.
* changes in v3: - refreshed against 3.14-rc4 * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- Jeff Mahoney SUSE Labs
----- Jeff Mahoney <jeffm@suse.com> a écrit :
On 3/9/14, 9:41 AM, guillaume.gardet@free.fr wrote:
Is there anything wrong with this patch?
Nope, I've just been more or less unavailable for most of the last month. I've applied it just now.
Thanks for the reminder,
Thanks. Could you also apply the patch against 13.1 please ? Guillaume
-Jeff
----- Guillaume Gardet <guillaume.gardet@free.fr> a écrit :
Hi,
Here is a new version of my patch based on Jean comments and refreshed against latest master as requested by Jeff.
* changes in v3: - refreshed against 3.14-rc4 * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- Jeff Mahoney SUSE Labs
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 3/9/14, 1:54 PM, guillaume.gardet@free.fr wrote:
----- Jeff Mahoney <jeffm@suse.com> a écrit :
On 3/9/14, 9:41 AM, guillaume.gardet@free.fr wrote:
Is there anything wrong with this patch?
Nope, I've just been more or less unavailable for most of the last month. I've applied it just now.
Thanks for the reminder,
Thanks. Could you also apply the patch against 13.1 please ?
Done. -Jeff
Guillaume
-Jeff
----- Guillaume Gardet <guillaume.gardet@free.fr> a écrit :
Hi,
Here is a new version of my patch based on Jean comments and refreshed against latest master as requested by Jeff.
* changes in v3: - refreshed against 3.14-rc4 * changes in v2: - Remove unneeded modules added in V1 * changes in v1: * Add sound support * Add I2C/SPI support
This patch is against master branch.
Signed-off-by: Guillaume GARDET <guillaume.gardet@opensuse.org>
Regards,
Guillaume
-- Jeff Mahoney SUSE Labs
-- Jeff Mahoney SUSE Labs
participants (4)
-
Guillaume Gardet -
guillaume.gardet＠free.fr
-
Jean Delvare -
Jeff Mahoney