Le 12/06/2014 10:36, Sachin Kamat a écrit :

Hi Guillaume,

On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet wrote:

...

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error: FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.

Signed-off-by: Guillaume GARDET A similar patch has already been submitted by Arnd. Please see below: https://lkml.org/lkml/2014/3/15/40

Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently.

In general, sending an attachment is not the right way to submit a patch. Please refer Documentation/SubmittingPatches in the kernel source for the correct procedure.

Sorry, I forgot to send it inline. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :

On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:

...

Le 12/06/2014 10:36, Sachin Kamat a écrit :

...

Hi Guillaume,

On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet wrote:

...

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error: FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.

Signed-off-by: Guillaume GARDET A similar patch has already been submitted by Arnd. Please see below: https://lkml.org/lkml/2014/3/15/40 Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently. It's in mainline kernel already https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drive...

Ok. It is in mainline but not in 3.15. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Le Thursday 12 June 2014 à 11:44 +0200, Guillaume Gardet a écrit :

Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :

...

On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:

...

Le 12/06/2014 10:36, Sachin Kamat a écrit :

...

Hi Guillaume,

On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet wrote:

...

Hi,

please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. It fixes the following build error: FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister'

Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML.

Signed-off-by: Guillaume GARDET A similar patch has already been submitted by Arnd. Please see below: https://lkml.org/lkml/2014/3/15/40 Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently. It's in mainline kernel already https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drive...

Ok. It is in mainline but not in 3.15.

And as it stands, it won't be, because stable@vger.kernel.org was not Cc'd. "Typo" in the subject makes it sound like a trivial and minor change. "Fix module loading" would probably have made it clearer that it fixes a real issue. Guillaume, if this bothers you, please write to stable@vger.kernel.org and kindly ask them to consider including this commit in future stable releases. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

Le 22/06/2014 18:27, Andreas Färber a écrit :

Am 12.06.2014 12:01, schrieb Jean Delvare:

...

Le Thursday 12 June 2014 à 11:44 +0200, Guillaume Gardet a écrit :

...

Le 12/06/2014 11:03, Kishon Vijay Abraham I a écrit :

...

On Thursday 12 June 2014 02:14 PM, Guillaume Gardet wrote:

...

Le 12/06/2014 10:36, Sachin Kamat a écrit :

...

On Thu, Jun 12, 2014 at 1:48 PM, Guillaume Gardet wrote: > Hi, > > please find in attachment a patch which fixes a typo in drivers/phy/phy-exynos5250-sata.c module license. > It fixes the following build error: > FATAL: modpost: GPL-incompatible module phy-exynos5250-sata.ko uses GPL-only symbol 'platform_driver_unregister' > > Please keep me in CC since I am not subscribed to the linux-kernel@vger.kernel.org ML. > > Signed-off-by: Guillaume GARDET A similar patch has already been submitted by Arnd. Please see below: https://lkml.org/lkml/2014/3/15/40 Was not aware of this one. Will it be merged? I can see that it was sent 3 months ago and got no answer apparently. It's in mainline kernel already https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drive... Ok. It is in mainline but not in 3.15. And as it stands, it won't be, because stable@vger.kernel.org was not Cc'd. "Typo" in the subject makes it sound like a trivial and minor change. "Fix module loading" would probably have made it clearer that it fixes a real issue.

Guillaume, if this bothers you, please write to stable@vger.kernel.org and kindly ask them to consider including this commit in future stable releases. Jean, quite obviously it bothers us that our kernel-exynos package still fails to build: https://build.opensuse.org/package/live_build_log/Kernel:HEAD/kernel-exynos/...

Can you please apply Arnd's or Guillaume's build fix to our tree?

Guillaume, did you follow up on this for future 3.15 stable releases?

Sorry, no time to send it for 3.15+ stable releases ATM. You can do it if you have time. Otherwise, it should wait at least a week. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org