[opensuse-kernel] [PATCH] kernel-binary.spec.in: Force kernel options required by systemd
Without this options, any system that boots with systemd will either not work or be functionally crippled. --- rpm/kernel-binary.spec.in | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/rpm/kernel-binary.spec.in b/rpm/kernel-binary.spec.in index c6794a2..ae1204f 100644 --- a/rpm/kernel-binary.spec.in +++ b/rpm/kernel-binary.spec.in @@ -260,13 +260,21 @@ fi %build_src_dir/scripts/config \ --set-str CONFIG_LOCALVERSION %release_num-%build_flavor \ --enable CONFIG_SUSE_KERNEL \ +%if 0%{?suse_version} > 1210 + --enable CONFIG_IPV6 \ + --enable CONFIG_AUTOFS4_FS \ + --enable CONFIG_CGROUPS \ + --enable CONFIG_FANOTIFY \ + --enable CONFIG_DEVTMPFS \ + --enable CONFIG_DEVTMPFS_MOUNT \ + --enable CONFIG_NAMESPACES \ +%endif %if 0%{?__debug_package:1} --enable CONFIG_DEBUG_INFO \ --disable CONFIG_DEBUG_INFO_REDUCED %else --disable CONFIG_DEBUG_INFO %endif - MAKE_ARGS="$MAKE_ARGS -C %build_src_dir O=$PWD" if test -e %_sourcedir/TOLERATE-UNKNOWN-NEW-CONFIG-OPTIONS; then yes '' | make oldconfig $MAKE_ARGS -- 1.8.0.2 -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/01/2013 02:18 AM, Cristian Rodríguez wrote:
+ --enable CONFIG_IPV6 \ + --enable CONFIG_AUTOFS4_FS \ ... + --enable CONFIG_NAMESPACES \
Oh, are these really needed for systemd to work properly? If so, something is very broken with systemd. And yet, it looks like AUDIT support is needed too which looks broken to me as well. (I see no reason for init to have auditing in the kernel.) - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQ4vBLAAoJEL0lsQQGtHBJExkP+QHAybS7ARkPypJyuU89BLES 9zhtDch7QL4W7oIZPAtGO3EaJPj4Ne3ZQj8mRLzfD56cPo9WOyivWKOvVLi8WJFs /B7fBkNYFdE+jNXSeKhcBX3apKD/aDxcwpGalxcBE9DgCOAA9jls00a9N9ulKaCB 2d/VSCTZrIL8skZ0giU+pHXAE3YU3EvOGFgElhhkMce+Kl9kN6BD7fzIPb9Up7S0 HB/IO7XeBffnpqD+ofiBUl/THgtJKAizm+HRCQpbEEOEOlwjGns9+ro40SUSMoPf 0moyYMW3GHrySSOKZ70p3kWVbOvwgWn57PUisXT5bwprvkbZ1sNprj4OAK0czbhZ xwExnigP7DS8xvT6Rk517K3A+pGBRuclP1mBxXV99iRprpDT6tH6JiedTDDbp+Qq rOwRL1cRZSrH3utSF7y9HrPV7Nk2jdRrlt+zK7ISVy0LAOdXKKIfeThU9fFta2M8 zQYNWk1ckbAWms2FIqYEgt8I7m9a8FcMAr+GjrLLBInkwQI9hKcV2twv1lNU5x1V SdVmm0tZMnIHFeq5D0uNeZvGqSB0quZzFxPXPZ3N0kkQcQH8e0a7ZObGHyhtRJ+E aXxCfllV1Zebpu0zFZU9cwCSSqdJupiqtr6vjR+KLZA85iR2QHUOVYCifSpl1A4W NPlY5V4t9Ca+vCtCxide =JvRj -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
El mar 01 ene 2013 11:18:51 CLST, Jiri Slaby escribió:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/01/2013 02:18 AM, Cristian Rodríguez wrote:
+ --enable CONFIG_IPV6 \ + --enable CONFIG_AUTOFS4_FS \ ... + --enable CONFIG_NAMESPACES \
Oh, are these really needed for systemd to work properly?
autofs is used for mount parallelization, it will modprobe it anyway at early boot. namespaces are required indirectly, units files may use them. (particulary "mount" and "network" namespaces) ipv6 is used in the socket activation logic, however it will handle it if it is either disabled with ipv6.disable=1 or as module. I took this confessedly ugly approach of forcing the options at build time, because this options are not used consistently across the different configs but userspace runs the same units on every different target. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
El mar 01 ene 2013 12:09:50 CLST, Cristian Rodríguez escribió:
namespaces are required indirectly, units files may use them. (particulary "mount" and "network" namespaces)
Specially there is extensive use of "PrivateTemp" which requires the mount namespace to provide an isolated /tmp for applications and spare us a lot of work fixing buggy race temporary file creation bugs that plague the planet. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
El 01/01/13 11:18, Jiri Slaby escribió:
And yet, it looks like AUDIT support is needed too which looks broken to me as well. (I see no reason for init to have auditing in the kernel.)
It uses (writes to the audit log and uses the audit session id as session id) if auditing is enabled via libaudit, what's wrong with that ? -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/01/2013 04:38 PM, Cristian Rodríguez wrote:
El 01/01/13 11:18, Jiri Slaby escribió:
And yet, it looks like AUDIT support is needed too which looks broken to me as well. (I see no reason for init to have auditing in the kernel.)
It uses (writes to the audit log and uses the audit session id as session id) if auditing is enabled via libaudit, what's wrong with that ?
Nothing, but it assumes that /proc/<pid>/loginuid exists (otherwise every `su' creates a new session and all permissions are gone from the logged user as one example, see bnc 793657). The file exists iff auditing is enabled in the kernel... - -- js suse labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQ4wqiAAoJEL0lsQQGtHBJZf8P/Ro60CTDKPRxjtqvWggo1vx1 cqbf7U0QRoRekZi78BBPs11vlUd6eOT9Su2TuZoxh5A/Qlxb0/lFovqoITRGcF3J FI08GZE3dE+zV6nhtrn5dUZrBz+LhA0g49eHv8VVhTre8f+9l626l3NPmJ81sY66 0zLPNUKnXIKbYOgeuxp6STQrmztP8hBpcQikvHZFbMpwjAk+T67yloZUSy+jRf5s TKcBebUxnRD+v8j6t30Xv9+r3OqRYAPE/0L/K/2TUHf2WQQRWv3G29uO1w/QS334 L9IhIAx4sbYYbnqhlyY1GcVlt7uE75kzQhPrxSG2D36AvJCsQje2awfsSkBikLIR 1DBZAKESnQu8bBDbrZBDHKH7gJ26Z2Si0O3gkgMeEFisjpI6fpJ79vfTxS/bZpI3 BeOBY3nvdADmDFSbhGup4LGFAJqR9rVQHtsBd9ynLmRUO+kd8KxnE6mhWQ3kAXws g8x/wHrgn4BPfK/3wmNUatAtXgL6LmcXKcLq8AXst618FUOzmm76UoWz1MtGBNxu sGT0B4tMB6iUCaATCsmrxRGQcwTfM5lQeGS+EgFii/QIIpDdFAXK2RmujEbgA5rh JUVbSBdI9cCFn5AyCvAcLlctdVKg3jT7zIM81XDvY0TfoXPHucXZyPqbAO21rbHf EsBpk4rQUY0cd5ea7HoU =ZHRv -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 1.1.2013 16:09, Cristian Rodríguez wrote:
I took this confessedly ugly approach of forcing the options at build time, because this options are not used consistently across the different configs but userspace runs the same units on every different target.
Please submit the patch to update the configs instead. scripts/config won't help if the wanted options get new dependencies. Also, Jeff has been working on defining the configs as a common base config + flavor specifics, this should get rid of the inconsistencies as well. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
El mar 08 ene 2013 09:31:03 CLST, Michal Marek escribió:
Please submit the patch to update the configs instead. scripts/config won't help if the wanted options get new dependencies.
I am afraid that would be a futile effort as more and more different configs for arm boards will appear..
Also, Jeff has been working on defining the configs as a common base config + flavor specifics, this should get rid of the inconsistencies as well.
That's much better, looking forward to that instead ! :-) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Cristian Rodríguez -
Jiri Slaby -
Michal Marek