[opensuse-kernel] [PATCH] config: Enable missing BayTrail and LynxPoint drivers
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers. --- config/i386/debug | 4 ++-- config/i386/default | 4 ++-- config/i386/pae | 4 ++-- config/i386/vanilla | 4 ++-- config/x86_64/debug | 4 ++-- config/x86_64/default | 4 ++-- config/x86_64/vanilla | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) --- a/config/i386/debug +++ b/config/i386/debug @@ -3949,7 +3949,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3971,7 +3971,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set --- a/config/i386/default +++ b/config/i386/default @@ -3953,7 +3953,7 @@ CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y # CONFIG_PINCTRL_SINGLE is not set -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3979,7 +3979,7 @@ CONFIG_GPIO_AMDPT=m CONFIG_GPIO_GENERIC_PLATFORM=m # CONFIG_GPIO_GRGPIO is not set CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_XILINX is not set # CONFIG_GPIO_ZX is not set --- a/config/i386/pae +++ b/config/i386/pae @@ -3862,7 +3862,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3884,7 +3884,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set --- a/config/i386/vanilla +++ b/config/i386/vanilla @@ -3858,7 +3858,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m # CONFIG_PINCTRL_BROXTON is not set @@ -3880,7 +3880,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set --- a/config/x86_64/debug +++ b/config/x86_64/debug @@ -3848,7 +3848,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3870,7 +3870,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set --- a/config/x86_64/default +++ b/config/x86_64/default @@ -3834,7 +3834,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3856,7 +3856,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set --- a/config/x86_64/vanilla +++ b/config/x86_64/vanilla @@ -3830,7 +3830,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m # CONFIG_PINCTRL_BROXTON is not set @@ -3852,7 +3852,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency? Takashi
--- config/i386/debug | 4 ++-- config/i386/default | 4 ++-- config/i386/pae | 4 ++-- config/i386/vanilla | 4 ++-- config/x86_64/debug | 4 ++-- config/x86_64/default | 4 ++-- config/x86_64/vanilla | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-)
--- a/config/i386/debug +++ b/config/i386/debug @@ -3949,7 +3949,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3971,7 +3971,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
--- a/config/i386/default +++ b/config/i386/default @@ -3953,7 +3953,7 @@ CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y # CONFIG_PINCTRL_SINGLE is not set -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3979,7 +3979,7 @@ CONFIG_GPIO_AMDPT=m CONFIG_GPIO_GENERIC_PLATFORM=m # CONFIG_GPIO_GRGPIO is not set CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_XILINX is not set # CONFIG_GPIO_ZX is not set --- a/config/i386/pae +++ b/config/i386/pae @@ -3862,7 +3862,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3884,7 +3884,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
--- a/config/i386/vanilla +++ b/config/i386/vanilla @@ -3858,7 +3858,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m # CONFIG_PINCTRL_BROXTON is not set @@ -3880,7 +3880,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
--- a/config/x86_64/debug +++ b/config/x86_64/debug @@ -3848,7 +3848,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3870,7 +3870,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
--- a/config/x86_64/default +++ b/config/x86_64/default @@ -3834,7 +3834,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m CONFIG_PINCTRL_BROXTON=m @@ -3856,7 +3856,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
--- a/config/x86_64/vanilla +++ b/config/x86_64/vanilla @@ -3830,7 +3830,7 @@ CONFIG_PINCONF=y CONFIG_GENERIC_PINCONF=y # CONFIG_DEBUG_PINCTRL is not set CONFIG_PINCTRL_AMD=y -# CONFIG_PINCTRL_BAYTRAIL is not set +CONFIG_PINCTRL_BAYTRAIL=y CONFIG_PINCTRL_CHERRYVIEW=m CONFIG_PINCTRL_INTEL=m # CONFIG_PINCTRL_BROXTON is not set @@ -3852,7 +3852,7 @@ CONFIG_GPIO_AMDPT=m # CONFIG_GPIO_DWAPB is not set CONFIG_GPIO_GENERIC_PLATFORM=m CONFIG_GPIO_ICH=m -# CONFIG_GPIO_LYNXPOINT is not set +CONFIG_GPIO_LYNXPOINT=m CONFIG_GPIO_VX855=m # CONFIG_GPIO_ZX is not set
-- Jean Delvare SUSE L3 Support
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, Feb 11, 2016 at 12:59:53PM +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
I have a device to play with: https://hackweek.suse.com/13/projects/1330 Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 11 Feb 2016 13:30:44 +0100, Michal Kubecek wrote:
On Thu, Feb 11, 2016 at 12:59:53PM +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
I have a device to play with: https://hackweek.suse.com/13/projects/1330
OK, I'll then ask upstream why it's only built-in. Other similar drivers like pinctrl-cherryview can be a module. (There is a known ordering problem, but it's a bit different story.) thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Michal, On Thu, 11 Feb 2016 13:30:44 +0100, Michal Kubecek wrote:
On Thu, Feb 11, 2016 at 12:59:53PM +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
I have a device to play with: https://hackweek.suse.com/13/projects/1330
Would you possibly add my patch to your kernel: http://w3.suse.de/~jdelvare/files/pinctrl-baytrail-modular.patch then set PINCTRL_BAYTRAIL=m in the x86 configuration files and test if anything goes wrong? Please also verify that pinctrl-baytrail.ko gets loaded automatically on your system (assuming it has ACPI device "INT33B2" or "INT33FC".) Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Tue, 16 Feb 2016 11:19:00 +0100, Jean Delvare wrote:
Hi Michal,
On Thu, 11 Feb 2016 13:30:44 +0100, Michal Kubecek wrote:
On Thu, Feb 11, 2016 at 12:59:53PM +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
I have a device to play with: https://hackweek.suse.com/13/projects/1330
Would you possibly add my patch to your kernel: http://w3.suse.de/~jdelvare/files/pinctrl-baytrail-modular.patch then set PINCTRL_BAYTRAIL=m in the x86 configuration files and test if anything goes wrong? Please also verify that pinctrl-baytrail.ko gets loaded automatically on your system (assuming it has ACPI device "INT33B2" or "INT33FC".)
If it doesn't work as is, also check whether it gets loaded in initrd. If not, try to add it manually to see whether loading in initrd suffices. thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Takashi, On Thu, 11 Feb 2016 12:59:53 +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
Just for consistency. I also don't much like built-in-only drivers but we already have CONFIG_PINCTRL_AMD=y and it is larger than pinctrl-baytrail. I have just asked upstream if both drivers can be modularized. Could be that they can't because ACPI itself needs to control the pins early, and ACPI is always built-in. Either way, this driver is needed for some systems I think we want to support (Asus and Acer hybrid laptops in particular), so I'm afraid we have to include the driver even if it can't be modularized. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 11 Feb 2016 13:41:55 +0100, Jean Delvare wrote:
Hi Takashi,
On Thu, 11 Feb 2016 12:59:53 +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
Just for consistency. I also don't much like built-in-only drivers but we already have CONFIG_PINCTRL_AMD=y and it is larger than pinctrl-baytrail.
I have just asked upstream if both drivers can be modularized. Could be that they can't because ACPI itself needs to control the pins early, and ACPI is always built-in.
Ah, right now I sent a mail asking about baytrail stuff by myself, too. Should have checked the ML archive beforehand... Please put me to Cc for the followups.
Either way, this driver is needed for some systems I think we want to support (Asus and Acer hybrid laptops in particular), so I'm afraid we have to include the driver even if it can't be modularized.
Yeah, I'm basically for enabling it, but the built-in is the only concern. Let's see. thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, 11 Feb 2016 13:51:27 +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 13:41:55 +0100, Jean Delvare wrote:
Hi Takashi,
On Thu, 11 Feb 2016 12:59:53 +0100, Takashi Iwai wrote:
On Thu, 11 Feb 2016 11:00:43 +0100, Jean Delvare wrote:
We support the Intel BayTrail and LynxPoint systems so I believe we should enable all related drivers.
Well, BayTrail is built-in only, so I left it intentionally. Do you have the platform to test, or is it just for consistency?
Just for consistency. I also don't much like built-in-only drivers but we already have CONFIG_PINCTRL_AMD=y and it is larger than pinctrl-baytrail.
I have just asked upstream if both drivers can be modularized. Could be that they can't because ACPI itself needs to control the pins early, and ACPI is always built-in.
Ah, right now I sent a mail asking about baytrail stuff by myself, too. Should have checked the ML archive beforehand...
My fault, sorry.
Please put me to Cc for the followups.
Will do. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Jean Delvare -
Michal Kubecek -
Takashi Iwai