[opensuse-kernel] kernel:stable PANIC with latest virtualization:xen. upstream PATCH included.
Hi. Current Virtualization:Xen + Kernel:Stable on Opensuse on UEFI is broken. It PANICs on boot, Xen Dom0 is unusable. http://lists.opensuse.org/opensuse-virtual/2016-07/msg00014.html Latest response from Xen-Devel wants a patch to the kernel https://lists.xen.org/archives/html/xen-devel/2016-07/msg03102.html https://lists.xen.org/archives/html/xen-devel/2016-07/msg02928.html It's this commit commit 55f1ea15216a5a14c96738bd5284100a00ffa9dc Author: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> Date: Tue May 31 11:23:43 2016 +0100 efi: Fix for_each_efi_memory_desc_in_map() for empty memmaps Available at https://patchwork.kernel.org/patch/9152623/ diff --git a/include/linux/efi.h b/include/linux/efi.h index c2db3ca..f196dd0 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -1005,7 +1005,7 @@ extern int efi_memattr_apply_permissions(struct mm_struct *mm, /* Iterate through an efi_memory_map */ #define for_each_efi_memory_desc_in_map(m, md) \ for ((md) = (m)->map; \ - (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ + ((void *)(md) + (m)->desc_size) <= (m)->map_end; \ (md) = (void *)(md) + (m)->desc_size) /** Can the patch get added to the Opensuse Kernel/Stable branch so packages can be tested? -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 08/01/2016, 03:36 PM, lists@ssl-mail.com wrote:
Hi.
Current Virtualization:Xen + Kernel:Stable on Opensuse on UEFI is broken. It PANICs on boot, Xen Dom0 is unusable.
http://lists.opensuse.org/opensuse-virtual/2016-07/msg00014.html
Latest response from Xen-Devel wants a patch to the kernel
https://lists.xen.org/archives/html/xen-devel/2016-07/msg03102.html https://lists.xen.org/archives/html/xen-devel/2016-07/msg02928.html
It's this commit
commit 55f1ea15216a5a14c96738bd5284100a00ffa9dc Author: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> Date: Tue May 31 11:23:43 2016 +0100
efi: Fix for_each_efi_memory_desc_in_map() for empty memmaps
The patch is in 4.7 since 4.7-rc3. So we cannot take the patch given it is included already. regards, -- js suse labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Tue, Aug 2, 2016, at 12:03 AM, Jiri Slaby wrote:
The patch is in 4.7 since 4.7-rc3. So we cannot take the patch given it is included already.
Thanks, finally figured that out. I'd assumed that the pkg changelog would actually have all the changes. I guess it's more of a local or recent changelog, That just wasn't clear. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Tue, Aug 2, 2016, at 06:07 AM, lists@ssl-mail.com wrote:
On Tue, Aug 2, 2016, at 12:03 AM, Jiri Slaby wrote:
The patch is in 4.7 since 4.7-rc3. So we cannot take the patch given it is included already.
It looks like the patch needs to be patched https://lists.xen.org/archives/html/xen-devel/2016-08/msg00399.html Specifically - (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ - + ((void *)(md) + (m)->desc_size) <= (m)->map_end; \ + + ((void *)(md) + (m)->desc_size - 1) < (m)->map_end; \ -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On 08/04/2016, 04:00 PM, lists@ssl-mail.com wrote:
On Tue, Aug 2, 2016, at 06:07 AM, lists@ssl-mail.com wrote:
On Tue, Aug 2, 2016, at 12:03 AM, Jiri Slaby wrote:
The patch is in 4.7 since 4.7-rc3. So we cannot take the patch given it is included already.
It looks like the patch needs to be patched
https://lists.xen.org/archives/html/xen-devel/2016-08/msg00399.html
Specifically
- (md) <= (efi_memory_desc_t *)((m)->map_end - (m)->desc_size); \ - + ((void *)(md) + (m)->desc_size) <= (m)->map_end; \ + + ((void *)(md) + (m)->desc_size - 1) < (m)->map_end; \
That's incorrect IMO. Either -1 or <. Not both -1 and <. Anyway, we can take this after it gets upstream. Could you create a bug at bugzilla.suse.com and add me to CC? thanks, -- js suse labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thu, Aug 4, 2016, at 07:10 AM, Jiri Slaby wrote:
That's incorrect IMO. Either -1 or <. Not both -1 and <.
The current kernel, with the "unpatched patch" causes a reproducible PANIC on boot of Xen. The system will NOT boot anymore. With the "patched patch", the system boots OK again. If it's incorrect then it should be fixed before it goes upstream right? -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (2)
-
Jiri Slaby -
lists＠ssl-mail.com