[opensuse-kernel] ignoring build failures in drivers/staging
Hi, to be able to provide packages for mainline and linux-next (*) more reliably, I changed the spec files to retry the build if a staging driver fails. So for instance last week, it looked like this: /home/abuild/rpmbuild/BUILD/kernel-vanilla-3.2.rc3/linux-3.2-rc3/drivers/staging/iio/industrialio-core.c:262:32: error: 'ev_int' undeclared (first use in this function) ... make[5]: *** [drivers/staging/iio/industrialio-core.o] Error 1 ... make: *** [all] Error 2 + test 2 -eq 0 + /home/abuild/rpmbuild/SOURCES/try-disable-staging-driver buildlog Build failed due to drivers/staging/iio Trying to disable CONFIG_IIO GEN /home/abuild/rpmbuild/BUILD/kernel-vanilla-3.2.rc3/linux-obj/Makefile HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --silentoldconfig Kconfig # # configuration written to .config # + echo 'Retrying make' ... In the meantime, iio got fixed in upstream, so the latest kernel-vanilla packages contain it again. Now the question is - do we want this for the master branch (i.e. the Factory kernel) as well? (*) See http://kernel.opensuse.org/branches/vanilla and http://kernel.opensuse.org/branches/linux-next Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/28/2011 07:26 AM, Michal Marek wrote:
Hi,
to be able to provide packages for mainline and linux-next (*) more reliably, I changed the spec files to retry the build if a staging driver fails. So for instance last week, it looked like this:
/home/abuild/rpmbuild/BUILD/kernel-vanilla-3.2.rc3/linux-3.2-rc3/drivers/staging/iio/industrialio-core.c:262:32:
error: 'ev_int' undeclared (first use in this function)
... make[5]: *** [drivers/staging/iio/industrialio-core.o] Error 1 ... make: *** [all] Error 2 + test 2 -eq 0 + /home/abuild/rpmbuild/SOURCES/try-disable-staging-driver buildlog Build failed due to drivers/staging/iio Trying to disable CONFIG_IIO GEN /home/abuild/rpmbuild/BUILD/kernel-vanilla-3.2.rc3/linux-obj/Makefile
HOSTCC scripts/kconfig/conf.o
HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --silentoldconfig Kconfig # # configuration written to .config # + echo 'Retrying make' ...
In the meantime, iio got fixed in upstream, so the latest kernel-vanilla packages contain it again. Now the question is - do we want this for the master branch (i.e. the Factory kernel) as well?
I vote no. These build failures generally only happen immediately after I merge a new RC, are usually caught and fixed after the first build failure, and are useful for reporting and (usually) fixing them upstream. It's not like vanilla or linux-next where they're synced automatically. - -Jeff
(*) See http://kernel.opensuse.org/branches/vanilla and http://kernel.opensuse.org/branches/linux-next
Michal
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJO05e4AAoJEB57S2MheeWySG8P/jmEhpmu6Sir3r7jnt7h7rr6 5YEW/StqpJnhYLdpqF6AhvnzdUSGYt5s2Yv/JBEnrS7kC2lGUT66uGs8ozUNulw/ 0/CZGSRQezCdydZ5wv2kCCwThqbFA8fLcwhJySy84Xm7zv5VOtBltK76n9Okn4r4 S4GJi9XbkOFjY/q2/PPllHTHEmQOrFfQX9eMvyFM6gCu0oX7LpGGmHBgwn8htIvc xE+6r+ffjiPnAdUiwg+4AKgk2zGDJLKbp4/v8blHNYjVAjbdN0E34Uc7Hvo0eU+M cFDvmq4F81r0t00JNOh3GICyRYuK8Qi/XXidUzG13XJ1+UUyb2SHdf6QMKl9FeUX fk/HFqEH0WOV3YMyadcIRUWP81y7yxOIzX65nxOlGizKEf3NCFR6pusRwh8CYlPh OODv8tvVSk3IAP73b8hDtcNMzLYRUyRopRbW6+Ed+V6WYKGZEwJFCbx+OgA7DPHr t3VeT4soWDo97vZt14tIXyEt+UvsCmQJkqPM0LB9IKAUkjLxgBiBxfllFtzYJkx9 Ux/1HzMvXOkSy2hWJF0SIbzrn/hJhGiw8tfX3uvdfgDWh2jPY/44kGiEW5nGnNu5 M3QP+Vs6tJ62+qn/kdSnf9fD7g1ICvRp4WSB+FOxO6bxAVSfn3ae4GIDFfeQ/+cQ Cd7vC8bfi9IF2DHKAtCt =flWr -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Dne 28.11.2011 15:16, Jeff Mahoney napsal(a):
On 11/28/2011 07:26 AM, Michal Marek wrote:
to be able to provide packages for mainline and linux-next (*) more reliably, I changed the spec files to retry the build if a staging driver fails. [...] Now the question is - do we want this for the master branch (i.e. the Factory kernel) as well?
I vote no. These build failures generally only happen immediately after I merge a new RC, are usually caught and fixed after the first build failure, and are useful for reporting and (usually) fixing them upstream. It's not like vanilla or linux-next where they're synced automatically.
OK, I made it only active in linux-next and vanilla. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (2)
-
Jeff Mahoney -
Michal Marek