-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4/28/14, 8:53 AM, Jan Beulich wrote:

...

...

...

On 28.04.14 at 14:46, <jeffm@suse.com> wrote: Commit b0b49f2673f (x86, vdso: Remove compat vdso support) removed the FIX_VDSO macro defining the vdso area.

This patch updates it to use the vdso pointer and size to define the area instead.

Now that I look at it a second time I think the change can be _much_ smaller (and we won't need any backport):

...

@@ -141,8 +154,7 @@ static inline int arch_unw_user_mode(/*c #else return user_mode_vm(&info->regs) || info->regs.ip < PAGE_OFFSET - || (info->regs.ip >= __fix_to_virt(FIX_VDSO) - && info->regs.ip < __fix_to_virt(FIX_VDSO) + PAGE_SIZE) + || is_vdso32_area(info) || info->regs.sp < PAGE_OFFSET; #endif }

Afaict when is_vdso32_area() returns true, ->regs.ip can only ever be < PAGE_OFFSET, i.e. all we need is to delete the extra check.

Ha. Yep. You're right. Even better. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTXlEVAAoJEB57S2MheeWycmUP/2pgZIZwLQ4NW7d+0EGQquBf kOwBNWf+k7bbB6AHmcK5zCc42IN4vFrjaWyZdk+EoHrJifFLw5iwmyd30kgg1c3l Odj4H2EV83CF4uMnBTZyx/RSMoz7iER2ImjwokXY3JRfEl+qXiii1yCYlcBW2dM0 bp/omoY4CC1Fdft/JLrBBLDtUm/wXpWPj4eeg73rm0HIBP4dqXext+pFkIKgQP9E 1vfI3/+7k3GeKNpoU7WWZ08G5jooY0rZkwJde+akKpGbCYnTScsu+Z6e4mg1BlpS YobwUywgfg5jnrDFAmEmIMQHg3DfLxSU9CjVB5HhdMOSA+cMpw5NeRTAPbPgUyDm lHEESSfNxH7q3R45m4qQc++fqSeacdwuprECPw63Nf4W7KX3rnkiLGbxajJR0IKI fgeBx5udeI82gt0fgR8ZpswQDr9i9a7XSZK/GtbA/2OkcQTQNbLbuyURlMTbcOXe wX/SSRQxdHb+SP/NajUARiA5y/amiO///T5vOvYKSPvbll3f7NNKpc4Wc5rdd434 LqBoGbpC+2XfqpC5sDCLXe2RZctVe9JQ2ilsNUNpwn5YpnjQbAoT+iUQdzit3YS0 9Wvwj8ttitPVz1KcZQe49X8kJZZzZcMln9Zwg+ZMdmLhBAFW3NIFVgSx8X1oBjEQ Sb37qfoi4To6dIdr1Bxk =xPmG -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org