[opensuse-kernel] Fwd: Re: Linux 2.6.22.8, pata_ali issue
---------- Forwarded message ---------- Date: Tue, 25 Sep 2007 21:38:02 +0200 (CEST) From: Jan Engelhardt <jengelh@computergmbh.de> To: Greg KH <gregkh@suse.de> Cc: Oliver Pinter <oliver.pntr@gmail.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, <torvalds@linux-foundation.org>, <stable@kernel.org> Subject: Re: Linux 2.6.22.8, pata_ali issue On Sep 25 2007 10:35, Greg KH wrote:
On Tue, Sep 25, 2007 at 07:03:24PM +0200, Jan Engelhardt wrote:
So, here is something that I think should go into the next 2.6.22. A proper fix is already in 2.6.23-git-du-jour.
Feel free to send the patch, with the git commit id of the upstream commit to the stable@kernel.org address and we will be glad to review it that way.
'right, it is already in the mainline kernel. So it's again the suse kernel src rpm that has it screwed up... another story. Here's your culprit: libata-update-libata-to-libata-dev-upstream-5ddf.patch * Replaces ali_init_chipset() with some new bits, essentially it removes the call to pci_read_config_byte() since the revision is now found in struct pci_dev->revision Basically 2.6.23 stuff. libata-fix-up-build-after-upstream-update.patch * changes it back to the 2.6.22 api, so that it compiles again. But only that. It FORGETS to add pci_read_config_byte() back. === libata-fix-up-build-after-upstream-update.patch
From 54ee7cd26c5e438dc15d13b60c9f8a54ca05e3fb Mon Sep 17 00:00:00 2001 From: Tejun Heo <htejun@gmail.com> Date: Fri, 3 Aug 2007 02:21:51 +0900 Subject: [PATCH] libata: fix up build after upstream update References: 288078
Signed-off-by: Tejun Heo <htejun@gmail.com> === The bug is still present in current suse kotd. >:-( Please fix it there. A cc will go to opensuse-kernel@, but other than that, I am in the wrong mood right now to do anything. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Tue, 25 Sep 2007, Jan Engelhardt wrote:
The bug is still present in current suse kotd. >:-( Please fix it there. A cc will go to opensuse-kernel@, but other than that, I am in the wrong mood right now to do anything.
Jan, sorry, I find your forwarded e-mail too confusing. Are you missing some crucial bugfix from 2.6.22-stable in our KOTD? Or does (re)building of KOTD source rpm fail for you? In the former case, bugzilla entry (with reference to the mainline patch) would be welcome. In the latter case, please describe what exactly you have tried that failed. The current kernel repository should build just fine. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Sep 25 2007 21:50, Jiri Kosina wrote:
On Tue, 25 Sep 2007, Jan Engelhardt wrote:
The bug is still present in current suse kotd. >:-( Please fix it there. A cc will go to opensuse-kernel@, but other than that, I am in the wrong mood right now to do anything.
Jan,
sorry, I find your forwarded e-mail too confusing. Are you missing some crucial bugfix from 2.6.22-stable in our KOTD? Or does (re)building of KOTD source rpm fail for you?
Simple put: SUSE guys doing backporting work borked it up in the process. The following excerpt is from libata-update-libata-to-libata-dev-upstream-5ddf.patch: --- a/drivers/ata/pata_ali.c 2007-07-08 19:32:17.000000000 -0400 +++ b/drivers/ata/pata_ali.c 2007-08-27 14:03:14.000000000 -0400 @@ -455,23 +455,21 @@ static struct ata_port_operations ali_c5 static void ali_init_chipset(struct pci_dev *pdev) { - u8 rev, tmp; + u8 tmp; struct pci_dev *north, *isa_bridge; - pci_read_config_byte(pdev, PCI_REVISION_ID, &rev); - /* * The chipset revision selects the driver operations and * mode data. */ - if (rev >= 0x20 && rev < 0xC2) { + if (pdev->revision >= 0x20 && pdev->revision < 0xC2) { As you can see, rev is computed somewhere else and can be accessed using pdev->revision. The following is from libata-fix-up-build-after-upstream-update.patch which is applied afterwards according to series.conf: --- a/drivers/ata/pata_ali.c 2007-08-27 14:01:23.000000000 -0400 +++ b/drivers/ata/pata_ali.c 2007-08-27 14:01:23.000000000 -0400 @@ -455,7 +455,7 @@ static struct ata_port_operations ali_c5 static void ali_init_chipset(struct pci_dev *pdev) { - u8 tmp; + u8 rev, tmp; struct pci_dev *north, *isa_bridge; /* @@ -463,13 +463,13 @@ static void ali_init_chipset(struct pci_ * mode data. */ - if (pdev->revision >= 0x20 && pdev->revision < 0xC2) { + if (rev >= 0x20 && rev < 0xC2) { As you can see, the pdev->revision magic is reverted back to 'rev', but rev is now uninitialized. Previously, there was pci_read_config_byte() between struct pci_dev *north and the /*, now there is not. See? -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
Now a bug: https://bugzilla.novell.com/show_bug.cgi?id=328422 Andreas -- Andreas Jaeger, Director Platform / openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
On Sep 26 2007 09:28, Andreas Jaeger wrote:
Now a bug: https://bugzilla.novell.com/show_bug.cgi?id=328422
Thanks. (Let's hope it gets fixed *soon*) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
Jan Engelhardt wrote:
On Sep 26 2007 09:28, Andreas Jaeger wrote:
Now a bug: https://bugzilla.novell.com/show_bug.cgi?id=328422
Thanks. (Let's hope it gets fixed *soon*) It already is. Tejun just fixed it.
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
participants (4)
-
Andreas Jaeger -
Hannes Reinecke -
Jan Engelhardt -
Jiri Kosina