[opensuse-kernel] [PATCH] config/armv7hl: Disable AMD_XGBE_PHY
The AMD XGBE ethernet chip is only used on ARM64 systems. --- Andreas, in commit ca6193ecc you set: # CONFIG_AMD_XGBE is not set CONFIG_AMD_XGBE_PHY=m which looks inconsistent. I suppose this was not on purpose and CONFIG_AMD_XGBE_PHY shouldn't have been enabled? config/armv7hl/default | 2 +- config/armv7hl/lpae | 2 +- config/armv7hl/vanilla | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) --- a/config/armv7hl/default +++ b/config/armv7hl/default @@ -2702,7 +2702,7 @@ CONFIG_PHYLIB=y # CONFIG_AT803X_PHY=m CONFIG_AMD_PHY=m -CONFIG_AMD_XGBE_PHY=m +# CONFIG_AMD_XGBE_PHY is not set CONFIG_MARVELL_PHY=m CONFIG_DAVICOM_PHY=m CONFIG_QSEMI_PHY=m --- a/config/armv7hl/lpae +++ b/config/armv7hl/lpae @@ -2586,7 +2586,7 @@ CONFIG_PHYLIB=y # CONFIG_AT803X_PHY=m CONFIG_AMD_PHY=m -CONFIG_AMD_XGBE_PHY=m +# CONFIG_AMD_XGBE_PHY is not set CONFIG_MARVELL_PHY=m CONFIG_DAVICOM_PHY=m CONFIG_QSEMI_PHY=m --- a/config/armv7hl/vanilla +++ b/config/armv7hl/vanilla @@ -2699,7 +2699,7 @@ CONFIG_PHYLIB=y # CONFIG_AT803X_PHY=m CONFIG_AMD_PHY=m -CONFIG_AMD_XGBE_PHY=m +# CONFIG_AMD_XGBE_PHY is not set CONFIG_MARVELL_PHY=m CONFIG_DAVICOM_PHY=m CONFIG_QSEMI_PHY=m -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 06.05.2015 um 09:50 schrieb Jean Delvare:
The AMD XGBE ethernet chip is only used on ARM64 systems. --- Andreas, in commit ca6193ecc you set:
# CONFIG_AMD_XGBE is not set CONFIG_AMD_XGBE_PHY=m
which looks inconsistent. I suppose this was not on purpose and CONFIG_AMD_XGBE_PHY shouldn't have been enabled?
Yeah, probably. I still didn't clean up the 4.0 round of config changes. Reviewed-by: Andreas Färber <afaerber@suse.de> I do wonder about CONFIG_AMD_PHY=m the line before though. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Wed, 06 May 2015 18:19:03 +0200, Andreas Färber wrote:
Am 06.05.2015 um 09:50 schrieb Jean Delvare:
The AMD XGBE ethernet chip is only used on ARM64 systems. --- Andreas, in commit ca6193ecc you set:
# CONFIG_AMD_XGBE is not set CONFIG_AMD_XGBE_PHY=m
which looks inconsistent. I suppose this was not on purpose and CONFIG_AMD_XGBE_PHY shouldn't have been enabled?
Yeah, probably. I still didn't clean up the 4.0 round of config changes.
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks, I'll commit the patch.
I do wonder about CONFIG_AMD_PHY=m the line before though.
Different driver for an older network chip. Used on old MIPS and PowerPC boards according to their defconfigs. It is entirely possible that we could disable it in most or all of our kernels, but how to tell which ones now? This is why I prefer enabling things once we know they are needed, rather than just in case. People never complain about drivers nobody uses (how would they know) but they will always let us know if a driver they need is missing. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Andreas Färber -
Dirk Müller -
Jean Delvare