[opensuse-kernel] [PATCH] b43: Change firmware missing message to refer to openSUSE script
The error message output by b43 contains instructions for obtaining firmware; however, this naturally does not take account of the script /usr/sbin/install_bcm43xx_firmware. Modify the messages to suggest use of the script. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- This patch could be used for 2.6.31 kernels in openSUSE 11.2 or 2.6.34 kernels in 11.3. Larry --- Index: linux-2.6/drivers/net/wireless/b43/main.c =================================================================== --- linux-2.6.orig/drivers/net/wireless/b43/main.c +++ linux-2.6/drivers/net/wireless/b43/main.c @@ -1976,10 +1976,14 @@ static void b43_release_firmware(struct static void b43_print_fw_helptext(struct b43_wl *wl, bool error) { const char text[] = - "You must go to " \ - "http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware " \ - "and download the correct firmware for this driver version. " \ - "Please carefully read all instructions on this website.\n"; + "If you have Internet access with Linux, please open a " \ + "terminal and enter the command " \ + "\"sudo /usr/sbin/install_bcm43xx_firmware\" to download " \ + " the correct firmware for this driver version. " \ + "If you do not have Internel access, " \ + "http://forums.opensuse.org/get-help-here/wireless/" + "309432-welcome.html has instructions on how to download" \ + " from another machine.\n"; if (error) b43err(wl, text); -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Thu, 06 May 2010 11:05:54 -0500, Larry Finger wrote:
const char text[] = - "You must go to " \ - "http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware " \ - "and download the correct firmware for this driver version. " \ - "Please carefully read all instructions on this website.\n"; + "If you have Internet access with Linux, please open a " \ + "terminal and enter the command " \ + "\"sudo /usr/sbin/install_bcm43xx_firmware\" to download " \ + " the correct firmware for this driver version. " \ + "If you do not have Internel access, " \ ^^^^^^^^ Interne_t_ + "http://forums.opensuse.org/get-help-here/wireless/" + "309432-welcome.html has instructions on how to download" \ + " from another machine.\n";
I don't think hardcoding a link to a forum into the kernel is a good idea. Creating a page on openSUSE wiki and linking that could have a greater chance to survive the next web reshuffling. (Oh well, we've been missing a generic solution for reporting missing firmware to user for quite some time...) Thanks, Jiri -- Jiri Benc SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Thu, May 6, 2010 at 12:16 PM, Jiri Benc <jbenc@suse.cz> wrote:
On Thu, 06 May 2010 11:05:54 -0500, Larry Finger wrote:
const char text[] = - "You must go to " \ - "http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware " \ - "and download the correct firmware for this driver version. " \ - "Please carefully read all instructions on this website.\n"; + "If you have Internet access with Linux, please open a " \ + "terminal and enter the command " \ + "\"sudo /usr/sbin/install_bcm43xx_firmware\" to download " \ + " the correct firmware for this driver version. " \ + "If you do not have Internel access, " \ ^^^^^^^^ Interne_t_ + "http://forums.opensuse.org/get-help-here/wireless/" + "309432-welcome.html has instructions on how to download" \ + " from another machine.\n";
I don't think hardcoding a link to a forum into the kernel is a good idea. Creating a page on openSUSE wiki and linking that could have a greater chance to survive the next web reshuffling.
(Oh well, we've been missing a generic solution for reporting missing firmware to user for quite some time...)
Thanks,
Jiri
-- Jiri Benc SUSE Labs
There is a existing wiki page dedicated to the Broadcom's http://en.opensuse.org/HCL/Network_Adapters_%28Wireless%29/Broadcom_BCM43xx I don't know if it has the alternate download instructions, but easy to add and link to. (No I'm not volunteering, but I've worked on that page before so I knew it existed.) Greg -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On 05/06/2010 11:26 AM, Greg Freemyer wrote:
There is a existing wiki page dedicated to the Broadcom's
http://en.opensuse.org/HCL/Network_Adapters_%28Wireless%29/Broadcom_BCM43xx
I don't know if it has the alternate download instructions, but easy to add and link to. (No I'm not volunteering, but I've worked on that page before so I knew it existed.)
Thanks Greg. I will modify that page. Larry -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On 05/06/2010 11:16 AM, Jiri Benc wrote:
I don't think hardcoding a link to a forum into the kernel is a good idea. Creating a page on openSUSE wiki and linking that could have a greater chance to survive the next web reshuffling.
(Oh well, we've been missing a generic solution for reporting missing firmware to user for quite some time...)
Thanks for the quick review. I'll fix the typo, change the link to the page that Greg Freemyer noted, and resubmit. I will need to update that wiki page. Larry -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
participants (3)
-
Greg Freemyer -
Jiri Benc -
Larry Finger