CONFIG_NFS_V4_2_READ_PLUS in master
Hi Michal, I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87. However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now? Cheers, Petr T
On 31. 10. 23, 7:57, Petr Tesařík wrote:
I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87.
However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now?
Hi, could you create a bug with the above text and perhaps CC NeilB. So that we can: 1) reference the bug in the commit, and 2) find the history behind the change eventually? thanks, -- js suse labs
On 31. 10. 23, 8:42, Jiri Slaby wrote:
On 31. 10. 23, 7:57, Petr Tesařík wrote:
I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87.
However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now?
Hi,
could you create a bug with the above text and perhaps CC NeilB. So that we can: 1) reference the bug in the commit, and 2) find the history behind the change eventually?
And maybe attach a patch ;)...
thanks, -- js suse labs
On Tue, 31 Oct 2023 08:44:01 +0100 Jiri Slaby <jslaby@suse.cz> wrote:
On 31. 10. 23, 8:42, Jiri Slaby wrote:
On 31. 10. 23, 7:57, Petr Tesařík wrote:
I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87.
However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now?
Hi,
could you create a bug with the above text and perhaps CC NeilB. So that we can: 1) reference the bug in the commit, and 2) find the history behind the change eventually?
And maybe attach a patch ;)...
Good, I get it that there's no inherent reason to oppose the change. I'll make a bug report later today... Petr T
On Tue, Oct 31, 2023 at 08:42:00AM +0100, Jiri Slaby wrote:
On 31. 10. 23, 7:57, Petr Tesařík wrote:
I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87.
However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now?
Hi,
could you create a bug with the above text and perhaps CC NeilB. So that we can: 1) reference the bug in the commit, and 2) find the history behind the change eventually?
3) mainline commit 9cf2744d2491 ("NFS: Enable the READ_PLUS operation by default") should probably be mentioned as part of the reasoning as its commit message explicitly states that the reasons why it was originally disabled (and even introduced, IIUC) are gone. Michal
On Tue, 31 Oct 2023 09:14:47 +0100 Michal Kubecek <mkubecek@suse.cz> wrote:
On Tue, Oct 31, 2023 at 08:42:00AM +0100, Jiri Slaby wrote:
On 31. 10. 23, 7:57, Petr Tesařík wrote:
I can see that CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d1965e27f2da795a27a15d93d4cf67d. This is understandable, given mainline commit 21e31401fc4595aeefa224cd36ab8175ec867b87.
However, it seems that all issues have been worked out, see mainline commit 9cf2744d249144fc0fe17667b56da78216678378. Could we re-enable CONFIG_NFS_V4_2_READ_PLUS in master now?
Hi,
could you create a bug with the above text and perhaps CC NeilB. So that we can: 1) reference the bug in the commit, and 2) find the history behind the change eventually?
3) mainline commit 9cf2744d2491 ("NFS: Enable the READ_PLUS operation by default") should probably be mentioned as part of the reasoning as its commit message explicitly states that the reasons why it was originally disabled (and even introduced, IIUC) are gone.
Michal
Enjoy https://bugzilla.suse.com/show_bug.cgi?id=1216736 Petr T P.S. Yes, I am too lazy to find out who can change my email address in Bugzilla, so it's still ptesarik@suse.com, which does not work...
participants (3)
-
Jiri Slaby
-
Michal Kubecek
-
Petr Tesařík