[opensuse-kernel] 13.1 kABI
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all - While looking into a separate issue today, I noticed that the kABI reference files for the 13.1 release were never generated. After generating them, I did encounter some breakage. The first, and biggest, was a change to struct sock which ends up affecting a ton of code. I ended up reverting two patches from 3.11.7 that introduced the breakage. It seemed clear from the commit messages that the intended goal was to remove an annoyance, not to fix a security issue, a crash, or to avoid data corruption. commit 0ec4877d04b43004091786005e6f217c09b23b3e Author: Jeff Mahoney <jeffm@suse.com> Date: Thu Apr 3 23:29:41 2014 -0400 KABI: revert tcp: TSO packets automatic sizing. commit cd5a9525e4753bcce530af4e5549faf694e68498 Author: Jeff Mahoney <jeffm@suse.com> Date: Thu Apr 3 23:29:41 2014 -0400 KABI: revert tcp: TSQ can use a dynamic limit. There was breakage in IRDA due to: commit d769b308d10af89aafefcbda0c7ea35916c6d8ee Author: Takashi Iwai <tiwai@suse.de> Date: Mon Mar 17 10:08:44 2014 +0100 Enable CONFIG_IRDA_FAST_RR=y (bnc#860502) The upside seems obvious and I'm not too concerned about breaking external ircomm drivers. I haven't added an exception for it yet. There was also breakage in l2tp and KVM. I've added exceptions for both of those. A minor nit in sunrpc was fixed by moving the location of an include directive. That leaves some other breakage: KABI: symbol ipv6_recv_error(vmlinux) changed crc from 0x0c79e6de to 0xd4840844 KABI: symbol pingv6_ops(vmlinux) changed crc from 0x79f2b65e to 0x20e4c907 These are changed due to legitimate bug fixes and can have exceptions added for them trivially, but I wanted to leave that open for discussion. Since there is breakage without exceptions, the builds will start complaining now. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTPilOAAoJEB57S2MheeWyhOAP/R+ZvyusjOwyW6zk0Hb0270/ tBCWppUD91jeJLs5ehykffmBa3iIcAHXlbgizDAIwfH6uwZnaj6kfykyn9HenfIy tBB1uTJPoHnLaK09m4kGSGdoIMg4doFSltq0FZHSmGHbMW1A4KvzzjA+JLq7LqhH m4gZJ0ewXEWnnuH/iDC2onp4hxozEOPN2BmP2MtsXVuNkg1kUEZ/Q/IsVl9g5Ubq AbJsLcQ1N/lDUkHAuJRwH7qabShpWVrHy17avRw1I/qWIPErHvtMFGwubpUhIS1f QEzLbLI78RRkYVZug49Ab87Q9JylAoEoF7BTHkTYTHAG16v4JvqcnhkTBMBGLbNF 0apI8ieYP/wUe0QQfgVqoB8T+VnBY00x+uRIdJGlz3USrhmnObgkd0gtJxEwS+Ba S/1nGMaSVxSJz27YQRgCwThukrVQm09g7wCyY9lFu8J4qewZjIVItyqdOZUO5Cmt 0JWQo7ZGZ74dOFnV56pEZCngiuv2lLhWMmzMeoAx7HRKzbyRMJosdBh8TKinSdjU yMyhcQitViRTrFs1i02k49csr6EaJBgbRdkBgdiTRHC5kg3hiWW0J8Usc9uyr/UM JaG8VqmdCaVDr/2SFlGRFrAYif2Kl+y1qdtxylzer6raVdZWtOHtQbrDvfKi97ZT 3TbqomY65xmSBW1pBUYQ =1Do8 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Thursday 03 of April 2014 23:38:54 Jeff Mahoney wrote:
That leaves some other breakage: KABI: symbol ipv6_recv_error(vmlinux) changed crc from 0x0c79e6de to 0xd4840844 KABI: symbol pingv6_ops(vmlinux) changed crc from 0x79f2b65e to 0x20e4c907
These are changed due to legitimate bug fixes and can have exceptions added for them trivially, but I wanted to leave that open for discussion.
struct pingv6_ops is IMHO safe, this seems to be only used as type for callbacks provided by ipv6 module and fake versions of those to be used if IPv6 is built as a module and not loaded. I can't imagine any use for this type in a third party module. On the other hand, ipv6_recv_error() might not be as safe; it is already used by IPv6 L2TP implementation and there might be uses for it in third party modules. But we could work around this by renaming the function and providing a wrapper without the addr_len parameter under the original name which would call the new function with addr_len = NULL (and modifying it so that it doesn't assign into *addr_len if addr_len is null). That way our code would work as intended and third party modules calling ipv6_recv_error() would work (as bad) as before. We could, of course, use a similar trick for struct pingv6_ops and pingv6_ops as well. Michal Kubeček -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
At Thu, 03 Apr 2014 23:38:54 -0400, Jeff Mahoney wrote:
There was breakage in IRDA due to: commit d769b308d10af89aafefcbda0c7ea35916c6d8ee Author: Takashi Iwai <tiwai@suse.de> Date: Mon Mar 17 10:08:44 2014 +0100
Enable CONFIG_IRDA_FAST_RR=y (bnc#860502)
The upside seems obvious and I'm not too concerned about breaking external ircomm drivers. I haven't added an exception for it yet.
Yes, the kABI breakage doesn't matter much in this case. Could you add the exception for this? thanks, Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4/4/14, 5:39 AM, Takashi Iwai wrote:
At Thu, 03 Apr 2014 23:38:54 -0400, Jeff Mahoney wrote:
There was breakage in IRDA due to: commit d769b308d10af89aafefcbda0c7ea35916c6d8ee Author: Takashi Iwai <tiwai@suse.de> Date: Mon Mar 17 10:08:44 2014 +0100
Enable CONFIG_IRDA_FAST_RR=y (bnc#860502)
The upside seems obvious and I'm not too concerned about breaking external ircomm drivers. I haven't added an exception for it yet.
Yes, the kABI breakage doesn't matter much in this case. Could you add the exception for this?
Done. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTPsIHAAoJEB57S2MheeWydW0QAIDQ3mPl3aMU4AAOWOj4KBdE ztW4dPBLhBngSX2/Yvp1UtGFPF1TP2bMdGCPbsvT2f1jnyUOTeGFhmScfYjjpMcl yS63hLfKtjxiQwu7roUVu3DRKDoi1smsh2x64nmWiSldpHcXcwcFZxTfMr2HYsKC MmNltLFw95KISy7FhY+xfdaMbCz7nK5p9OCjY4dvpgq2xSfKjXKiGnmjeTsdar6N Pt0RGbtDdy+zwInfM0ZEmC11T0v5NuT27UssKP50Gq6SMifiSNs/3DKMrp1I3XT+ HUn/kwpoheKtxO7uum85l5o4BU6II2QflPtp4/qHcHkTfvte2DpWYv9TpZAcSK9v 1QebUvDKPT6yoerDh0Iyc9Eh0020NL9L0VlFcEw++yJ0RNg6bmSDlsWZDL5Tg9GA fUserjhJMbbigr2FkPG6zuwUKy/zP02WdphxfhHZc4IwE8VH7gsIfcy5SBPZTXS3 ZcRqHQpRAley0FTAlTtSuSN9VF7tUWJTQ8wo0WGTglHdL5XCLL8ycJ/hraX/QuJb jTjIoHG3mi15F61hDmbapppkgUsEUvJWgYpKeHiJ5Po5nvCT3oHBqMiCh4zAWTp2 YAI2wmHGtnKq6EFgdABLfNIFAO4aQC8yKy5k0obPBIjE8sHp3HFhd/THjtLT5ko5 eLVa0psepitvRraiGztO =h9Mh -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Jeff Mahoney -
Michal Kubecek -
Takashi Iwai