-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 4/25/14, 4:37 AM, Martin Konold wrote:
Am Donnerstag, 24. April 2014, 21:27:35 schrieb Jeff Mahoney:
Hi Jeff,
That *should* do it. Can you post the file you're using? It's pretty sensitive to the formatting IIRC. Thanks for the hint. Indeed some more strict formatting did help!
Are you interested in trivial patches which mainly improve documentation for newbies to SuSE kernel development?
Yeah, absolutely! Ok, I start with a one-liner for improved error message in order to learn how to properly contribute patches. (e.g. formatting etc.)
Sure. Review below.
wd-functions.diff
From: Martin Konold <martin.konold@erfrakon.de> Subject: linux 2.6 is ancient avoid explicit kernel version, LINUX_GIT is an environment variable
This should be something like: Subject: scripts: use 'linux' git repo instead of 'linux-2.6' .. and then put the message you have in your Subject line as the commit text.
Patch-mainline: never. Improves SUSE specific code References:
If this is empty, it can be omitted.
diff --git a/scripts/wd-functions.sh b/scripts/wd-functions.sh index aa2c526..3b02f5f 100644
Acked-by:
You can omit this. Whoever adds your patch can add their own.
Signed-off-by:
This should be your signed-off-by, which is essentially the same thing as your From.
--- a/scripts/wd-functions.sh +++ b/scripts/wd-functions.sh @@ -74,7 +74,7 @@ _get_tarball_from_git()
git=${LINUX_GIT:-$HOME/linux-2.6} if test ! -d "$git/.git"; then - echo "No linux-2.6 git tree found (try setting the LINUX_GIT variable)" >&2 + echo "No linux git tree found (try setting the LINUX_GIT environment variable)" >&2 exit 1 fi case "$version" in
Otherwise, looks good. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTWoHuAAoJEB57S2MheeWyfScP/3iLRgcJLFYY9LQCKAm1Va4l nmKvsFuypcddXl8uo637RvOKEn9tVK7jeE5gT99fy6IBvAhgkrUFUmQ4gyD+nQx5 O0o5SBicq9IiWjTm9dMUUbkKo5EZntHNYJGfhBbVvQg59tOFQxC+hyjWuJCAtG3x c3hR2R5qfnaJVkOvatRgwUxcezfI1Rz6BDaqv0PsstmtzpeN1DNADNnHJF1Ju62v VjHlDHFNNkijgd/uyvMdUFUN4cH3pD2tP9yHbZdu574xcONiHFhSPJ1kxltTdESu a3C+MMj7e88SAW8fVh376t74DO61VGAYyhanxPED74cWxVqPF5hLLCgEg6/7GXcG eNAdupzVngH8UF7ofpbTbEOVITdPPTBvNFl7zSKZ5gBAIv49AAuE44LhxRso2qCW 1AkKKoLiPmwQoYPLkQPIMzeHhPxzRyspifm1GRfGUEyuTtR6D0CcKQBjgy5t78ye 5SQKdF+6Av59BES+pxDm5bePfcCQW3OIov5H5eTIKApwthT2UAN/njnjoVn7C3lH Py5kr2TUW8QbPM2QF7BTdm5VjOwEh3SrTClXZCOvnrRbjFwUIlfs7R5r6BkLctF7 DbrjzFqAsNaahzRsKIbuhOH3Yb5At/pqXVMpsU5g+sjgEUh/QrWilSl+ji30RyhP CYHgV/rsnZL6GlhyEdfx =Y94k -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org