Le 12/02/2014 18:05, Jean Delvare a écrit :
Le Wednesday 12 February 2014 à 16:37 +0100, Guillaume Gardet a écrit :
Hi Jean,
Le 12/02/2014 16:04, Jean Delvare a écrit :
Hi Guillaume,
Le Tuesday 11 February 2014 à 15:05 +0100, Guillaume Gardet a écrit :
Hi,
please find in attachment an ARMv7 exynos config update to enhance arndale board. * Add sound support * Add I2C/SPI support (...) +CONFIG_I2C_COMPAT=y Why? And why is it set in armv7hl/default? It can be used by some userspace tools. I know what the option does, I wrote it ;-)
My question is specifically, which user-space tools are you using which still require this? This is disabled on all other architectures for several years now. The configuration option itself is over 4 years old now (added in September 2009) so really nobody should need it any longer.
None, personally. It is fine to me to unset it then.
(...) # CONFIG_I2C_HELPER_AUTO is not set Why can't arm configs have CONFIG_I2C_HELPER_AUTO set as other architectures? I think it could. I could send another patch which set it for all ARM configs.
(...) +CONFIG_I2C_MUX=m (...) +CONFIG_I2C_ARB_GPIO_CHALLENGE=m +CONFIG_I2C_MUX_GPIO=m +CONFIG_I2C_MUX_PCA9541=m +CONFIG_I2C_MUX_PCA954x=m +CONFIG_I2C_MUX_PINCTRL=m (...) -# CONFIG_I2C_SMBUS is not set +CONFIG_I2C_SMBUS=m (...) -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set +CONFIG_I2C_ALGOPCF=m +CONFIG_I2C_ALGOPCA=m Do you actually need all of these?
Maybe not all of those especially if we enable CONFIG_I2C_HELPER_AUTO but ARM boards are design with expansion connectors where people can add more devices on multi-fonction pins. So, I want to be open with those tiny modules. But if you prefer to not enabling them for now, I can unset them as I do not need them directly for now. OK, then just enable CONFIG_I2C_HELPER_AUTO and you should be fine.
Ok. Will submit an updated patch. Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org