-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/24/2010 11:44 AM, Michael Matz wrote:
Hi,
On Wed, 24 Feb 2010, Jeff Mahoney wrote:
Agreed. A warning would have been nice, though. I definitely wouldn't have tracked that one down to a missing align statement without your help.
Any suggestion what the warning should say? We probably can cook something up, though I fear that it might trigger too often to be appreciated by users :)
How about: Warning: struct xyz declared with multiple alignment constraints, using the largest (#) The documentation can explain more. Warning: struct xyz declared with multiple alignment constraints. GCC will align structures using the largest alignment specified. The default alignment is 32 bytes. When smaller alignment constraints are specified with the __aligned__(<size>) attribute, this alignment is used. If there are mixed __aligned__ attributes, or if there is a declaration left using the default, this may cause issues with code that depends on the structures being aligned to one of the smaller values. What "normal" scenarios would cause this to trigger? If they're frequent then you might be right about it triggering too often. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAkuFWgsACgkQLPWxlyuTD7J2+gCePcsYnQn3SZ+J92XcO2V6d3vI P3IAoKiBSTgCjX+8M/PrNbEUXydezN52 =2IN4 -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org