On Mon, Apr 27, Michal Marek wrote:
Jan Blunck napsal(a):
On Fri, Apr 24, Jan Blunck wrote:
Is it really necessary to replace the spec file generation in tar-up.sh by a perl version called mkspec? I personally learned to hate perl. Additionally to my personal dislikes this introduces the first perl script that is necessary to build our kernel package.
Is there any reason why we can't live with a shell version as we did before?
$ git show 09cf8debcb153c02c366f20e07926dbf9a58f9d9 | diffstat ... b/rpm/mkspec | 187 ++++++++++++++++++++++ b/scripts/tar-up.sh | 330 ++--------------------------------------
Just because it is smaller in LOC doesn't make something suck less.
$ grep /usr/bin/perl * -l guards mkspec modversions
Yes, I missed that guards is written in perl as well. modversions is only necessary for the kABI stuff.
Besides that mkspec is broken and can't build the Kernel:Vanilla projects anymore since it doesn't honor EXTRAVERSION properly.
You mean that it doesn't paste the -rcX string to the rpm release numbers? That didn't really work anyway. Or what specifically are you missing?
Exactly: -rcX , -g$SHA1, -next-$TIMESTAMP and so on. There are numerous examples. None of my none-standard Kernel: repositories is building anymore. If you are reimplementing something you can at least make sure that you don't break something useful. And that is totally separate issue from the what-language-I-dont-like discussion. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org