Dne 27.11.2013 17:37, Jean Delvare napsal(a):
Hi Michal,
Le Wednesday 13 November 2013 à 15:49 +0100, Michal Marek a écrit : My first testing 10 days ago seemed wrong, however I tested it again today and it worked just fine. So I'm not sure what I did last time, but let's call it working and commit it. If the problem reappears (assuming it was not just my mistake - might as well be) we'll fix it then.
OK. Thanks for testing.
I think you want to split this patch in two parts: the infrastructure itself which should go to the scripts branch and be pulled to all other branches from there, and the actual switch to tar.xz format (in rpm/kernel-source.spec.in) which should be committed to recent branches only.
Definitely, that's the plan.
Overall the code looks great, nice job. Just two comment:
--- a/scripts/tar-up-old.sh +++ b/scripts/tar-up-old.sh @@ -154,7 +154,7 @@ done mkdir -p "$build_dir" if test ! -e "$build_dir/linux-$SRCVERSION.tar.bz2"; then echo "linux-$SRCVERSION.tar.bz2" - get_tarball "$SRCVERSION" "$build_dir" + get_tarball "$SRCVERSION" "tar.bz2" "$build_dir" fi
# list of patches to include.
Can't we get rid of tar-up-old.sh now? Anyone still using it?
It's needed for SLES10 and SLES9. BTW, you are supposed to always run scripts/tar-up.sh, it hands over to tar-up-old.sh when needed.
+ if test -n "$force_suffix"; then + suffixes=("$force_suffix") + else + suffixes=(tar.xz tar.bz2) + fi
If "suffixes" is supposed to be an array then it should have been declared as such with "local -a". But given that you are never accessing it by index, and items will never contain a space, I think you could make it a simple string. That will be easier and probably slightly faster, as the code can then be simplified to:
local ... suffixes=$2 ... suffix
... test -z "$suffixes" && suffixes="tar.xz tar.bz2" ... for suffix in $suffixes; do
OK, I'll change that. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org