On Thursday 10 December 2009 01:54:58 Jeff Mahoney wrote:
In going through the openSUSE kernel bug queue, I ran across one against kernel-docs. The spec file for that package is... entertaining. It starts off by doing a cp -a /usr/src/linux* into the build dir. That might've been a good idea at one point, but it's hardly one anymore.
I propose that we make kernel-docs a linked package to the kernel-source package and BuildRequires the kernel-source package. The documentation can be generated with a make -C $SRC O=$PWD instead, negating the need to copy _anything_. Making it a linked package means that the version numbers get set automatically by mkspec. Right now, the kernel-docs package is version 2.6.3 but built against whatever kernel-source is in the repo.
definitely a good idea. I was part of those that started this package and at that time I did the copying around of the sources to be able to patch things whenever "make docs" broke because some source file processor was not able to grok the source code anymore. If this is more visible to the kernel hackers (which I assume it will by being in the same source directory) these issues can be fixed directly instead of hacking around "postmortem" ... -- with kind regards (mit freundlichem Grinsen), Ruediger Oertel (ro@novell.com,ro@suse.de,bugfinder@t-online.de) ---------------------------------------------------------------------- Linux MacBookRudi 2.6.32-3-desktop #1 SMP PREEMPT 2009-12-04 00:41:46 +0100 x86_64 Key fingerprint = 17DC 6553 86A7 384B 53C5 CA5C 3CE4 F2E7 23F2 B417 SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org