![](https://seccdn.libravatar.org/avatar/d08c8785b44c2e795ebed85a2afc7cc4.jpg?s=120&d=mm&r=g)
2015-01-23 20:54 GMT+03:00 Andreas Färber
Am 21.01.2015 um 16:32 schrieb Jeff Mahoney:
On 1/16/15 1:36 PM, Matwey V. Kornilov wrote:
From: "Matwey V. Kornilov"
Signed-off-by: Matwey V. Kornilov
I have no problem accepting this, but I haven't seen anyone respond with a review yet.
It's a bit hard to review a patch this large... I did spot a number of missing options:
For instance, LS1 is Cortex-A7, so should be enabled for both.
Sun9i is Cortex-A15/-A7, so should be enabled for both. Same for PINCTRL_SUN9I_A80.
Exynos4412 is enabled, so let's enable 4415 for default. Guessing that'll still be a Cortex-A9.
Not sure about Meson8, I haven't heard of a 64-bit chip from Amlogic, so it's probably ARMv7, too. And since we do have Meson6 enabled, I2C_MESON should get enabled.
Any reason not to enable STiH407 when 415 and 416 are enabled?
While at it, isn't CSR Sirf Cortex-A9 and should be enabled in default?
Also, it looks like some net additions could be =m rather than unset, also MTD_NAND_SUNXI.
All of this because I thought it was better to disable features not utilized by our JeOSes to save some kernel size.
OF_SELFTEST not set -> OF_UNITTEST=y surprises me.
It is probably by mistake, here I just wanted to enable OF_OVERLAY, OF_RESOLVE and OF_DYNAMIC
Did you intentionally not enable SERIAL_8250_OMAP? Is that the one with two alternative drivers?
We currently use SERIAL_OMAP, SERIAL_8250_OMAP is the alternative one. Migration to it will bring lot of pain with JeOSes because the driver uses ttyS instead of ttyO. So, I would like to make such a migration later when sure that the other parts of kernel are ok. -- With best regards, Matwey V. Kornilov http://blog.matwey.name xmpp://0x2207@jabber.ru -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org