Hi Michal, Le Monday 11 November 2013 à 11:05 +0100, Michal Marek a écrit :
On 8.11.2013 14:19, Jean Delvare wrote:
Thus I'd like to add support for xz-compressed files to sequence-patch for a starter. I'm attaching the patch. It's only tested locally (outside of the suse network) so not all code paths were tested. Some more testing and review would be welcome.
I tested it with our mirror that only has linux-*.bz2 and it still works. I'll change it now to also fetch *.xz.
Thanks, this will start the transition period nicely. Ultimately it would be great if we could stop fetching *.bz2 and only use *.xz. But I have to admit I'm not too sure how to achieve that. Switching only new products to use *.xz would require adding some magic to several of our scripts. Switching them all would be even more work with a risk of regression. None of these options is really appealing, but maybe I'm missing an easier path.
--- a/scripts/sequence-patch.sh +++ b/scripts/sequence-patch.sh @@ -135,6 +135,7 @@ apply_patches() { case $PATCH in *.gz) exec < <(gzip -cd $PATCH) ;; *.bz2) exec < <(bzip2 -cd $PATCH) ;; + *.xz) exec < <(xz -cd $PATCH) ;; *) exec < $PATCH ;; esac patch -d $PATCH_DIR --backup --prefix=$backup_dir/ -p1 -E $fuzz \ @@ -149,6 +150,7 @@ apply_patches() { case $PATCH in *.gz) exec < <(gzip -cd $PATCH) ;; *.bz2) exec < <(bzip2 -cd $PATCH) ;; + *.xz) exec < <(xz -cd $PATCH) ;; *) exec < $PATCH ;; esac
I'd just drop support for compressed patches. We never had them in the tree.
Fine with me, I'll do that in a separate patch. Thanks for the review and testing, -- Jean Delvare Suse L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org