On Tue, Nov 24, 2015 at 06:26:36AM -0700, Jan Beulich wrote:
On 24.11.15 at 13:51, <mkubecek@suse.cz> wrote: I accidentally noticed a really strange patch in our master branch and then found it also in other branches, e.g. SLE12 (but not in e.g. SLE11-SP4):
patches.fixes/bridge-module-get-put.patch
The purpose of this patch is to disallow unloading bridge module if there is at least one bridge device.
We've had such a discussion before (a few years back I guess).
This causes various problems:
1. It deviates from upstream kernel behaviour which allows unloading the module (removing all existing bridge devices). There should be a good reason for such difference in behaviour and I don't find the reasoning in bsc#267651 convincing.
Well, both originally and when the second round of discussions happened, others seem to have agreed that the behavior the patch tries to fix is bad. That said, ...
My opinion is the same as https://lists.linuxfoundation.org/pipermail/bridge/2011-April/007634.html i.e. if something is wrong, it's the behaviour of "modprobe -r" (and, of course, people running it without knowing what it does).
Does anyone have a strong argument for keeping (and fixing) the patch?
... I don't mind the patch being dropped as long as it's not going to be me to have to deal with possible fallout.
I can promise to handle bug reports about this (if any). Given that we don't have the patch in SLE11 SP2 through SP4, I believe they shouldn't be too frequent. Michal Kubeček -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org