On Thu, Nov 12, 2009 at 08:13:34PM +0100, Rafael J. Wysocki wrote:
On Thursday 12 November 2009, Michal Marek wrote:
Hi,
I added the kabi files from the 11.2 goldmaster kernel to the repository, so from now on, every kabi change will be caught by the build-time checks. Unfortunately there were already some changes in the repo that did change the kabi signatures: patches.drivers/alsa-hda-reboot-notify, already reverted by Takashi, "dm snapshot: use unsigned integer chunk size" and "PM / yenta: Split resume into early and late parts (rev. 4)", both came via the 2.6.31.6 update. I reverted the latter two for now, so that the builds don't start failing suddenly, but I guess that's not the right option esp. for the yenta fix. Rafael, you wrote the patch, can you comment here? The problem is the new member in struct pcmci_socket. Can we * just ignore this change (in worst case, some drivers will need a rebuild for the next kernel update)
I'd choose this option.
* hide the change from genksyms (do external drivers ever need to allocate the structure themselves?)
That I don't know. Greg?
I don't know of any that would. I vote for the "ignore this change" as it came from upstream, and any external driver would have to handle it anyway. And note that there almost are no external drivers anymore, with the exception of ati and nvidia, so that reduces the chance of a problem even more. And anyway, I didn't think we were doing ABI stuff for opensuse kernels, is this a change? thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org