https://bugzilla.suse.com/show_bug.cgi?id=1216841 https://bugzilla.suse.com/show_bug.cgi?id=1216841#c2 --- Comment #2 from Guillaume GARDET <guillaume.gardet@arm.com> --- (In reply to WEI GAO from comment #0)

I clone issue to 15sp6 since i found this issue not exist on Tumbleweed now, but still exist on latest result for 15sp6, see following openqa job, i suppose some fix need backport to sle15sp6.

https://openqa.suse.de/tests/12752058#step/fanotify16/7

+++ This bug was initially created as a clone of Bug #1199618 +++

Sorry, but this still happens on current Tumbleweed: https://openqa.opensuse.org/tests/3696567#step/fanotify16/7 -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.suse.com/show_bug.cgi?id=1216841 Radoslav Tzvetkov <rtsvetkov@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High CC| |rtsvetkov@suse.com -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.suse.com/show_bug.cgi?id=1216841 https://bugzilla.suse.com/show_bug.cgi?id=1216841#c5 WEI GAO <wegao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(wegao@suse.com) | --- Comment #5 from WEI GAO <wegao@suse.com> --- (In reply to Takashi Iwai from comment #1)

What does this failure mean, more exactly?

The test code try to call fanotify_init with flags=FAN_REPORT_DFID_NAME_TARGET, event_f_flags=O_RDONLY on ext2 filesystem, the system call failed, return errno code is not ENOSYS or EINVAL but EXDEV. The test logic think EXDEV error code is unexpected. test log: tst_test.c:1650: TINFO: === Testing on ext2 === tst_test.c:1105: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts='' mke2fs 1.47.0 (5-Feb-2023) tst_test.c:1119: TINFO: Mounting /dev/loop0 to /tmp/LTP_fanSw9CmB/fs_mnt fstyp=ext2 flags=0 fanotify.h:168: TBROK: fanotify_mark (3, FAN_MARK_ADD, ..., AT_FDCWD, ".") failed: EXDEV (18)<<<< test case code: fanotify_init_flags_supported_on_fs(FAN_REPORT_DFID_NAME_TARGET, MOUNT_PATH); static inline int fanotify_init_flags_supported_on_fs(unsigned int flags, const char *fname) { int fd; int rval = 0; fd = fanotify_init(flags, O_RDONLY); if (fd < 0) { if (errno == ENOSYS) tst_brk(TCONF, "fanotify not configured in kernel"); if (errno == EINVAL) return -1; tst_brk(TBROK | TERRNO, "fanotify_init() failed"); <<<<<< } BTW: i suppose 15sp6 use following build link? https://build.suse.de/package/show/Devel:Kernel:SLE15-SP6/kernel-default -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.suse.com/show_bug.cgi?id=1216841 https://bugzilla.suse.com/show_bug.cgi?id=1216841#c7 Jan Kara <jack@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #7 from Jan Kara <jack@suse.com> --- So the first thing to note: fanotify16 test from LTP is passing for me in my test VM with SLE15-SP6 kernel (as well as current upstream kernel) and always has been as far as I remember. The EXDEV failure seems to be some artifact in how openQA runs this test. Also there were no recent changes to fanotify or ext4 driver (which is used for ext2 test) that I'd be aware of that could cause this error or appear / disappear... Now to the EXDEV error from fanotify_mark(2) itself. This error can be generated by fanotify_mark() in exactly one place and that is fanotify_test_fsid() if f_fsid as reported by statfs(2) for the path passed to fanotify_mark(2) is different from f_fsid reported by statfs(2) for the root of the filesystem containing the path. The only filesystem where these two fsid's could differ is btrfs (with subvolumes) so it really doesn't make sense that the test would fail with this error for ext2... checking the details of the fanotify16 test ... oh, the fanotify_mark() call that is failing is before we actually get to testing the real functionality in fanotify_events_supported_by_kernel() where we do (already did const propagation ;): fanotify_mark(fd, FAN_MARK_ADD, FAN_RENAME, AT_FDCWD, ".") so *if* the LTP is run so that CWD is actually in a subvolume of btrfs filesystem, then indeed this would be failing. Now we are planning to lift this limitation from btrfs but it didn't happen yet so I suspect what has likely happened is that in Tumbleweed openQA started to execute LTP with different CWD and so the test started to pass. In either case this is a bug in fanotify16 test. I'll take it to upstream so that this is fixed but wrt SLE15-SP6, I'd say we can safely ignore this. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.suse.com/show_bug.cgi?id=1216841 https://bugzilla.suse.com/show_bug.cgi?id=1216841#c8 --- Comment #8 from Jan Kara <jack@suse.com> --- Created attachment 871005 --> https://bugzilla.suse.com/attachment.cgi?id=871005&action=edit [PATCH] fanotify: Fix broken tests due to fanotify_events_supported_by_kernel() Here's a patch I've just submitted to LTP upstream and which should fix the failure in openQA. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.suse.com/show_bug.cgi?id=1216841 https://bugzilla.suse.com/show_bug.cgi?id=1216841#c9 Petr Vorel <petr.vorel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |INVALID --- Comment #9 from Petr Vorel <petr.vorel@suse.com> --- Jan's fanotify16 fix has been merged. It should be fixed on the next scheduled build 20231204. Thanks! https://github.com/linux-test-project/ltp/commit/259464c420c3b0d79b2a84f05a1... (part of more changes: https://lore.kernel.org/ltp/20231130093533.10036-1-jack@suse.cz/) Closing as invalid (it was a bug in the test). -- You are receiving this mail because: You are on the CC list for the bug.