FYI, I've added the below-listed rpm macros to kde4-filesystem to KDE:KDE4:Factory:Desktop, as already discussed before. You are not forced to use them, but it's rather convenient :). Dirk said he has a magic script also for changing existing .spec files (where is it?).
%_kde4_prefix %{_prefix} %_kde4_bindir %{_bindir} %_kde4_libdir %{_libdir} %_kde4_modules %{_libdir}/kde4 %_kde4_libexecdir %{_libexecdir}/kde4 %_kde4_sysconfdir %{_sysconfdir} %_kde4_sharedir %{_prefix}/share/kde4 %_kde4_appsdir %{_kde4_sharedir}/apps %_kde4_configdir %{_kde4_sharedir}/config %_kde4_applicationsdir %{_kde4_prefix}/share/applications/kde4 %_kde4_servicesdir %{_kde4_sharedir}/services %_kde4_servicetypes %{_kde4_sharedir}/servicetypes %_kde4_iconsdir %{_kde4_prefix}/share/icons %_kde4_docdir %{_kde4_prefix}/share/doc %_kde4_sbindir %{_kde4_prefix}/sbin %_kde4_includedir %{_kde4_prefix}/include
In 200907311529.54677.l.lunak@suse.cz, Lubos Lunak wrote:
%_kde4_prefix %{_prefix} %_kde4_bindir %{_bindir} %_kde4_libdir %{_libdir} %_kde4_modules %{_libdir}/kde4 %_kde4_libexecdir %{_libexecdir}/kde4 %_kde4_sysconfdir %{_sysconfdir} %_kde4_sharedir %{_prefix}/share/kde4
Should this be: %_kde4_sharedir %{_kde4_prefix}/share/kde4
It seems a bit inconsistent with the rest.
%_kde4_appsdir %{_kde4_sharedir}/apps %_kde4_configdir %{_kde4_sharedir}/config %_kde4_applicationsdir %{_kde4_prefix}/share/applications/kde4
Or, should this be: %_kde4_applicationsdir %{_prefix}/share/applications/kde4
Under the assumption that the above your %_kde4_sharedir was correct, this seemed inconsistent with it.
On Friday 31 of July 2009, Boyd Stephen Smith Jr. wrote:
In 200907311529.54677.l.lunak@suse.cz, Lubos Lunak wrote:
%_kde4_prefix %{_prefix} %_kde4_bindir %{_bindir} %_kde4_libdir %{_libdir} %_kde4_modules %{_libdir}/kde4 %_kde4_libexecdir %{_libexecdir}/kde4 %_kde4_sysconfdir %{_sysconfdir} %_kde4_sharedir %{_prefix}/share/kde4
Should this be: %_kde4_sharedir %{_kde4_prefix}/share/kde4
It seems a bit inconsistent with the rest.
Oops, right, fixed.
On Friday 31 July 2009 18:38:25 Lubos Lunak wrote:
On Friday 31 of July 2009, Boyd Stephen Smith Jr. wrote:
In 200907311529.54677.l.lunak@suse.cz, Lubos Lunak wrote:
%_kde4_libexecdir %{_libexecdir}/kde4
Is this the correct assumption ? I noticed that with kdebase4-workspace we have a number of applications that are placed in the directory /usr/lib/kde4/libexec.
If this is correct, then maybe it would be easier to change the above into :
%_kde4_libexecdir %{_libexecdir}/kde4/libexec
Regards
Raymond
On Sunday 09 of August 2009, Raymond Wooninck wrote:
On Friday 31 July 2009 18:38:25 Lubos Lunak wrote:
On Friday 31 of July 2009, Boyd Stephen Smith Jr. wrote:
In 200907311529.54677.l.lunak@suse.cz, Lubos Lunak wrote:
%_kde4_libexecdir %{_libexecdir}/kde4
Is this the correct assumption ? I noticed that with kdebase4-workspace we have a number of applications that are placed in the directory /usr/lib/kde4/libexec.
Good catch, it's a mistake. I will fix it in the evening.
If this is correct, then maybe it would be easier to change the above into :
%_kde4_libexecdir %{_libexecdir}/kde4/libexec
The problem above is a left-over from an attempt to move KDE's libexec stuff to _libexecdir , which on 11.2 is always under /usr/lib, even on 64bit. I gave up on that though, as it'd require further splitting of kdelibs4, otherwise it wouldn't be possible to have both 32bit and 64bit kdelibs installed.
On Friday 31 July 2009, Lubos Lunak wrote:
to use them, but it's rather convenient :). Dirk said he has a magic script also for changing existing .spec files (where is it?).
attached (from my suse home/bin), please send modifications back or check them into some source control somewhere :). I've not yet updated it to those new macros, if you can do that I'll run it with the next snapshot update (please don't do it now because of 4.3.0 prep).
Greetings, Dirk
On Monday 03 of August 2009, Dirk Müller wrote:
On Friday 31 July 2009, Lubos Lunak wrote:
to use them, but it's rather convenient :). Dirk said he has a magic script also for changing existing .spec files (where is it?).
attached (from my suse home/bin), please send modifications back or check them into some source control somewhere :). I've not yet updated it to those new macros, if you can do that I'll run it with the next snapshot update (please don't do it now because of 4.3.0 prep).
Attached. It also needs the attached kde4-filesystem changes.
The ldconfig change there was broken with multiline %post scripts (e.g. kdebase4-workspace), I hope I got the fix for that right.
And I have one question - is there any specific reason for using the %_kde4_macro format over %{_kde4_macro} other than personal preference? The latter looks more readable to me, especially now with %files being just <macro>/<short_path>, where the {} make it easier to visually separate.
On Wednesday 05 August 2009, Lubos Lunak wrote:
Attached. It also needs the attached kde4-filesystem changes.
thanks, added to unstable now, lets see..
And I have one question - is there any specific reason for using the %_kde4_macro format over %{_kde4_macro} other than personal preference?
No, just personal preference.
The latter looks more readable to me, especially now with %files being just <macro>/<short_path>, where the {} make it easier to visually separate.
I have colorful syntax highlighting for that :)
Personally I don't care. without {} the macro name does not terminate properly sometimes (if an alphanumeric character is immediately following), so always using the brackets makes it more consistent (but also more verbose).
Greetings, Dirk
-
Boyd Stephen Smith Jr. -
Dirk Müller -
Lubos Lunak -
Raymond Wooninck