8 Jul
2017
8 Jul
'17
20:58
Hi heroes,
I have made a pull request for the new theme/skin of wiki. You can find
some screenshots in the description.
https://github.com/openSUSE/wiki/pull/9
The theme itself is based on Bootstrap and responsive. However, some
page content, especially wide tables will break the layout. I will work
on a solution later.
Would like to hear feedback from you!
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org
1 Aug
1 Aug
01:55
Hello,
Am Samstag, 8. Juli 2017, 14:58:51 CEST schrieb Guo Yunhe:
I have made a pull request for the new theme/skin of
wiki. You can
find some screenshots in the description.
https://github.com/openSUSE/wiki/pull/9
For those not following the wiki pull requests on github - the new skin
survived my review with some quite small changes - I remember reviews
where someone didn't like me anymore afterwards ;-)
Guo, thanks for your work on the new skin and for fixing the issues I
found!
Screenshots are nice, but seeing it in action is even better -
https://en-test.opensuse.org/ has the new skin since 5 minutes :-)
The theme itself is based on Bootstrap and responsive.
However, some
page content, especially wide tables will break the layout. I will
work on a solution later.
I made you admin on en-test.o.o so that you can easily do CSS changes
using https://en-test.opensuse.org/MediaWiki:Common.css
You'll still need to merge the final CSS into the skin's CSS files, but
for testing and adjusting it's easier if you can edit it directly in the
wiki.
You'll notice that Mediawiki:Common.css already contains some CSS - feel
free to adjust it as needed, also with the goal to move it to the skin's
CSS file so that it's available in all wikis.
If you are unsure where/how a CSS class is used, you can abuse ;-)
Special:Replacetext to search for the class name. It searches in the
wiki "source" text, while the "normal" search searches in the rendered
wiki content and therefore won't find CSS class names.
Would like to hear feedback from you!
General impression: looks great :-)
I noticed that the "head area" (search/login, Page/Discussion switch,
View/Edit/History/... buttons take up much more space than in the Bento
theme. Maybe you can make this area a bit more compact, for example by
merging Portal/Discussion and search/login _or_ View/Edit/... into one
row.
Another detail is that the sidebar gets hidden if the window isn't wide
enough. The sidebar is less important than the page content, but it's
still useful even on mobile devices, so it would be nice if you can keep
it somewhere (collapsed and/or on the bottom of the page).
When shrinking the window even more, the View/Edit/History/... also gets
hidden. I'm not sure if someone wants to edit the wiki on his/her mobile
phone, but it would still be good to make this possible, so please make
sure this also stays available somehow. (Maybe a "Page actions" dropdown
next to Page/Discussion?)
Regards,
Christian Boltz
--
Eine Frage, wann wird denn wohl die KDE 3.1 über den
YOU-Service angeboten werden?
Gar niemals. YOU ist fuer BugFixes, nicht um welche
ins
System einzufuegen. [Peter Wiersig in suse-linux]
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org
07:02
Hello,
Am Montag, 31. Juli 2017, 19:55:25 CEST schrieb Christian Boltz:
Screenshots are nice, but seeing it in action is even
better -
https://en-test.opensuse.org/ has the new skin since 5 minutes
I just noticed that the login form doesn't work - it points to the
microfocus login server instead of /ICSLogin/. Sorry for overlooking
this in the code review!
Workaround: login on another wiki (for example en.opensuse.org) and then
go to en-test.o.o and get logged in automatically.
Guo, will you work on this (just steal the login form from the bento
skin) or should I have a look at it?
BTW: bonus points if the username input field gets focused when
displaying the login form ;-)
Regards,
Christian Boltz
--
There is a limit to the value of statistics.
After all, there are lies, damn lies, and statistics.
[Richard Brown in opensuse-project]
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org
4 Aug
4 Aug
03:00
Hello,
Am Dienstag, 1. August 2017, 01:02:49 CEST schrieb Christian Boltz:
Am Montag, 31. Juli 2017, 19:55:25 CEST schrieb
Christian Boltz:
I just fixed this - and also deployed the more compact page header on
en-test.o.o.
Screenshots are nice, but seeing it in action is
even better -
https://en-test.opensuse.org/ has the new skin since 5 minutes
I just noticed that the login form doesn't work - it points to the
microfocus login server instead of /ICSLogin/. Sorry for overlooking
this in the code review! BTW: bonus points if the username input field gets
focused when
displaying the login form ;-)
That's still on my wishlist ;-)
I already mentioned some days ago that the sidebar and the view/edit/
history buttons vanish if the window is too small. A fix for this would
still be welcome.
Another small detail: the dropdown for more actions (delete, move,
watch, change protection) only contains items when logged in. If you are
not logged in, clicking the button opens an empty submenu (which looks
"broken" to the average user). It would be better to hide the button
when not logged in.
A funny, but still annoying detail is that the openSUSE logo in the top
menu bar gets squeezed when resizing the window - see the attached gif
that includes screenshots (taken in Firefox) from 3 different window
widths.
Oh, BTW - did you ever test the page with javascript switched off?
The random (really!) signature is a good description of the result...
That all said - tell me if you prefer bugreports on github instead of a
mail like this one ;-)
Regards,
Christian Boltz
--
I believe the technical term is "Oops!"
1 Aug
1 Aug
19:13
Op maandag 31 juli 2017 19:55:25 CEST schreef Christian Boltz:
Hello,
Am Samstag, 8. Juli 2017, 14:58:51 CEST schrieb Guo Yunhe:
Guys, that is some awesome job. Love it. Thank you very much.
--
Gertjan Lettink, a.k.a. Knurpht
openSUSE Board Member
openSUSE Forums Team
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org
I have made a pull request for the new theme/skin
of wiki. You can
find some screenshots in the description.
https://github.com/openSUSE/wiki/pull/9
For those not following the wiki pull requests on github - the new skin
survived my review with some quite small changes - I remember reviews
where someone didn't like me anymore afterwards ;-)
Guo, thanks for your work on the new skin and for fixing the issues I
found!
Screenshots are nice, but seeing it in action is even better -
https://en-test.opensuse.org/ has the new skin since 5 minutes :-)
The theme itself is based on Bootstrap and
responsive. However, some
page content, especially wide tables will break the layout. I will
work on a solution later.
General impression: looks great :-)
Regards,
Christian Boltz
2 Aug
2 Aug
15:46
Knurpht - Gertjan Lettink composed on 2017-08-01 13:13 (UTC+0200):
...
Christian Boltz composed:
...
Guo Yunhe composed:
...
> Guo, thanks for your work on the new skin and for
fixing the issues I
> found!
> Screenshots are nice, but seeing it in action is
even better -
> https://en-test.opensuse.org/ has the new skin since 5 minutes :-)
> > The theme itself is based on Bootstrap and
responsive. However, some
> > page content, especially wide tables will break the layout. I will
> > work on a solution later.
> General impression: looks great :-)
Guys, that is some awesome job. Love it. Thank you
very much.
I'm not that impressed. The web already has too much gray text on gray
backgrounds. Please change all the gray text to black, especially that which is
not on a white background. The green on green navbar links, though pretty,
suffer quite poor legibility. The #005849 links on gray #mw-content-text
background could stand to be darker green too, #003010 or thereabouts. To me,
having fun follows from high legibility.
--
"The wise are known for their understanding, and pleasant
words are persuasive." Proverbs 16:21 (New Living Translation)
Team OS/2 ** Reg. Linux User #211409 ** a11y rocks!
Felix Miata *** http://fm.no-ip.com/
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org
1515
days inactive
1541
days old
5 comments
4 participants
participants (4)
-
Christian Boltz -
Felix Miata -
Guo Yunhe -
Knurpht - Gertjan Lettink