Hello,
Am Samstag, 8. Juli 2017, 14:58:51 CEST schrieb Guo Yunhe:
I have made a pull request for the new theme/skin of
wiki. You can
find some screenshots in the description.
https://github.com/openSUSE/wiki/pull/9
For those not following the wiki pull requests on github - the new skin
survived my review with some quite small changes - I remember reviews
where someone didn't like me anymore afterwards ;-)
Guo, thanks for your work on the new skin and for fixing the issues I
found!
Screenshots are nice, but seeing it in action is even better -
https://en-test.opensuse.org/ has the new skin since 5 minutes :-)
The theme itself is based on Bootstrap and responsive.
However, some
page content, especially wide tables will break the layout. I will
work on a solution later.
I made you admin on en-test.o.o so that you can easily do CSS changes
using
https://en-test.opensuse.org/MediaWiki:Common.css
You'll still need to merge the final CSS into the skin's CSS files, but
for testing and adjusting it's easier if you can edit it directly in the
wiki.
You'll notice that Mediawiki:Common.css already contains some CSS - feel
free to adjust it as needed, also with the goal to move it to the skin's
CSS file so that it's available in all wikis.
If you are unsure where/how a CSS class is used, you can abuse ;-)
Special:Replacetext to search for the class name. It searches in the
wiki "source" text, while the "normal" search searches in the rendered
wiki content and therefore won't find CSS class names.
Would like to hear feedback from you!
General impression: looks great :-)
I noticed that the "head area" (search/login, Page/Discussion switch,
View/Edit/History/... buttons take up much more space than in the Bento
theme. Maybe you can make this area a bit more compact, for example by
merging Portal/Discussion and search/login _or_ View/Edit/... into one
row.
Another detail is that the sidebar gets hidden if the window isn't wide
enough. The sidebar is less important than the page content, but it's
still useful even on mobile devices, so it would be nice if you can keep
it somewhere (collapsed and/or on the bottom of the page).
When shrinking the window even more, the View/Edit/History/... also gets
hidden. I'm not sure if someone wants to edit the wiki on his/her mobile
phone, but it would still be good to make this possible, so please make
sure this also stays available somehow. (Maybe a "Page actions" dropdown
next to Page/Discussion?)
Regards,
Christian Boltz
--
Eine Frage, wann wird denn wohl die KDE 3.1 über den
YOU-Service angeboten werden?
Gar niemals. YOU ist fuer BugFixes, nicht um welche
ins
System einzufuegen. [Peter Wiersig in suse-linux]
--
To unsubscribe, e-mail: heroes+unsubscribe(a)opensuse.org
To contact the owner, e-mail: heroes+owner(a)opensuse.org