[opensuse-gnome] Tagging yelp patches
Hi, I've tried to tag yelp patches, but some help would be welcome for a few patches: + yelp-desktop.patch Changes the Comment key in the desktop file to be a GenenericName key. We're doing this in many many modules. Does anyone know why? + yelp-suse-20060319.patch It's a huge patch, I'm not quite sure what it's doing. But I know it doesn't apply cleanly anymore. It has been modified quite a few times according to the changelog. hpj, do you have more details? + yelp-2.13.5-use-susehelp.patch This links gnome-help to susehelp instead of yelp. I'm not quite sure why it would be needed. Looking at susehelp, the only relevant use case would be when $DOC_HOST is not localhost. However, I'm not aware of anything calling gnome-help (I believe yelp is generally directly called). + yelp-2.14.0-process-suse-manuals.patch Doesn't apply any more and seems to depend on yelp-suse-20060319.patch. Looks like the patch adds doc from /usr/share/susehelp/meta/. I guess we want to keep that? + yelp-2.18.1-empty-doc-crash.patch Doesn't apply any more right now. I'm trying to reproduce the crash, but I can't. Does anyone remember what kind of empty doc it was? (ie, just an empty file, or some docbook with a basic structure but no content, etc.) (There were two other patches, I've upstreamed one and killed the other one) Thanks, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
On Mon, 2008-03-17 at 17:54 +0100, Vincent Untz wrote:
Hi,
I've tried to tag yelp patches, but some help would be welcome for a few patches:
+ yelp-desktop.patch Changes the Comment key in the desktop file to be a GenenericName key. We're doing this in many many modules. Does anyone know why?
I think this was a hack for the app browser way back, but now this patch seems to have no effect (at least on factory that is not the generic name used) and we have a proper GenericName for this now, so I think it can be dropped.
+ yelp-suse-20060319.patch It's a huge patch, I'm not quite sure what it's doing. But I know it doesn't apply cleanly anymore. It has been modified quite a few times according to the changelog. hpj, do you have more details?
+ yelp-2.13.5-use-susehelp.patch This links gnome-help to susehelp instead of yelp. I'm not quite sure why it would be needed. Looking at susehelp, the only relevant use case would be when $DOC_HOST is not localhost. However, I'm not aware of anything calling gnome-help (I believe yelp is generally directly called).
This calls the desktop specific help app where necessary - ie on KDE running gimp you will get khelpcenter. On GNOME running k3b you will get yelp. -JP -- JP Rosevear <jpr@novell.com> Novell, Inc. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
Le lundi 17 mars 2008, à 13:40 -0400, JP Rosevear a écrit :
On Mon, 2008-03-17 at 17:54 +0100, Vincent Untz wrote:
+ yelp-2.13.5-use-susehelp.patch This links gnome-help to susehelp instead of yelp. I'm not quite sure why it would be needed. Looking at susehelp, the only relevant use case would be when $DOC_HOST is not localhost. However, I'm not aware of anything calling gnome-help (I believe yelp is generally directly called).
This calls the desktop specific help app where necessary - ie on KDE running gimp you will get khelpcenter. On GNOME running k3b you will get yelp.
Nod. In fact, I didn't look closely enough: the URI handlers related to the help system are calling gnome-help and not yelp, so we need to keep it. Thanks, Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
On Mon, 2008-03-17 at 19:28 +0100, Vincent Untz wrote:
Le lundi 17 mars 2008, à 13:40 -0400, JP Rosevear a écrit :
On Mon, 2008-03-17 at 17:54 +0100, Vincent Untz wrote:
+ yelp-2.13.5-use-susehelp.patch This links gnome-help to susehelp instead of yelp. I'm not quite sure why it would be needed. Looking at susehelp, the only relevant use case would be when $DOC_HOST is not localhost. However, I'm not aware of anything calling gnome-help (I believe yelp is generally directly called).
This calls the desktop specific help app where necessary - ie on KDE running gimp you will get khelpcenter. On GNOME running k3b you will get yelp.
Nod. In fact, I didn't look closely enough: the URI handlers related to the help system are calling gnome-help and not yelp, so we need to keep it.
we have a patch in evince which I'm talking about with upstream, that replaces the gnome-help call with "gnome-open ghelp://evince", but this does not seem to work, so any idea why this patch? -- Rodrigo Moya <rodrigo@novell.com> -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
On Mon, 2008-03-17 at 17:54 +0100, Vincent Untz wrote:
+ yelp-suse-20060319.patch It's a huge patch, I'm not quite sure what it's doing. But I know it doesn't apply cleanly anymore. It has been modified quite a few times according to the changelog. hpj, do you have more details?
+ yelp-2.14.0-process-suse-manuals.patch Doesn't apply any more and seems to depend on yelp-suse-20060319.patch. Looks like the patch adds doc from /usr/share/susehelp/meta/. I guess we want to keep that?
The first patch has been handed down for generations (the date in the file name has changed at least once). It contains code and XSLT related to branding, combined with bug fixes and search path adaptations. The other one adds SUSE-specific manuals to the index. I strongly dislike these patches and think that if we can drop them, we should. Better to start from scratch, especially now that nothing applies anymore. Then we can see what problems show up and address those in a sane manner. We'll probably have to add at least the SUSE manuals one back, though maybe we can work with the documentation team to get a system that works out of the box.
+ yelp-2.18.1-empty-doc-crash.patch Doesn't apply any more right now. I'm trying to reproduce the crash, but I can't. Does anyone remember what kind of empty doc it was? (ie, just an empty file, or some docbook with a basic structure but no content, etc.)
I seem to remember it being a no content issue. It's hard to say if we need it anymore though, since the yast code changed so much. I'd say if we're upgrading yelp, just drop it. -- Hans Petter -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
participants (4)
-
Hans Petter Jansson -
JP Rosevear -
Rodrigo Moya -
Vincent Untz