[opensuse-gnome] RFC: how to open the main menu with the logo keys
Hi, I've been working on bug 372423 [1] for a few hours now. I originally thought it wouldn't be too difficult -- yeah, don't laugh, I'm naive ;-) Basically, the bug is about a patch that we have in metacity to open the main menu with the logo keys. The problem is that this does not work well for all keyboard drivers, as the keycode returned when a logo key is pressed can change. And it's hardcoded in the patch. A possibility is to use the xkb definition to know what is the keycode for LWIN/RWIN. Here's my latest comment, proposing something else: == So, I played a bit with all this. It's kind of hard to directly use LWIN/RWIN, and it would make a huge patch for a feature that will never get accepted upstream. Also, note that we disabled this behavior by default in openSUSE, and it's only active in SLED. An alternative approach is to consider that the user who wants to use the window keys to open the main menu won't play with XKB settings. So we can consider that Super_L and Super_R are the window keys. Then, it's just a matter of creating a new gconf key: /apps/metacity/global_keybindings/panel_main_menu_list. This key is a list of strings, and we can put Super_L and Super_R there to get the same results. In terms of openSUSE, it means we just drop the patch and do nothing. In terms of SLED, it means adding a new key in gconf2-branding-openSUSE. I'll ask on the mailing list to get feedback on the idea. == I think it's really much cleaner, simpler, more maintainable, "lots-of-other-words"-er to go this way. Opinions on this? Vincent [1] https://bugzilla.novell.com/show_bug.cgi?id=372423 -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
Le mardi 06 mai 2008, à 12:00 +0200, Vincent Untz a écrit :
Hi,
I've been working on bug 372423 [1] for a few hours now. I originally thought it wouldn't be too difficult -- yeah, don't laugh, I'm naive ;-)
Basically, the bug is about a patch that we have in metacity to open the main menu with the logo keys. The problem is that this does not work well for all keyboard drivers, as the keycode returned when a logo key is pressed can change. And it's hardcoded in the patch. A possibility is to use the xkb definition to know what is the keycode for LWIN/RWIN. Here's my latest comment, proposing something else:
== So, I played a bit with all this. It's kind of hard to directly use LWIN/RWIN, and it would make a huge patch for a feature that will never get accepted upstream.
Also, note that we disabled this behavior by default in openSUSE, and it's only active in SLED.
An alternative approach is to consider that the user who wants to use the window keys to open the main menu won't play with XKB settings. So we can consider that Super_L and Super_R are the window keys. Then, it's just a matter of creating a new gconf key: /apps/metacity/global_keybindings/panel_main_menu_list. This key is a list of strings, and we can put Super_L and Super_R there to get the same results.
In terms of openSUSE, it means we just drop the patch and do nothing. In terms of SLED, it means adding a new key in gconf2-branding-openSUSE. I'll ask on the mailing list to get feedback on the idea. ==
I think it's really much cleaner, simpler, more maintainable, "lots-of-other-words"-er to go this way. Opinions on this?
FWIW, I implemented this. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
participants (1)
-
Vincent Untz