[opensuse-gnome] [PATCH] gnome-settings-daemon: add apport monitoring
Hi, I would like to suggest a patch that adds Apport[1] monitoring to gnome-settings-daemon. The purpose of the patch is to monitor a directory (/var/crash) for incoming Apport crash reports and run a reporting tool (apport-gtk). I implemented this functionality as a gnome-settings-daemon plugin. This patch is just a draft since it has some issues. Please help me to solve those: - I built packages with modified gnome-settings-daemon [2], but for some reason this patched daemon doesn't work as supposed. Although, I tested gsd-apport-manager with a testcase included in my patch and it worked fine. - Does GIO has something similar to inotify's CLOSE_WRITE monitor? I need GIO to handler file-closed-after-write events. As for now I ended up with G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED but it's just not fine to lauch crash checking tool several times. - Does GTK has any out-of-the-box applet notifying methods? I need something similar to libnotify, but I don't think it's worth adding one more dependency to gsd. Hopefully I haven't missed something and I'll appreciate any feedback. [1] http://en.opensuse.org/Interactive_Crash_Analysis https://wiki.ubuntu.com/Apport [2] http://download.opensuse.org/repositories/home:/nderkach:/branches:/home:/ro... -- Regards, Nikolay Derkach
Nikolay, Please also create a bugreport (bugzilla.novell.com) against the GNOME component in 11.1 and attach the patch there. Reply to this thread what the bug number is. Thanks, Magnus On Mon, 2008-07-28 at 00:23 +0400, Nikolay Derkach wrote:
Hi,
I would like to suggest a patch that adds Apport[1] monitoring to gnome-settings-daemon.
The purpose of the patch is to monitor a directory (/var/crash) for incoming Apport crash reports and run a reporting tool (apport-gtk).
I implemented this functionality as a gnome-settings-daemon plugin. This patch is just a draft since it has some issues. Please help me to solve those:
- I built packages with modified gnome-settings-daemon [2], but for some reason this patched daemon doesn't work as supposed. Although, I tested gsd-apport-manager with a testcase included in my patch and it worked fine.
- Does GIO has something similar to inotify's CLOSE_WRITE monitor? I need GIO to handler file-closed-after-write events. As for now I ended up with G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED but it's just not fine to lauch crash checking tool several times.
- Does GTK has any out-of-the-box applet notifying methods? I need something similar to libnotify, but I don't think it's worth adding one more dependency to gsd.
Hopefully I haven't missed something and I'll appreciate any feedback.
[1] http://en.opensuse.org/Interactive_Crash_Analysis https://wiki.ubuntu.com/Apport [2] http://download.opensuse.org/repositories/home:/nderkach:/branches:/home:/ro...
-- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
Hi, Le lundi 28 juillet 2008, à 00:23 +0400, Nikolay Derkach a écrit :
Hi,
I would like to suggest a patch that adds Apport[1] monitoring to gnome-settings-daemon.
The purpose of the patch is to monitor a directory (/var/crash) for incoming Apport crash reports and run a reporting tool (apport-gtk).
Btw, how is your work on apport going?
I implemented this functionality as a gnome-settings-daemon plugin. This patch is just a draft since it has some issues. Please help me to solve those:
- I built packages with modified gnome-settings-daemon [2], but for some reason this patched daemon doesn't work as supposed. Although, I tested gsd-apport-manager with a testcase included in my patch and it worked fine.
Rodrigo might be able to help here?
- Does GIO has something similar to inotify's CLOSE_WRITE monitor? I need GIO to handler file-closed-after-write events. As for now I ended up with G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED but it's just not fine to lauch crash checking tool several times.
Maybe G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT?
- Does GTK has any out-of-the-box applet notifying methods? I need something similar to libnotify, but I don't think it's worth adding one more dependency to gsd.
No, it has no support for libnotify stuff right now. I don't think it's a problem to add the dependency, though. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
On Fri, Aug 1, 2008 at 2:23 PM, Vincent Untz <vuntz@novell.com> wrote:
I would like to suggest a patch that adds Apport[1] monitoring to gnome-settings-daemon.
The purpose of the patch is to monitor a directory (/var/crash) for incoming Apport crash reports and run a reporting tool (apport-gtk).
Btw, how is your work on apport going?
Quiet well. All basic functionality works, though it's still not integrated in Bugzilla (works on localhost only). As soon as I finish KDE apport notifier, I'm going to release a public beta. One can track my progress at http://en.opensuse.org/Interactive_Crash_Analysis
I implemented this functionality as a gnome-settings-daemon plugin. This patch is just a draft since it has some issues. Please help me to solve those:
- I built packages with modified gnome-settings-daemon [2], but for some reason this patched daemon doesn't work as supposed. Although, I tested gsd-apport-manager with a testcase included in my patch and it worked fine.
Rodrigo might be able to help here?
Thanks, I already solved this.
- Does GIO has something similar to inotify's CLOSE_WRITE monitor? I need GIO to handler file-closed-after-write events. As for now I ended up with G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED but it's just not fine to lauch crash checking tool several times.
Maybe G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT?
Nah, it's all the same - crash report check is still done for 3-4 times. But it's not critical anyway.
- Does GTK has any out-of-the-box applet notifying methods? I need something similar to libnotify, but I don't think it's worth adding one more dependency to gsd.
No, it has no support for libnotify stuff right now. I don't think it's a problem to add the dependency, though.
So far I ended up with gtk_status_icon_set_blinking(ta->tray_icon, TRUE) and gtk_status_icon_set_visible(ta->tray_icon, TRUE). I believe it's sufficient. By the way I reported an enhancement in GNOME Bugzilla to track this patch: http://bugzilla.gnome.org/show_bug.cgi?id=545828 -- Regards, Nikolay Derkach -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
Could someone from suse gnome developers add a comment on this: http://bugzilla.gnome.org/show_bug.cgi?id=545828 It's needed to decide whether the patch goes to upstream or to Novell bugzilla. -- Regards, Nikolay Derkach -- To unsubscribe, e-mail: opensuse-gnome+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-gnome+help@opensuse.org
participants (3)
-
Magnus Boman -
Nikolay Derkach -
Vincent Untz