[opensuse-factory] pkg-config 0.28 / minor change (and broken configure checks)
Hi all, I've been looking at some odd build failures in Factory this evening and could mostly pint it down to very poorly written checks in configure. Look for example at: pkg="openssl" verssl=`(pkg-config --modversion $pkg) 2>/dev/null` if [[ "x$verssl" = "x" ]]; then pkg="libssl" verssl=`(pkg-config --modversion $pkg) 2>/dev/null` fi incssl=`(pkg-config --cflags $pkg) 2>/dev/null` libssl=`(pkg-config --libs $pkg) 2>/dev/null` if [[ "x$incssl" != "x" -a "x$libssl" != "x" ]]; then HAVE_OPENSSL=yes OPENSSL_VER="$verssl" OPENSSL_INC="$incssl" OPENSSL_LIB="$libssl" else verssl="no" fi It's visible that pkg-config --cflags $pkg can very well return empty, in case there are no special flags. the 'difference' between pkg-config 0.27 and 0.28 is that up to 0.27, there used to be a bogus space returned... which was fixed in 0.28; of course, now everybody will claim how bad it is to fix bugs which people rely on; this mail was not meant to start anything like this... merely as a heads-up if you run across similar weird checks... The only way forward is to fix the broken checks... Dominique -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
El 22/04/13 20:30, Dimstar / Dominique Leuenberger escribió:
of course, now everybody will claim how bad it is to fix bugs which people rely on;
No, I wont claim that, in fact I would argue against keeping any bug on which people relies on (known as "backwards compatibility") this mail was not meant to start anything like this...
merely as a heads-up if you run across similar weird checks...
The only way forward is to fix the broken checks...
Do you have a list of failing packages to help ? -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Mon, 2013-04-22 at 20:38 -0300, Cristian Rodríguez wrote:
El 22/04/13 20:30, Dimstar / Dominique Leuenberger escribió:
of course, now everybody will claim how bad it is to fix bugs which people rely on;
No, I wont claim that, in fact I would argue against keeping any bug on which people relies on (known as "backwards compatibility")
I should have excluded you from the list of everybody...
this mail was not meant to start anything like this...
merely as a heads-up if you run across similar weird checks...
The only way forward is to fix the broken checks...
Do you have a list of failing packages to help ?
I think the ones in Factory 'failing' I probably got about all (simply look at weird failures in Factory which are around 3 weeks old). the 'tricky' part will be packages that 'silently failed over the detection' of a feature and did not fail... Those are much harder to find. yate was one of the lucky ones having an explicit files section, which made it fail.. a typical /dir/to/files/ would have silently hidden this one for example. Dominique -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (2)
-
Cristian Rodríguez
-
Dimstar / Dominique Leuenberger