[opensuse-factory] SuSEconfig clearance: SuSEconfig.automake
Hi everyone, we are in the process of going through all SuSEconfig scripts to assess their value/impact and to analyze different ways of solving the problems those SuSEconfig scripts address. In many case SuSEconfig.* scripts turn out to just be a "cheap solution". Let's try to reduce the number of SuSEconfig scripts to the absolute minimum! And try to find superior solutions! The first case that I'd like to fix is SuSEconfig.automake, which reads: --- #!/bin/sh cat /usr/share/aclocal/dirlist.d/* >/etc/aclocal_dirlist --- There are only two packages that place files in /usr/share/aclocal/dirlist.d/ -- gnome-filesystem and automake itself. To achieve the same, while getting rid of SuSEconfig.automake, I'd like to propose to move the above-named script to %postinstall / %postuninstall of gnome-filesystem and automake. Comments, criticism, better ideas? Regards Christoph --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, Christoph Thiel schrieb:
Not a "better" idea, just an alternative one: Patch aclocal to read the /usr/share/aclocal/dirlist.d/* files directly. Is that possible? The advantage is that people can still easily add more directories without knowing any details about what %post scripts to use. Maybe such a patch could even be pushed upstream because it really makes sense generally (IMHO). Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, 18 Aug 2006, Andreas Hanke wrote:
It might make sense -- however, /usr/share/aclocal/dirlist.d/* is a SUSE-only thingy, IIUC. Stock automake only uses /usr/share/aclocal/dirlist, which is a symlink to /etc/aclocal_dirlist on SUSE. Do you have a patch to extend automake? ;) Regards Christoph --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, Christoph Thiel schrieb:
Do you have a patch to extend automake? ;)
No, I don't have such a patch right now. It's not difficult to do, but:
however, /usr/share/aclocal/dirlist.d/* is a SUSE-only thingy
If it's already a SUSE-only thingy, it shouldn't become more SUSE-only, it should become less SUSE-only. So just forget my proposal of patching it locally, it has to be implemented upstream. Until then, it is a very bad idea and there has to be a different solution. Btw. the current SuSEconfig.automake solution is not perfect either because it overwrites the dirlist with the contents of the dirlist.d/* files. So users are actually already forced to use the SUSE-only dirlist.d in order to get something into the dirlist! It would be overwritten otherwise. Now my idea was, do it entirely without overwriting the dirlist and entirely not SUSE-only, by just appending the directories to the existing dirlist in %post and removing it in %postun. And you have caught me, because it is difficult to do: - How to avoid adding entries which are already there? Use grep? - How to handle the situation that GNOME might move from /opt/gnome to /usr? - How to avoid accidentally removing still needed entries? Maybe SuSEconfig is not that bad after all ;-) What about just hard-coding /opt/gnome/share/aclocal into the dirlist, so that it's in the dirlist even if gnome-filesystem is not installed at all? Would that work? It looks ugly, but /etc/ld.so.conf has the same, it also references directories that might not exist at all on certain installations. Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Andreas Hanke a écrit :
sorry if what I say is stupid, but i read this thread from the start and now I wonder why is there a SUSE only thing? what is it's real use? couldn't it be removed/standardised? thanks jdd -- http://www.dodin.net http://dodin.org/galerie_photo_web/expo/index.html http://lucien.dodin.net http://fr.susewiki.org/index.php?title=Gérer_ses_photos --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, jdd schrieb:
It is there in order to make the aclocal search path extensible. It does not seem to be easily extensible without this stuff ("easily" from the RPM point of view). --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Andreas Hanke <andreas.hanke@gmx-topmail.de> writes:
[...] Maybe SuSEconfig is not that bad after all ;-)
There are cases where SuSEconfig is useable - but there are also cases where developers were lazy. SuSEconfig is slow and everybody complains about it - the easy way to remove it (doing everything in post-install scripts) will make package installation much slower (running scripts each time instead of once at the end). So, we might end with some scripts in the end - but only the bare minimum...
If this is specific script currently only used to add /opt/gnome, then this will be obsolete once we switch from /opt/gnome to /usr - and therefore we should remove it directly before others start using it. ;-) Andreas -- Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/ SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Hi, Andreas Jaeger schrieb:
Like that, yes. Actually it is used to add both /opt/gnome and /usr/local, and nothing else. But I don't see why /usr/local shouldn't be hardcoded - the dirlist entry which adds /usr/local is in the automake package itself, so hard-coding it wouldn't make any difference. I thought that being able to use this script to add arbitrary prefixes was intentional, but if it's not, why not just hardcode /usr/local permanently and /opt/gnome temporarily until GNOME moves to /usr? Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, Aug 18, 2006 at 03:06:51PM +0200, Christoph Thiel wrote:
Then stock automake should be enhanced here because having such *.d config directories is a _big_ help for packaging. Feel free to forward the following patch upstream and reference to me for further discussions.
Do you have a patch to extend automake? ;)
That's an easy one: --- ./aclocal.in~ 2006-08-18 20:14:43.000000000 +0200 +++ ./aclocal.in 2006-08-18 20:17:03.000000000 +0200 @@ -645,22 +645,25 @@ push (@dirlist, $acdir) unless $acdir eq $default_acdir && ! -d $acdir; - # Finally, adds any directory listed in the `dirlist' file. - if (open (DEFAULT_DIRLIST, $default_dirlist)) + # Finally, adds any directory listed in the `dirlist' files. + foreach my $dirlistfile (<${default_dirlist}{,.d/*}>) { - while (<DEFAULT_DIRLIST>) + if (open (DEFAULT_DIRLIST, $dirlistfile)) { - # Ignore '#' lines. - next if /^#/; - # strip off newlines and end-of-line comments - s/\s*\#.*$//; - chomp ($contents=$_); - if (-d $contents ) + while (<DEFAULT_DIRLIST>) { - push (@dirlist, $contents); + # Ignore '#' lines. + next if /^#/; + # strip off newlines and end-of-line comments + s/\s*\#.*$//; + chomp ($contents=$_); + if (-d $contents ) + { + push (@dirlist, $contents); + } } + close (DEFAULT_DIRLIST); } - close (DEFAULT_DIRLIST); } return @dirlist; Further comments or suggestions welcome. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
Hi, Robert Schiele schrieb:
Do you have a patch to extend automake? ;)
That's an easy one:
This patch applies to automake-1.9.6, but not to CVS HEAD. Someone has to decide: - Do we want to have an extensible aclocal search path? => Then a patch that applies to CVS HEAD must be sent upstream. If and after it has been accepted, SuSEconfig.automake becomes obsolete and can be dropped. - Don't we need an extensible aclocal search path? => Then SuSEconfig.automake can be dropped by including a static configuration file which at least temporarily references /opt/gnome/share/aclocal, or it has to be kept, or it has to be emulated within the %post scriptlet of gnome-filesystem. Sorry, I have to ask again because it's still not clear to me: Are the current dirlist.d and the fact that everyone can use this SUSE-only thingy a desired feature or are they an undesired side-effect of having GNOME in /opt/gnome? Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Sat, Aug 19, 2006 at 12:06:14AM +0200, Andreas Hanke wrote:
Sure, latest SUSE shipped version _is_ 1.9.6. But if this is a problem for people, then the same patch for the latest and greatest: --- ./aclocal.in~ 2006-08-19 01:24:44.000000000 +0200 +++ ./aclocal.in 2006-08-19 01:32:03.000000000 +0200 @@ -1001,22 +1001,26 @@ } else { - # Finally, adds any directory listed in the `dirlist' file. - if (open (DIRLIST, "$system_includes[0]/dirlist")) - { - while (<DIRLIST>) + # Finally, adds any directory listed in the `dirlist' file + # and `dirlist.d' directories. + foreach my $dirlistfile (<$system_includes[0]/dirlist{,.d/*}>) + { + if (open (DIRLIST, $dirlistfile)) { - # Ignore '#' lines. - next if /^#/; - # strip off newlines and end-of-line comments - s/\s*\#.*$//; - chomp; - foreach my $dir (glob) + while (<DIRLIST>) { - push (@system_includes, $dir) if -d $dir; + # Ignore '#' lines. + next if /^#/; + # strip off newlines and end-of-line comments + s/\s*\#.*$//; + chomp; + foreach my $dir (glob) + { + push (@system_includes, $dir) if -d $dir; + } } + close (DIRLIST); } - close (DIRLIST); } } }
Someone has to decide:
Ok, if someone has to decide, I decide for the first solution. ;-)
- Do we want to have an extensible aclocal search path? => Then a patch that applies to CVS HEAD must be sent upstream. If and after it has been
If someone sends this patch there now, this is easy. Otherwise I will send in about 10 days when I am back at home again and have the time to read all the mailing lists. If someone else sends it, I will be reachable by mail, just don't want to send something to mailing lists I currently don't read.
accepted, SuSEconfig.automake becomes obsolete and can be dropped.
It can be used even when the upstream integration process has not been completed because it is in my opinion a much better solution than the current script, even when the patch is not yet in upstream code.
Sure we need an extension mechanism for that. What do you think was the reason for implementing this dirlist stuff in aclocal at all? Even when GNOME didn't exist the option could be used by any package that provides something in an unusual path.
In my opinion it is a desired feature. It should be made a non-SUSE-only feature but as long as mainstream does not have it it does not really hurt because we had it anyway up to now by the script and nobody is forced to use it. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
Hi, Robert Schiele schrieb:
It's not a problem for me, but it would be a problem for upstream, and it has to go upstream, otherwise it doesn't make any sense - see below for reasons. Thanks for the updated patch.
The patch needs to be extended to cover the texinfo documentation and the testsuite as well. That is not difficult to do, but it should be done before posting the patch there.
No, see Stephan Kulow's post: That would break compatibility for those users who install a newer automake version from the upstream tarball. The self-installed automake would no longer find the GNOME macros. This currently works, ironically thanks to SuSEconfig, but would no longer work with this patch instead of SuSEconfig unless the patch is included upstream.
Sure we need an extension mechanism for that. What do you think was the reason for implementing this dirlist stuff in aclocal at all?
Actually I think that the reason for implementing it with SuSEconfig was laziness. It is a very ugly solution because it breaks using the dirlist file for local settings, the user is forced to use a SUSE-only dirlist.d/* file. Per se, it is not a bad feature at all, but a quick search on http://rpm.pbone.net for dirlist.d shows that it's currently really SUSE-only, which is bad. I was not aware of that when proposing this change.
As long as upstream automake reads only the dirlist file and not the dirlist.d directory, SuSEconfig is the better solution and dropping it would hurt those who update to an upstream version. So we really need either SuSEconfig or this patch in upstream CVS, but not this patch as a SUSE-only replacement for SuSEconfig.automake. Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Sat, Aug 19, 2006 at 02:27:16AM +0200, Andreas Hanke wrote:
I will look into that later then.
No, if you replace the SUSE version of automake with another one you also lose the SuSEconfig.automake file because it is part of the SUSE automake package. And apart from that: If someone replaces vital parts of the toolchain without having a clue about the effects and how to fix these problems then he definitely will run into much more harmful problems than the dirlist thing.
So the "new" implementation is better. It allows using both variants.
I don't see why it is bad because of that. I mean someone _had_ to invent it. Inventions are not done by doing everything the same way all other people do it.
I disagree. See above. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
On Fri, 18 Aug 2006, Robert Schiele wrote:
[...]
Further comments or suggestions welcome.
Thanks for the patch, Robert! I'd really appreciate if you could take the time to push it upstream. As soon as we have the patch in upstream, please file an enhancement request to get it included in our automake package as well. For now we will remove SuSEconfig.automake and add a static /usr/share/aclocale/dirlist -- Stanislav Brabec will take care of this change. Regards Christoph --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Am Freitag, 18. August 2006 13:41 schrieb Andreas Hanke:
The downside is that "other" automake versions won't find the right dirs and people update automake because open source projects requiring newer versions from time to time. Greetings, Stephan --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, 2006-08-18 at 13:35 +0200, Christoph Thiel wrote:
I suspect the gnome-filesystem one isn't really required anymore since /etc/profile.d/ is used by gnome to set ACLOCAL_FLAGS which is respected by gnome-autogen. Stanislav could comment more accurately though. -JP --
JP Rosevear <jpr@novell.com> Novell, Inc.
--------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, JP Rosevear schrieb:
Doesn't suffice for me. Running "autoreconf -fi" on inkscape with just ACLOCAL_FLAGS set does not work for me. The dirlist entry is really needed there. Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Mon, 2006-08-21 at 20:42 +0200, Andreas Hanke wrote:
gnome-autogen runs aclocal with the ACLOCAL_FLAGS included, so you are probably right and this won't work in the autoreconf case. Moving gnome to /usr should suffice though. -JP -- JP Rosevear <jpr@novell.com> Novell, Inc. --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, Christoph Thiel schrieb:
Not a "better" idea, just an alternative one: Patch aclocal to read the /usr/share/aclocal/dirlist.d/* files directly. Is that possible? The advantage is that people can still easily add more directories without knowing any details about what %post scripts to use. Maybe such a patch could even be pushed upstream because it really makes sense generally (IMHO). Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, 18 Aug 2006, Andreas Hanke wrote:
It might make sense -- however, /usr/share/aclocal/dirlist.d/* is a SUSE-only thingy, IIUC. Stock automake only uses /usr/share/aclocal/dirlist, which is a symlink to /etc/aclocal_dirlist on SUSE. Do you have a patch to extend automake? ;) Regards Christoph --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, Christoph Thiel schrieb:
Do you have a patch to extend automake? ;)
No, I don't have such a patch right now. It's not difficult to do, but:
however, /usr/share/aclocal/dirlist.d/* is a SUSE-only thingy
If it's already a SUSE-only thingy, it shouldn't become more SUSE-only, it should become less SUSE-only. So just forget my proposal of patching it locally, it has to be implemented upstream. Until then, it is a very bad idea and there has to be a different solution. Btw. the current SuSEconfig.automake solution is not perfect either because it overwrites the dirlist with the contents of the dirlist.d/* files. So users are actually already forced to use the SUSE-only dirlist.d in order to get something into the dirlist! It would be overwritten otherwise. Now my idea was, do it entirely without overwriting the dirlist and entirely not SUSE-only, by just appending the directories to the existing dirlist in %post and removing it in %postun. And you have caught me, because it is difficult to do: - How to avoid adding entries which are already there? Use grep? - How to handle the situation that GNOME might move from /opt/gnome to /usr? - How to avoid accidentally removing still needed entries? Maybe SuSEconfig is not that bad after all ;-) What about just hard-coding /opt/gnome/share/aclocal into the dirlist, so that it's in the dirlist even if gnome-filesystem is not installed at all? Would that work? It looks ugly, but /etc/ld.so.conf has the same, it also references directories that might not exist at all on certain installations. Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Andreas Hanke a écrit :
sorry if what I say is stupid, but i read this thread from the start and now I wonder why is there a SUSE only thing? what is it's real use? couldn't it be removed/standardised? thanks jdd -- http://www.dodin.net http://dodin.org/galerie_photo_web/expo/index.html http://lucien.dodin.net http://fr.susewiki.org/index.php?title=Gérer_ses_photos --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Hi, jdd schrieb:
It is there in order to make the aclocal search path extensible. It does not seem to be easily extensible without this stuff ("easily" from the RPM point of view). --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
Andreas Hanke <andreas.hanke@gmx-topmail.de> writes:
[...] Maybe SuSEconfig is not that bad after all ;-)
There are cases where SuSEconfig is useable - but there are also cases where developers were lazy. SuSEconfig is slow and everybody complains about it - the easy way to remove it (doing everything in post-install scripts) will make package installation much slower (running scripts each time instead of once at the end). So, we might end with some scripts in the end - but only the bare minimum...
If this is specific script currently only used to add /opt/gnome, then this will be obsolete once we switch from /opt/gnome to /usr - and therefore we should remove it directly before others start using it. ;-) Andreas -- Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/ SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Hi, Andreas Jaeger schrieb:
Like that, yes. Actually it is used to add both /opt/gnome and /usr/local, and nothing else. But I don't see why /usr/local shouldn't be hardcoded - the dirlist entry which adds /usr/local is in the automake package itself, so hard-coding it wouldn't make any difference. I thought that being able to use this script to add arbitrary prefixes was intentional, but if it's not, why not just hardcode /usr/local permanently and /opt/gnome temporarily until GNOME moves to /usr? Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Fri, Aug 18, 2006 at 03:06:51PM +0200, Christoph Thiel wrote:
Then stock automake should be enhanced here because having such *.d config directories is a _big_ help for packaging. Feel free to forward the following patch upstream and reference to me for further discussions.
Do you have a patch to extend automake? ;)
That's an easy one: --- ./aclocal.in~ 2006-08-18 20:14:43.000000000 +0200 +++ ./aclocal.in 2006-08-18 20:17:03.000000000 +0200 @@ -645,22 +645,25 @@ push (@dirlist, $acdir) unless $acdir eq $default_acdir && ! -d $acdir; - # Finally, adds any directory listed in the `dirlist' file. - if (open (DEFAULT_DIRLIST, $default_dirlist)) + # Finally, adds any directory listed in the `dirlist' files. + foreach my $dirlistfile (<${default_dirlist}{,.d/*}>) { - while (<DEFAULT_DIRLIST>) + if (open (DEFAULT_DIRLIST, $dirlistfile)) { - # Ignore '#' lines. - next if /^#/; - # strip off newlines and end-of-line comments - s/\s*\#.*$//; - chomp ($contents=$_); - if (-d $contents ) + while (<DEFAULT_DIRLIST>) { - push (@dirlist, $contents); + # Ignore '#' lines. + next if /^#/; + # strip off newlines and end-of-line comments + s/\s*\#.*$//; + chomp ($contents=$_); + if (-d $contents ) + { + push (@dirlist, $contents); + } } + close (DEFAULT_DIRLIST); } - close (DEFAULT_DIRLIST); } return @dirlist; Further comments or suggestions welcome. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
Hi, Robert Schiele schrieb:
Do you have a patch to extend automake? ;)
That's an easy one:
This patch applies to automake-1.9.6, but not to CVS HEAD. Someone has to decide: - Do we want to have an extensible aclocal search path? => Then a patch that applies to CVS HEAD must be sent upstream. If and after it has been accepted, SuSEconfig.automake becomes obsolete and can be dropped. - Don't we need an extensible aclocal search path? => Then SuSEconfig.automake can be dropped by including a static configuration file which at least temporarily references /opt/gnome/share/aclocal, or it has to be kept, or it has to be emulated within the %post scriptlet of gnome-filesystem. Sorry, I have to ask again because it's still not clear to me: Are the current dirlist.d and the fact that everyone can use this SUSE-only thingy a desired feature or are they an undesired side-effect of having GNOME in /opt/gnome? Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Sat, Aug 19, 2006 at 12:06:14AM +0200, Andreas Hanke wrote:
Sure, latest SUSE shipped version _is_ 1.9.6. But if this is a problem for people, then the same patch for the latest and greatest: --- ./aclocal.in~ 2006-08-19 01:24:44.000000000 +0200 +++ ./aclocal.in 2006-08-19 01:32:03.000000000 +0200 @@ -1001,22 +1001,26 @@ } else { - # Finally, adds any directory listed in the `dirlist' file. - if (open (DIRLIST, "$system_includes[0]/dirlist")) - { - while (<DIRLIST>) + # Finally, adds any directory listed in the `dirlist' file + # and `dirlist.d' directories. + foreach my $dirlistfile (<$system_includes[0]/dirlist{,.d/*}>) + { + if (open (DIRLIST, $dirlistfile)) { - # Ignore '#' lines. - next if /^#/; - # strip off newlines and end-of-line comments - s/\s*\#.*$//; - chomp; - foreach my $dir (glob) + while (<DIRLIST>) { - push (@system_includes, $dir) if -d $dir; + # Ignore '#' lines. + next if /^#/; + # strip off newlines and end-of-line comments + s/\s*\#.*$//; + chomp; + foreach my $dir (glob) + { + push (@system_includes, $dir) if -d $dir; + } } + close (DIRLIST); } - close (DIRLIST); } } }
Someone has to decide:
Ok, if someone has to decide, I decide for the first solution. ;-)
- Do we want to have an extensible aclocal search path? => Then a patch that applies to CVS HEAD must be sent upstream. If and after it has been
If someone sends this patch there now, this is easy. Otherwise I will send in about 10 days when I am back at home again and have the time to read all the mailing lists. If someone else sends it, I will be reachable by mail, just don't want to send something to mailing lists I currently don't read.
accepted, SuSEconfig.automake becomes obsolete and can be dropped.
It can be used even when the upstream integration process has not been completed because it is in my opinion a much better solution than the current script, even when the patch is not yet in upstream code.
Sure we need an extension mechanism for that. What do you think was the reason for implementing this dirlist stuff in aclocal at all? Even when GNOME didn't exist the option could be used by any package that provides something in an unusual path.
In my opinion it is a desired feature. It should be made a non-SUSE-only feature but as long as mainstream does not have it it does not really hurt because we had it anyway up to now by the script and nobody is forced to use it. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
Hi, Robert Schiele schrieb:
It's not a problem for me, but it would be a problem for upstream, and it has to go upstream, otherwise it doesn't make any sense - see below for reasons. Thanks for the updated patch.
The patch needs to be extended to cover the texinfo documentation and the testsuite as well. That is not difficult to do, but it should be done before posting the patch there.
No, see Stephan Kulow's post: That would break compatibility for those users who install a newer automake version from the upstream tarball. The self-installed automake would no longer find the GNOME macros. This currently works, ironically thanks to SuSEconfig, but would no longer work with this patch instead of SuSEconfig unless the patch is included upstream.
Sure we need an extension mechanism for that. What do you think was the reason for implementing this dirlist stuff in aclocal at all?
Actually I think that the reason for implementing it with SuSEconfig was laziness. It is a very ugly solution because it breaks using the dirlist file for local settings, the user is forced to use a SUSE-only dirlist.d/* file. Per se, it is not a bad feature at all, but a quick search on http://rpm.pbone.net for dirlist.d shows that it's currently really SUSE-only, which is bad. I was not aware of that when proposing this change.
As long as upstream automake reads only the dirlist file and not the dirlist.d directory, SuSEconfig is the better solution and dropping it would hurt those who update to an upstream version. So we really need either SuSEconfig or this patch in upstream CVS, but not this patch as a SUSE-only replacement for SuSEconfig.automake. Andreas Hanke --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-factory+help@opensuse.org
On Sat, Aug 19, 2006 at 02:27:16AM +0200, Andreas Hanke wrote:
I will look into that later then.
No, if you replace the SUSE version of automake with another one you also lose the SuSEconfig.automake file because it is part of the SUSE automake package. And apart from that: If someone replaces vital parts of the toolchain without having a clue about the effects and how to fix these problems then he definitely will run into much more harmful problems than the dirlist thing.
So the "new" implementation is better. It allows using both variants.
I don't see why it is bad because of that. I mean someone _had_ to invent it. Inventions are not done by doing everything the same way all other people do it.
I disagree. See above. Robert -- Robert Schiele Tel.: +49-621-181-2214 Dipl.-Wirtsch.informatiker mailto:rschiele@uni-mannheim.de "Quidquid latine dictum sit, altum sonatur."
participants (7)
-
Andreas Hanke -
Andreas Jaeger -
Christoph Thiel -
jdd -
JP Rosevear -
Robert Schiele -
Stephan Kulow