[opensuse-factory] Renaming patches (was: Re: New Tumbleweed snapshot 20151227 released!)
Hello, Am Dienstag, 29. Dezember 2015 schrieb Ludwig Nussel:
May I ask for the reason to rename those patches? (IMHO "the filename contains a wrong version numbrer" isn't a reason, but maybe that's just my opinion.) I'd just keep the original name even if it contains a "wrong" version number because a) it avoids superfluous noise in the diff (which also means small changes in the patches could go unnoticed in the review) b) I'm lazy ;-) and c) I wouldn't include a version in a patch name from the beginning. I noticed that you also removed some upstreamed patches, and I'm happy to see that. But that still doesn't explain why you rename the not-upstreamed patches on every release ;-) Regards, Christian Boltz -- Insgesamt denke ich, dass es einfacher ist, sich eine Pistole anzuschaffen und sich in den Fuß zu schiessen. Das Ergebnis ist das gleiche, aber wenigstens belästigst du nicht andere dabei. (^-^) [Sandy Drobic in postfixbuch-users über a-s-k.sourceforge.net] -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tue, Dec 29, 2015 at 12:21 PM, Christian Boltz <opensuse@cboltz.de> wrote:
Further, it is my understanding the version number in the patch name is typically used to designate the package version where the patch was introduced to the openSUSE package. Thus a renaming to the current version is the opposite of what is expected by most packagers. Greg -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Tue, Dec 29, 2015 at 12:21 PM, Christian Boltz <opensuse@cboltz.de> wrote:
Further, it is my understanding the version number in the patch name is typically used to designate the package version where the patch was introduced to the openSUSE package. Thus a renaming to the current version is the opposite of what is expected by most packagers. Greg -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (2)
-
Christian Boltz -
Greg Freemyer