Re: [opensuse-factory] New Tumbleweed snapshot 20151214 released!
Ludwig Nussel wrote:
[...] ==== autofs ====
Watchful readers may have noticed that the autofs changes listed here are way more than what the source diff shows. I debugged that and the reason is funny enough to share IMO :-) The announcer computes the changelog entries to show by looking at the binary rpm. The binary rpm stores an array of time stamps and an array of texts for each time stamp. So the announcer walks the new package's timestamp array, collecting the text until the timestamp of the new package matches the first entry of the old package. Sounds easy, there was only one change: https://build.opensuse.org/package/rdiff/openSUSE:Factory/autofs?linkrev=base&rev=107 However, what ends up in the binary rpm is not exactly the content of that file. The changelog2spec script reads the .changes file at build time and generates the %changelog section in the .spec file from it. The %changelog section doesn't record time zones so that information has to be stripped. Now for whatever reason that predates obs the script takes the time zone of the first .changes file entry to convert all following timestamps to that time zone: https://github.com/openSUSE/obs-build/blob/master/changelog2spec#L104 Since the previous entry in the .changes file was made half an hour before midnight in UTC and the new entry is CET (UTC+1), the new binary rpm now actually lists June 26 instead of June 25... So the announcer script never finds a matching time stamp and prints the full changelog. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.com/ SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Thursday 17 December 2015 17.46:59 Ludwig Nussel wrote:
Ludwig Nussel wrote:
[...] ==== autofs ====
Watchful readers may have noticed that the autofs changes listed here are way more than what the source diff shows. I debugged that and the reason is funny enough to share IMO :-)
The announcer computes the changelog entries to show by looking at the binary rpm. The binary rpm stores an array of time stamps and an array of texts for each time stamp. So the announcer walks the new package's timestamp array, collecting the text until the timestamp of the new package matches the first entry of the old package. Sounds easy, there was only one change: https://build.opensuse.org/package/rdiff/openSUSE:Factory/autofs?linkrev=base&rev=107
However, what ends up in the binary rpm is not exactly the content of that file. The changelog2spec script reads the .changes file at build time and generates the %changelog section in the .spec file from it. The %changelog section doesn't record time zones so that information has to be stripped. Now for whatever reason that predates obs the script takes the time zone of the first .changes file entry to convert all following timestamps to that time zone: https://github.com/openSUSE/obs-build/blob/master/changelog2spec#L104
Since the previous entry in the .changes file was made half an hour before midnight in UTC and the new entry is CET (UTC+1), the new binary rpm now actually lists June 26 instead of June 25...
So the announcer script never finds a matching time stamp and prints the full changelog.
cu Ludwig
Isn't that Having a lot of fun, thanks for the sharing, make my afternoon :-) -- Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch openSUSE Member & Board, fsfe fellowship GPG KEY : D5C9B751C4653227 irc: tigerfoot -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On 17 December 2015 at 16:46, Ludwig Nussel <ludwig.nussel@suse.de> wrote:
Since the previous entry in the .changes file was made half an hour before midnight in UTC and the new entry is CET (UTC+1), the new binary rpm now actually lists June 26 instead of June 25...
So the announcer script never finds a matching time stamp and prints the full changelog.
Reminds me of this lovely video "The Problem with Time & Timezones" - https://www.youtube.com/watch?v=-5wpm-gesOY -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (3)
-
Bruno Friedmann
-
Ludwig Nussel
-
Richard Brown