[opensuse-factory] Base:System util-linux, regarding sr 226509
Hi, The ChangeLog is almost useless since none of the referenced bug reports is readable for non-suse people. At least one of the added patches ("umount-avoid-readlink.patch") has no effect because it patches a deprecated and unused subdir which will be removed in next release anyway. Please somebody have a look at the last changelog and either make the bug reports world-readable or fix the changlog to explain the purpose of these patches: ------------ Mon Mar 17 22:36:58 CET 2014 - sbrabec@suse.cz - Merge fixes and features from SLE11 (bnc#831868): * Detect squashfs version <= 3 as squashfs3 and version >= 4 as squashfs. (mszeredi@suse.cz, util-linux-ng-2.16-squashfs3-detect.patch, bnc#666893) * add sfdisk-warn-about-2TB-limit.patch (puzel@novell.com, bnc#495657) * Document barrier option in mount.8 (jack@suse.cz, hvogel@suse.de, util-linux-ng-2.19.1-barrier_documentation.patch, bnc#489740) * lscpu: improve hypervisor detection (puzel@novell.com, fate#310255) - util-linux-lscpu-improve-hypervisor-detection.patch * umount: avoid calling readlink on mountpoints if not necessary - add: umount-avoid-readlink.patch (puzel@suse.com, bnc#794529) * fix file conflict between util-linux and s390-32 (puzel@suse.com, bnc#805684) * util-linux-update-default-commit-interval.patch: mount(8): update default commit interval (puzel@suse.com, bnc#809480) * Obsolete no more packaged uuid-runtime. - Add uname26 (util-linux-setarch-uname26.patch, FATE#313476). ---------------- cu, Rudi -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On 03/21/2014 01:11 PM, Ruediger Meier wrote:
IMHO the Changelog should be kept terse, and the reason for a patch should be kept within the patch. In the above mentioned case, all LGTM: https://build.opensuse.org/package/view_file/Base:System/util-linux/umount-a... Unfortunately, the referenced bug bnc#794529 can't be read by non-SUSEs. Have a nice day, Berny -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Fri, 21 Mar 2014 16:24, Bernhard Voelker <mail@...> wrote:
Nothing against a terse rpm-changelog. BUT for all what is considered holy, put a full version of it in the %{docdir}/Changelog , esp if -like here- most of the needed info is inaccessible for non-insiders. That goes double for the essential packages of the Base:System pool. The nice part of stuff in %{docdir} is, that is can be excluded from being installed via rpm (rpm --excludedocs), and via /etc/zypp/zypp.conf (rpm.install.excludedocs = yes). - Yamaban. -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
Ruediger Meier wrote:
These changelogs were taken from the original changelog. Many of openSUSE changelogs refer to bugs that are not accessible. In ideal case, people working on SLES fix would post the same patch to openSUSE, and make a public clone of the bug report. It did not happened, and a review found these patches, where the patch was not posted to Factory nor upstream.
Yes, it is deliberate. The patch was created for SLE11 and affects the code, which is now deprecated and not used. I did not want to lose this patch and save it for upstreaming. Collecting upstream-able patches will take some time. Hopefully these patches will disappear from the Factory then.
SLES bug reports that contain sensitive customer data cannot be opened for public. Most of these patches are self descriptive. Well, this one is probably not true for umount-avoid-readlink.patch: It's purpose is avoiding a readlink() failure when umount'ing stale NFS volumes.
-- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz Lihovarská 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
On Friday 21 March 2014, Stanislav Brabec wrote:
Upstream has already removed the whole code.
Collecting upstream-able patches will take some time. Hopefully these patches will disappear from the Factory then.
I'd like to help to get useful patches upstream. But it's hard if I'm not allowed to know anything about the fixed issues.
Have you really checked all the bug reports and they all contain sensitive data?
But today your patch only changes unused code. If this is still an issue in the new code then your patch will not fix it. Volunteer reviewers (like me) cannot really check if there is still an issue or not. Also I'd like to check whether this patch would be good for Evergreen 11.4.
* lscpu: improve hypervisor detection (puzel@novell.com, fate#310255)
This patch for example breaks a test in the test suite. None of us can read the discussion about this new feature. non-SLE people had no chance to say their opinion about it. cu, Rudi -- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org
participants (4)
-
Bernhard Voelker -
Ruediger Meier -
Stanislav Brabec -
Yamaban