Who is still using /etc/sysconfig/windowmanager?
Hi, when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead. Since this file is SUSE specific, who is really using this variable and can we drop that config file completely? DEFAULT_WM seems to be used by: * gdm (I think we can just drop that patch?) * xdm (we should hardcode DEFAULT_WM with "default" and are fine) I haven't found more. Then we have INSTALL_DESKTOP_EXTENSIONS Who is using that? I couldn't find anything using that variable. For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users. Thanks, Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologies SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nuernberg, Germany Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG Nürnberg)
On Fri, 2024-08-09 at 10:42 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
AFAIK, all our Login Managers (gdm, sddm, lightdm) as they are supposed to follow the same system defaults At least on GDM, there is gdm-default-wm.patch present for that. But there is also the initiative https://en.opensuse.org/openSUSE:DisplayManagerRework that wants to rework how the DMs are present anyway (i.e eliminate the 'xdm' wrapper, and go straight to the DM) - this initiative might as well go away with the requirement to have all DMs adhere to central configuration files. Cheers, Dominique
On Fri, Aug 9, 2024 at 10:53 AM Dominique Leuenberger <dimstar@opensuse.org> wrote:
On Fri, 2024-08-09 at 10:42 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
AFAIK, all our Login Managers (gdm, sddm, lightdm) as they are supposed to follow the same system defaults
According to the comment in the sysconfig file they switched to update-alternatives. And the initiative is to get rid of update-alternatives and implement that directly as systemd service. xdm is using DEFAULT_WM instead of default.desktop symlink from update-alternatives, easy to fix. And it's the only display manager I could find.
At least on GDM, there is gdm-default-wm.patch present for that.
Yes, but that's only GDM, sddm and lightdm have no support for DEFAULT_WM anymore, not a single line of code. Looks like the patch in GDM was forgotten when we switched from sysconfig/windowmanager to update-alternatives. Could it be that you are one implementation behind? I don't want to drop update-alternatives and default.desktop symlink. Thorsten
But there is also the initiative https://en.opensuse.org/openSUSE:DisplayManagerRework that wants to rework how the DMs are present anyway (i.e eliminate the 'xdm' wrapper, and go straight to the DM) - this initiative might as well go away with the requirement to have all DMs adhere to central configuration files.
Cheers, Dominique
-- Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologies SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nuernberg, Germany Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG Nürnberg)
On Fri, 2024-08-09 at 11:06 +0200, Thorsten Kukuk wrote:
On Fri, Aug 9, 2024 at 10:53 AM Dominique Leuenberger <dimstar@opensuse.org> wrote:
On Fri, 2024-08-09 at 10:42 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
AFAIK, all our Login Managers (gdm, sddm, lightdm) as they are supposed to follow the same system defaults
According to the comment in the sysconfig file they switched to update-alternatives. And the initiative is to get rid of update-alternatives and implement that directly as systemd service.
xdm is using DEFAULT_WM instead of default.desktop symlink from update-alternatives, easy to fix. And it's the only display manager I could find.
At least on GDM, there is gdm-default-wm.patch present for that.
Yes, but that's only GDM, sddm and lightdm have no support for DEFAULT_WM anymore, not a single line of code. Looks like the patch in GDM was forgotten when we switched from sysconfig/windowmanager to update-alternatives.
Could it be that you are one implementation behind? I don't want to drop update-alternatives and default.desktop symlink.
yay - a patch to drop ! :) I'm on it
Moin, On Fri, 09 Aug 2024, 10:42:50 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
DEFAULT_WM seems to be used by: * gdm (I think we can just drop that patch?) * xdm (we should hardcode DEFAULT_WM with "default" and are fine)
I haven't found more.
# find / -xdev -type f -print0 | xargs -0 -r grep -lw DEFAULT_WM shows quite some files. At least /usr/etc/X11/xinit/xinitrc.common /usr/etc/profile.d/profile.csh /usr/etc/profile.d/profile.sh should be looked at as they set WINDOWMANAGER based on DEFAULT_WM.
[...] For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users.
Thanks, Thorsten
Cheers. l8er manfred
On Fri, Aug 9, 2024 at 11:25 AM Manfred Hollstein <mhollstein@t-online.de> wrote:
Moin,
On Fri, 09 Aug 2024, 10:42:50 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
DEFAULT_WM seems to be used by: * gdm (I think we can just drop that patch?) * xdm (we should hardcode DEFAULT_WM with "default" and are fine)
I haven't found more.
# find / -xdev -type f -print0 | xargs -0 -r grep -lw DEFAULT_WM
shows quite some files. At least
/usr/etc/X11/xinit/xinitrc.common
Comments only, not in code.
/usr/etc/profile.d/profile.csh /usr/etc/profile.d/profile.sh
should be looked at as they set WINDOWMANAGER based on DEFAULT_WM.
Yes, but that's dead/non-functional code as we use update-alternatives today since now 7 years... Instead of keeping and maintaining unused code because it's referencing deprecated/unused variables, we should drop all of this. If I see "startproc" in the "display-manager" script you know how much of this code is really used... Thorsten
[...] For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users.
Thanks, Thorsten
Cheers.
l8er manfred
-- Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologies SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nuernberg, Germany Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG Nürnberg)
On 8/9/24 7:32 PM, Thorsten Kukuk via openSUSE Factory wrote:
On Fri, Aug 9, 2024 at 11:25 AM Manfred Hollstein <mhollstein@t-online.de> wrote:
Moin,
On Fri, 09 Aug 2024, 10:42:50 +0200, Thorsten Kukuk via openSUSE Factory wrote:
Hi,
when cleaning up aaa_base from old, outdated staff, I run over: /etc/sysconfig/windowmanager
The DEFAULT_WM entry has: # This value is deprecated and not read by most display managers. # Use 'update-alternatives --config default-xsession.desktop' for configuration instead.
Since this file is SUSE specific, who is really using this variable and can we drop that config file completely?
DEFAULT_WM seems to be used by: * gdm (I think we can just drop that patch?) * xdm (we should hardcode DEFAULT_WM with "default" and are fine)
I haven't found more.
# find / -xdev -type f -print0 | xargs -0 -r grep -lw DEFAULT_WM
shows quite some files. At least
/usr/etc/X11/xinit/xinitrc.common
Comments only, not in code.
/usr/etc/profile.d/profile.csh /usr/etc/profile.d/profile.sh
should be looked at as they set WINDOWMANAGER based on DEFAULT_WM.
Yes, but that's dead/non-functional code as we use update-alternatives today since now 7 years...
Instead of keeping and maintaining unused code because it's referencing deprecated/unused variables, we should drop all of this. If I see "startproc" in the "display-manager" script you know how much of this code is really used...
In my mind dropping this is reasonable if someone is choosing to launch a desktop without a Display Manager, they should have the knowledge to put the desktop they would like directly into there shell config anyway. -- Simon Lees (Simotek) http://simotek.net Emergency Update Team keybase.io/simotek SUSE Linux Adelaide Australia, UTC+10:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B
Thorsten Kukuk composed on 2024-08-09 10:42 (UTC+0200):
For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users.
What else is there for globally defining X_MOUSE_CURSOR=? I have "DMZ-White" in all mine. -- Evolution as taught in public schools is, like religion, based on faith, not based on science. Team OS/2 ** Reg. Linux User #211409 ** a11y rocks! Felix Miata
On Fri, Aug 9, 2024 at 5:01 PM Felix Miata <mrmazda@earthlink.net> wrote:
Thorsten Kukuk composed on 2024-08-09 10:42 (UTC+0200):
For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users.
What else is there for globally defining X_MOUSE_CURSOR=? I have "DMZ-White" in all mine.
This variable is not coming from aaa_base, which creates this file. So whoever adds this entry, this will still happen. But much better is to follow upstream standards and directly set the environment variable "XCURSOR_THEME". This avoids all the code required to assign X_MOUSE_COURSOR to XCURSOR_THEME in the scripts and is no openSUSE only special solution. Following standards and upstream should always and ever be prefered over some complicated openSUSE only solutions... Thorsten -- Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologies SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nuernberg, Germany Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG Nürnberg)
Thorsten Kukuk composed on 2024-08-09 17:17 (UTC+0200):
Felix Miata wrote:
Thorsten Kukuk composed on 2024-08-09 10:42 (UTC+0200):
For me it looks like we should drop /etc/sysconfig/windowmanager if nothing is using that anymore to not confuse users.
What else is there for globally defining X_MOUSE_CURSOR=? I have "DMZ-White" in all mine.
This variable is not coming from aaa_base, which creates this file. So whoever adds this entry, this will still happen.
When I find it initially, it's either set to "DMZ", or "".
But much better is to follow upstream standards and directly set the environment variable "XCURSOR_THEME". This avoids all the code
Which upstream is responsible for the applicable standard here?
required to assign X_MOUSE_COURSOR to XCURSOR_THEME in the scripts and is no openSUSE only special solution.
Following standards and upstream should always and ever be prefered over some complicated openSUSE only solutions...
I'm at a loss to determine who/what put X_MOUSE_CURSOR= in windowmanager. Also, not infrequently it gets newlines changed during zypper up/dup, typically one subtracted and one added. How can be determined what made those changes? Similar happens in /etc/zypp/zyp*conf, except more than just two per instance. -- Evolution as taught in public schools is, like religion, based on faith, not based on science. Team OS/2 ** Reg. Linux User #211409 ** a11y rocks! Felix Miata
On Fri, 09 Aug 2024, 17:39:55 +0200, Felix Miata wrote:
Thorsten Kukuk composed on 2024-08-09 17:17 (UTC+0200): [...] Also, not infrequently it gets newlines changed during zypper up/dup, typically one subtracted and one added. How can be determined what made those changes?
That's caused by fillup invoked by the postin scripts of most packages. I find it quite annoying, too.
Similar happens in /etc/zypp/zyp*conf, except more than just two per instance.
That's usually real changes to the config file. If you've made changes, luckily rpm, invoked by zypper up/dup, will leave a .rpmsave or .rpmnew file :-), so can be easily detected. Cheers. l8er manfred
Hello, Am Freitag, 9. August 2024, 17:39:55 MESZ schrieb Felix Miata:
I'm at a loss to determine who/what put X_MOUSE_CURSOR= in windowmanager.
That's quite easy to find out - you "just" need to know where to look ;-) # grep -r X_MOUSE_CURSOR /usr/share/fillup-templates/ /usr/share/fillup-templates/sysconfig.windowmanager-desktop-data-openSUSE:X_MOUSE_CURSOR="" # rpm -qf /usr/share/fillup-templates/sysconfig.windowmanager-desktop-data-openSUSE desktop-data-openSUSE-15.2.20200107-2.12.noarch Regards, Christian Boltz -- Every addition of patches and {extra files not maintained by upstream} to a SRPM I hate to do and maintain, and hate it by line count. [Jan Engelhardt in opensuse-factory]
participants (6)
-
Christian Boltz -
Dominique Leuenberger -
Felix Miata -
Manfred Hollstein -
Simon Lees -
Thorsten Kukuk