Re: 2.6.16 serious consequences / GPL_EXPORT_SYMBOL / USB drivers of major vendor excluded
Hi, this also affects the smartlink-modem: https://bugzilla.novell.com/show_bug.cgi?id=144600 On Sun, 5 Feb 2006, Greg KH wrote:
On Fri, Feb 03, 2006 at 05:24:10PM +0100, s.schmidt@avm.de wrote:
on January 15th / major change in USB subsystem and GPL_EXPORT_SYMBOL declaration Greg Kroah-Hartman added a Patch to kernel 2.6.15-git12, which substantially changed the USB system.
Have you asked Greg why he did this?
Have you asked what the other alternatives are?
You do know about usbfs/libusb that allows you to write USB drivers in userspace that can go at the full speed of the USB bus? Why not redo your code to take advantage of this? If you do that, the extra bonus is that your drivers will also work on the BSDs and possibly Windows with no changes needed (I think libusb works on Windows...)
This mail is not intended to provoke a discussion of open vs closed source. The only intention of this mail is to make you aware of the consequences of such a decision.
I was not aware of your drivers, but now that you have informed me of them, I am willing to work with you to figure out how to resolve this issue.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
-- Andreas Klein Andreas.C.Klein@physik.uni-wuerzburg.de
Am Montag, 6. Februar 2006 13:45 schrieb Andreas Klein:
Hi, this also affects the smartlink-modem: https://bugzilla.novell.com/show_bug.cgi?id=144600
On Sun, 5 Feb 2006, Greg KH wrote:
On Fri, Feb 03, 2006 at 05:24:10PM +0100, s.schmidt@avm.de wrote:
on January 15th / major change in USB subsystem and GPL_EXPORT_SYMBOL declaration Greg Kroah-Hartman added a Patch to kernel 2.6.15-git12, which substantially changed the USB system.
Have you asked Greg why he did this?
Have you asked what the other alternatives are?
You do know about usbfs/libusb that allows you to write USB drivers in userspace that can go at the full speed of the USB bus? Why not redo your code to take advantage of this? If you do that, the extra bonus is that your drivers will also work on the BSDs and possibly Windows with no changes needed (I think libusb works on Windows...)
This mail is not intended to provoke a discussion of open vs closed source. The only intention of this mail is to make you aware of the consequences of such a decision.
I was not aware of your drivers, but now that you have informed me of them, I am willing to work with you to figure out how to resolve this issue.
thanks,
greg k-h
Those who matter may check, if Greg's yesterday kernel-tree git commit with id 410c05427a69f53851637ccb85c2212131409fbd fix these issues? For your convenience, here it is: Subject: [PATCH] USB: Fix GPL markings on usb core functions. From: Greg KH <gregkh@suse.de> Date: 1139177768 -0800 I thought we had fixed up all non-gpl USB drivers, and was wrong to do this. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org> --- drivers/usb/core/driver.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) 410c05427a69f53851637ccb85c2212131409fbd diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 076462c..dce9d98 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -378,7 +378,7 @@ const struct usb_device_id *usb_match_id return NULL; } -EXPORT_SYMBOL_GPL(usb_match_id); +EXPORT_SYMBOL(usb_match_id); int usb_device_match(struct device *dev, struct device_driver *drv) { @@ -446,7 +446,7 @@ int usb_register_driver(struct usb_drive return retval; } -EXPORT_SYMBOL_GPL(usb_register_driver); +EXPORT_SYMBOL(usb_register_driver); /** * usb_deregister - unregister a USB driver @@ -469,4 +469,4 @@ void usb_deregister(struct usb_driver *d usbfs_update_special(); } -EXPORT_SYMBOL_GPL(usb_deregister); +EXPORT_SYMBOL(usb_deregister); -- 1.1.6 Pete
participants (2)
-
Andreas Klein -
Hans-Peter Jansen