FreeCAD dependency question
Hello, Just installed FreeCAD, got into add-on manager, and got the error message saying that GitPython isn't installed so it wouldn't be able to source macros for git. Installing python38-GitPython makes the message go away Now, I'm on with the fix which is a simple dep fix, but I'm having a dilemma so I'm looking for comments. As this is for the add-on manager, that dep is not necessary to use the software, only needed to pull macros from git sources. Regarding that, I'd put a `Recommends: python3-GitPython`, but I have the feeling that a full `Requires:` is more suited I'd love to get some thoughts Regards, Nicolas FORMICHELLA
Hello Nicolas, Am Samstag, 1. Januar 2022, 23:01:49 CET schrieb Nicolas Formichella:
As this is for the add-on manager, that dep is not necessary to use the software, only needed to pull macros from git sources.
If add-on manager comes with the FreeCad package, 'Requires:' would be the appropriate answer. If it is a separate package (like FreeCAD-addon-manager) it would be required in the separate package, not in the FreeCAD package
Regarding that, I'd put a `Recommends: python3-GitPython`, but I have the feeling that a full `Requires:` is more suited
'Recommends' can easily be overruled during the installation, resulting in a broken application. So 'Requires' is IMO the correct solution. My 2c.... Axel
On 1/2/22 10:54, Axel Braun wrote:
Am Samstag, 1. Januar 2022, 23:01:49 CET schrieb Nicolas Formichella:
Regarding that, I'd put a `Recommends: python3-GitPython`, but I have the feeling that a full `Requires:` is more suited
'Recommends' can easily be overruled during the installation, resulting in a broken application. So 'Requires' is IMO the correct solution.
Please define "broken application" more precisely. As I understood the original posting FreeCAD works just fine without this dependency by automatically disabling some functionality probably not needed by every FreeCAD user. IMO this is not something I'd call a "broken application". => IMHO 'Recommends' is most appropriate choice. Ciao, Michael.
Am Sonntag, 2. Januar 2022, 13:11:05 CET schrieb Michael Ströder:
On 1/2/22 10:54, Axel Braun wrote:
Am Samstag, 1. Januar 2022, 23:01:49 CET schrieb Nicolas Formichella:
Regarding that, I'd put a `Recommends: python3-GitPython`, but I have the feeling that a full `Requires:` is more suited
'Recommends' can easily be overruled during the installation, resulting in a broken application. So 'Requires' is IMO the correct solution.
Please define "broken application" more precisely.
Not all functionality as delivered in the package can be used without creating a dump/error. So it is broken, even of by chance most of the stuff works.
As I understood the original posting FreeCAD works just fine without this dependency by automatically disabling some functionality probably not needed by every FreeCAD user. IMO this is not something I'd call a "broken application".
If this functionality is not needed by every user, maybe it can be split out into a separate package? In that case FreeCAD itself is lean, and if someone needs the function he can install the additional package including GitPython. Cheers Axel
participants (3)
-
Axel Braun -
Michael Ströder -
Nicolas Formichella